From: "H. Peter Anvin" <hpa@zytor.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andreas Schwab <schwab@linux-m68k.org>,
Ian Kent <raven@themaw.net>, David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, autofs@vger.kernel.org,
Thomas Meyer <thomas@m3y3r.de>, Al Viro <viro@zeniv.linux.org.uk>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH] autofs4: fix compilation without CONFIG_COMPAT
Date: Mon, 27 Feb 2012 08:22:42 -0800 [thread overview]
Message-ID: <4F4BADD2.5020908@zytor.com> (raw)
In-Reply-To: <20120227090951.GA2681@osiris.boeblingen.de.ibm.com>
On 02/27/2012 01:09 AM, Heiko Carstens wrote:
> On Mon, Feb 27, 2012 at 08:29:25AM +0100, Christian Borntraeger wrote:
>> On 26/02/12 02:31, Linus Torvalds wrote:
>>>
>>> +#else
>>> +
>>> +#define is_compat_task() (0)
>>> +
>>
>> Linus,
>>
>> this breaks 32bit builds of s390 (and maybe others), since several platforms already
>> define a is_compat_task.
>
> It breaks only !COMPAT builds on s390, since only we have the is_compat_task()
> function defined for !COMPAT. The reason for that was simply to get rid of a
> couple of ugly #ifdefs.
> Note, that we still need to include asm/compat.h in some file since we need the
> compat_ptr typedef.
> That might be ugly, but I preferred including that header file so we could get
> rid of the #ifdefs.
> Anyway... the patch below fixes the build issues:
>
This patch would seem to be The Right Thing; the combination of this
really takes what s390 has done in arch space and globalizes it.
-hpa
next prev parent reply other threads:[~2012-02-27 16:23 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 2:24 compat: autofs v5 packet size ambiguity - update Linus Torvalds
2012-02-22 3:16 ` David Miller
2012-02-22 3:33 ` Linus Torvalds
2012-02-22 3:47 ` Linus Torvalds
2012-02-22 4:20 ` Ian Kent
2012-02-22 4:56 ` Linus Torvalds
2012-02-22 5:43 ` Ian Kent
2012-02-22 5:53 ` Ian Kent
2012-02-22 5:57 ` Ian Kent
2012-02-22 9:32 ` Ian Kent
2012-02-22 12:15 ` Ian Kent
2012-02-22 12:39 ` Ian Kent
2012-02-22 12:45 ` Ian Kent
2012-02-22 16:20 ` Linus Torvalds
2012-02-22 15:13 ` H. Peter Anvin
2012-02-23 1:35 ` Ian Kent
2012-02-22 16:12 ` Linus Torvalds
2012-02-23 1:48 ` Ian Kent
2012-02-23 1:54 ` Ian Kent
2012-02-23 2:21 ` Ian Kent
2012-02-23 6:29 ` Ian Kent
2012-02-23 6:31 ` H. Peter Anvin
2012-02-23 11:20 ` Ian Kent
2012-02-23 11:26 ` Ian Kent
2012-02-23 8:54 ` Thomas Meyer
2012-02-23 1:56 ` Linus Torvalds
2012-02-23 2:09 ` Ian Kent
2012-02-23 2:11 ` Ian Kent
2012-02-23 2:25 ` Linus Torvalds
2012-02-23 2:32 ` Ian Kent
2012-02-25 11:28 ` Thomas Meyer
2012-02-25 22:10 ` [PATCH] autofs4: fix compilation without CONFIG_COMPAT Andreas Schwab
2012-02-26 1:31 ` Linus Torvalds
2012-02-26 1:46 ` H. Peter Anvin
2012-02-26 1:53 ` Linus Torvalds
2012-02-26 3:07 ` H. Peter Anvin
2012-02-26 9:05 ` Andreas Schwab
2012-02-27 7:29 ` Christian Borntraeger
2012-02-27 9:09 ` Heiko Carstens
2012-02-27 16:22 ` H. Peter Anvin [this message]
2012-02-27 16:25 ` Linus Torvalds
2012-02-27 9:20 ` Ian Kent
2012-02-22 6:02 ` compat: autofs v5 packet size ambiguity - update H. Peter Anvin
2012-02-22 16:10 ` Linus Torvalds
2012-02-22 17:43 ` H. Peter Anvin
2012-02-22 17:45 ` H. Peter Anvin
2012-02-22 18:16 ` Linus Torvalds
2012-02-22 18:19 ` Linus Torvalds
2012-02-22 18:20 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4BADD2.5020908@zytor.com \
--to=hpa@zytor.com \
--cc=autofs@vger.kernel.org \
--cc=borntraeger@de.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=schwab@linux-m68k.org \
--cc=schwidefsky@de.ibm.com \
--cc=thomas@m3y3r.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome