mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Xiaochen Shen <shenxiaochen@open-hieco.net>,
	<tony.luck@intel.com>, <bp@alien8.de>, <fenghuay@nvidia.com>
Cc: <babu.moger@amd.com>, <james.morse@arm.com>,
	<Dave.Martin@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] x86/resctrl: Fix Platform QoS issues for Hygon
Date: Thu, 4 Dec 2025 15:30:06 -0800	[thread overview]
Message-ID: <4b003b8c-f021-4ae2-82c1-76b10fa2736a@intel.com> (raw)
In-Reply-To: <20251204023750.994143-1-shenxiaochen@open-hieco.net>

Hi Xiaochen!

On 12/3/25 6:37 PM, Xiaochen Shen wrote:
> This patch series fixes two issues regarding Platform QoS (resctrl)
> support on Hygon CPUs.
> 
> The first patch adds the missing initialization sequence required for
> proper resctrl functionality. The second patch corrects the bit-width
> configuration for the Memory Bandwidth Monitoring (MBM) counter.
> 
> Xiaochen Shen (2):
>   x86/resctrl: Add missing resctrl initialization for Hygon
>   x86/resctrl: Fix memory bandwidth counter width for Hygon
> 
>  arch/x86/kernel/cpu/resctrl/core.c     | 21 +++++++++++++++++----
>  arch/x86/kernel/cpu/resctrl/internal.h |  3 +++
>  2 files changed, 20 insertions(+), 4 deletions(-)
> 

This series looks good to me. Thank you.

One nit is that tip prefers the Cc: tag to be after the author's SoB. For details you can
refer to section "Ordering of commit tags" in Documentation/process/maintainer-tip.rst

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette

  parent reply	other threads:[~2025-12-04 23:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04  2:37 Xiaochen Shen
2025-12-04  2:37 ` [PATCH 1/2] x86/resctrl: Add missing resctrl initialization " Xiaochen Shen
2025-12-06  3:30   ` Fenghua Yu
2025-12-06 10:47     ` Xiaochen Shen
2025-12-04  2:37 ` [PATCH 2/2] x86/resctrl: Fix memory bandwidth counter width " Xiaochen Shen
2025-12-04 17:11   ` Luck, Tony
2025-12-05  2:38     ` Xiaochen Shen
2025-12-05 20:33       ` Luck, Tony
2025-12-06 16:14         ` Xiaochen Shen
2025-12-07  2:26           ` Xiaochen Shen
2025-12-08 16:52           ` Luck, Tony
2025-12-07  0:56         ` Xiaochen Shen
2025-12-05 21:57       ` Reinette Chatre
2025-12-06 16:19         ` Xiaochen Shen
2025-12-04 23:30 ` Reinette Chatre [this message]
2025-12-05  2:47   ` [PATCH 0/2] x86/resctrl: Fix Platform QoS issues " Xiaochen Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b003b8c-f021-4ae2-82c1-76b10fa2736a@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=fenghuay@nvidia.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shenxiaochen@open-hieco.net \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®