From: Xiaochen Shen <shenxiaochen@open-hieco.net>
To: Fenghua Yu <fenghuay@nvidia.com>,
tony.luck@intel.com, reinette.chatre@intel.com, bp@alien8.de
Cc: babu.moger@amd.com, james.morse@arm.com, Dave.Martin@arm.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
shenxiaochen@open-hieco.net
Subject: Re: [PATCH 1/2] x86/resctrl: Add missing resctrl initialization for Hygon
Date: Sat, 6 Dec 2025 18:47:40 +0800 [thread overview]
Message-ID: <e2303ded-39dc-4441-afab-39bcdecf8e02@open-hieco.net> (raw)
In-Reply-To: <d3e960af-8df0-4c62-894d-be040d67ea19@nvidia.com>
Hi Fenghua,
Thank you very much for code review!
On 12/6/2025 11:30 AM, Fenghua Yu wrote:
>> Add the missing AMD/Hygon common initialization to ensure proper
>> Platform QoS functionality on Hygon CPUs.
>>
>> Fixes: d8df126349da ("x86/cpu/hygon: Add missing resctrl_cpu_detect() in bsp_init helper")
>
> This commit triggers the issue on Hygon. You may keep this fix.
>
Sure. Thank you!
>> Fixes: 923f3a2b48bd ("x86/resctrl: Query LLC monitoring properties once during boot")
> This commit just calls resctrl_cpu_detect() on AMD and Intel. The commit itself doesn't have an issue. Remove this Fixes?
>
Yes, you are correct. I will remove this Fixes: tag as you suggested.
Thank you!
>> Cc: stable@vger.kernel.org
> Thanks.
>
> -Fenghua
Best regards,
Xiaochen Shen
next prev parent reply other threads:[~2025-12-06 10:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 2:37 [PATCH 0/2] x86/resctrl: Fix Platform QoS issues " Xiaochen Shen
2025-12-04 2:37 ` [PATCH 1/2] x86/resctrl: Add missing resctrl initialization " Xiaochen Shen
2025-12-06 3:30 ` Fenghua Yu
2025-12-06 10:47 ` Xiaochen Shen [this message]
2025-12-04 2:37 ` [PATCH 2/2] x86/resctrl: Fix memory bandwidth counter width " Xiaochen Shen
2025-12-04 17:11 ` Luck, Tony
2025-12-05 2:38 ` Xiaochen Shen
2025-12-05 20:33 ` Luck, Tony
2025-12-06 16:14 ` Xiaochen Shen
2025-12-07 2:26 ` Xiaochen Shen
2025-12-08 16:52 ` Luck, Tony
2025-12-07 0:56 ` Xiaochen Shen
2025-12-05 21:57 ` Reinette Chatre
2025-12-06 16:19 ` Xiaochen Shen
2025-12-04 23:30 ` [PATCH 0/2] x86/resctrl: Fix Platform QoS issues " Reinette Chatre
2025-12-05 2:47 ` Xiaochen Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2303ded-39dc-4441-afab-39bcdecf8e02@open-hieco.net \
--to=shenxiaochen@open-hieco.net \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghuay@nvidia.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®