From: Matti Vaittinen <matti.vaittinen@linux.dev>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <matti.vaittinen@linux.dev>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
"Radu Sabau" <radu.sabau@analog.com>,
"Janani Sunil" <janani.sunil@analog.com>,
"Salih Erim" <salih.erim@amd.com>,
"Jishnu Prakash" <jishnu.prakash@oss.qualcomm.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Jakub Szczudlo" <jakubszczudlo40@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111
Date: Fri, 20 Nov 2026 14:28:28 +0200 [thread overview]
Message-ID: <4be17e339f768da93db2f42abd3cc5a21fea01ad.1795176984.git.mazziesaccount@gmail.com> (raw)
In-Reply-To: <cover.1795176984.git.mazziesaccount@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 8443 bytes --]
From: Matti Vaittinen <mazziesaccount@gmail.com>
ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices,
where pins can be configured to be either used as GPIO or ADC inputs.
ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ
sources.
The main difference is amount of channels/GPIOs. The BD79112 has 32 pins
for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet
promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas
the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI
clock.
Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
Revision history:
v1 => v2:
- Various styling fixes as suggested by Jonathan and Andy
- Return -ENODATA instead of -ENODEV when SPI match data is not
available.
---
drivers/iio/adc/Kconfig | 10 +++--
drivers/iio/adc/rohm-bd79112.c | 69 +++++++++++++++++++++++++++-------
2 files changed, 62 insertions(+), 17 deletions(-)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index a802d8ee4dd9..78562e6c62f5 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1516,14 +1516,16 @@ config RN5T618_ADC
will be called rn5t618-adc.
config ROHM_BD79112
- tristate "Rohm BD79112 ADC driver"
+ tristate "ADC/GPIO Driver for ROHM BD79112 et al."
depends on SPI && GPIOLIB
select REGMAP_SPI
select IIO_ADC_HELPER
help
- Say yes here to build support for the ROHM BD79112 ADC. The
- ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. Analog inputs
- can also be used for GPIO.
+ Say yes here to build support for the following ROHM SAR ADCs:
+ - BD79111 (12-bit, 16 channels)
+ - BD79112 (12-bit, 32 channels)
+
+ Analog inputs can also be used for GPIO.
config ROHM_BD79124
tristate "Rohm BD79124 ADC driver"
diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c
index 04084e88984a..8bbb86098ff5 100644
--- a/drivers/iio/adc/rohm-bd79112.c
+++ b/drivers/iio/adc/rohm-bd79112.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * ROHM ADC driver for BD79112 signal monitoring hub.
+ * ROHM ADC/GPIO driver for BD79112 and similar signal monitoring hubs.
* Copyright (C) 2025, ROHM Semiconductor.
*
* SPI communication derived from ad7923.c and ti-ads7950.c
@@ -29,7 +29,9 @@
struct bd79112_data;
struct bd7911x_chip_data {
+ const char *name;
const char * const *chan_names;
+ unsigned int num_max_channels;
int (*init_disable_gpios)(struct bd79112_data *data);
};
@@ -377,7 +379,6 @@ static int bd79112_gpio_output(struct gpio_chip *gc, unsigned int offset,
}
static const struct gpio_chip bd79112_gpio_chip = {
- .label = "bd79112-gpio",
.get_direction = bd79112_gpio_dir_get,
.direction_input = bd79112_gpio_input,
.direction_output = bd79112_gpio_output,
@@ -386,26 +387,44 @@ static const struct gpio_chip bd79112_gpio_chip = {
.set_multiple = bd79112_gpio_set_multiple,
.init_valid_mask = bd79112_gpio_init_valid_mask,
.can_sleep = true,
- .ngpio = 32,
.base = -1,
};
-static unsigned int bd79112_get_gpio_pins(const struct iio_chan_spec *cs, int num_channels)
+static unsigned int bd79112_get_gpio_pins(const struct iio_chan_spec *cs,
+ int num_channels, int max_channels)
{
unsigned int i, gpio_channels;
/*
- * Let's initialize the mux config to say that all 32 channels are
+ * Let's initialize the mux config to say that all channels are
* GPIOs. Then we can just loop through the iio_chan_spec and clear the
* bits for found ADC channels.
*/
- gpio_channels = GENMASK(31, 0);
+ gpio_channels = GENMASK(max_channels - 1, 0);
for (i = 0; i < num_channels; i++)
gpio_channels &= ~BIT(cs[i].channel);
return gpio_channels;
}
+/* The BD79111 only has the registers for pins 0 - 15 */
+static int bd79111_disable_gpios(struct bd79112_data *data)
+{
+ static const unsigned int regs[] = {
+ BD79112_REG_GPI_EN_A8_A15, BD79112_REG_GPI_EN_A0_A7,
+ BD79112_REG_GPO_EN_A8_A15, BD79112_REG_GPO_EN_A0_A7,
+ };
+ int ret;
+
+ for (unsigned int i = 0; i < ARRAY_SIZE(regs); i++) {
+ ret = regmap_write(data->map, regs[i], 0);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
static int bd79112_disable_gpios(struct bd79112_data *data)
{
int ret;
@@ -419,7 +438,15 @@ static int bd79112_disable_gpios(struct bd79112_data *data)
return 0;
}
-/* ADC channels as named in the data-sheet */
+/* The BD79111 channel names as in the data-sheet */
+static const char * const bd79111_chan_names[] = {
+ "AGIO0", "AGIO1", "AGIO2", "AGIO3", /* 0 - 3 */
+ "AGIO4", "AGIO5", "AGIO6", "AGIO7", /* 4 - 7 */
+ "AGIO8", "AGIO9", "AGIO10", "AGIO11", /* 8 - 11 */
+ "AGIO12", "AGIO13", "AGIO14", "AGIO15", /* 12 - 15 */
+};
+
+/* The BD79112 channel name as in the data-sheet */
static const char * const bd79112_chan_names[] = {
"AGIO0A", "AGIO1A", "AGIO2A", "AGIO3A", /* 0 - 3 */
"AGIO4A", "AGIO5A", "AGIO6A", "AGIO7A", /* 4 - 7 */
@@ -431,8 +458,17 @@ static const char * const bd79112_chan_names[] = {
"AGIO12B", "AGIO13B", "AGIO14B", "AGIO15B", /* 28 - 31 */
};
+static const struct bd7911x_chip_data bd79111_chip_data = {
+ .name = "bd79111",
+ .chan_names = bd79111_chan_names,
+ .num_max_channels = 16,
+ .init_disable_gpios = bd79111_disable_gpios,
+};
+
static const struct bd7911x_chip_data bd79112_chip_data = {
+ .name = "bd79112",
.chan_names = bd79112_chan_names,
+ .num_max_channels = 32,
.init_disable_gpios = bd79112_disable_gpios,
};
@@ -453,7 +489,7 @@ static int bd79112_probe(struct spi_device *spi)
data = iio_priv(iio_dev);
data->cd = spi_get_device_match_data(spi);
if (!data->cd)
- return -ENODEV;
+ return -ENODATA;
data->spi = spi;
data->dev = dev;
@@ -492,7 +528,7 @@ static int bd79112_probe(struct spi_device *spi)
"Failed to optimize SPI write message\n");
ret = devm_iio_adc_device_alloc_chaninfo_se(dev, &bd79112_chan_template,
- BD79112_MAX_NUM_CHANNELS - 1,
+ data->cd->num_max_channels - 1,
&cs);
/* Register all pins as GPIOs if there are no ADC channels */
@@ -509,7 +545,7 @@ static int bd79112_probe(struct spi_device *spi)
cs[i].datasheet_name = data->cd->chan_names[cs[i].channel];
iio_dev->info = &bd79112_info;
- iio_dev->name = "bd79112";
+ iio_dev->name = data->cd->name;;
iio_dev->modes = INDIO_DIRECT_MODE;
/*
@@ -528,14 +564,15 @@ static int bd79112_probe(struct spi_device *spi)
register_gpios:
gpio_pins = bd79112_get_gpio_pins(iio_dev->channels,
- iio_dev->num_channels);
+ iio_dev->num_channels,
+ data->cd->num_max_channels);
/* If all channels are reserved for ADC, then we're done. */
if (!gpio_pins)
return 0;
/* Default all the GPIO pins to GPI */
- for_each_set_bit(pin, &gpio_pins, BD79112_MAX_NUM_CHANNELS) {
+ for_each_set_bit(pin, &gpio_pins, data->cd->num_max_channels) {
ret = bd79112_gpio_dir_set(data, pin, GPIO_LINE_DIRECTION_IN);
if (ret)
return dev_err_probe(dev, ret,
@@ -545,17 +582,23 @@ static int bd79112_probe(struct spi_device *spi)
data->gpio_valid_mask = gpio_pins;
data->gc = bd79112_gpio_chip;
data->gc.parent = dev;
+ data->gc.ngpio = data->cd->num_max_channels;
+ data->gc.label = devm_kasprintf(dev, GFP_KERNEL, "%s-gpio", data->cd->name);
+ if (!data->gc.label)
+ return -ENOMEM;
return devm_gpiochip_add_data(dev, &data->gc, data);
}
static const struct of_device_id bd79112_of_match[] = {
+ { .compatible = "rohm,bd79111", .data = &bd79111_chip_data },
{ .compatible = "rohm,bd79112", .data = &bd79112_chip_data },
{ }
};
MODULE_DEVICE_TABLE(of, bd79112_of_match);
static const struct spi_device_id bd79112_id[] = {
+ { .name = "bd79111", .driver_data = (kernel_ulong_t)&bd79111_chip_data },
{ .name = "bd79112", .driver_data = (kernel_ulong_t)&bd79112_chip_data },
{ }
};
@@ -572,6 +615,6 @@ static struct spi_driver bd79112_driver = {
module_spi_driver(bd79112_driver);
MODULE_AUTHOR("Matti Vaittinen <mazziesaccount@gmail.com>");
-MODULE_DESCRIPTION("Driver for ROHM BD79112 ADC/GPIO");
+MODULE_DESCRIPTION("ADC/GPIO Driver for ROHM BD79112 et al.");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS("IIO_DRIVER");
--
2.56.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-20 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 12:26 [PATCH v2 0/3] Support ROHM BD79111 ADC/GPIO Matti Vaittinen
2026-11-20 12:27 ` [PATCH v2 1/3] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen
2026-11-20 12:28 ` [PATCH v2 2/3] iio: adc: rohm-bd79112: Add chip info structure Matti Vaittinen
2026-11-20 14:36 ` Andy Shevchenko
2026-11-20 12:28 ` Matti Vaittinen [this message]
2026-11-20 14:44 ` [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4be17e339f768da93db2f42abd3cc5a21fea01ad.1795176984.git.mazziesaccount@gmail.com \
--to=matti.vaittinen@linux.dev \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jakubszczudlo40@gmail.com \
--cc=janani.sunil@analog.com \
--cc=jic23@kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=radu.sabau@analog.com \
--cc=robh@kernel.org \
--cc=salih.erim@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®