mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
	"Matti Vaittinen" <matti.vaittinen@linux.dev>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Joshua Crofts" <joshua.crofts1@gmail.com>,
	"Radu Sabau" <radu.sabau@analog.com>,
	"Janani Sunil" <janani.sunil@analog.com>,
	"Salih Erim" <salih.erim@amd.com>,
	"Jishnu Prakash" <jishnu.prakash@oss.qualcomm.com>,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Jakub Szczudlo" <jakubszczudlo40@gmail.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111
Date: Fri, 20 Nov 2026 16:44:38 +0200	[thread overview]
Message-ID: <awBc1qFMhydEXo69@ashevche-desk.local> (raw)
In-Reply-To: <4be17e339f768da93db2f42abd3cc5a21fea01ad.1795176984.git.mazziesaccount@gmail.com>

On Fri, Nov 20, 2026 at 02:28:28PM +0200, Matti Vaittinen wrote:
> 
> ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices,
> where pins can be configured to be either used as GPIO or ADC inputs.
> ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ
> sources.
> 
> The main difference is amount of channels/GPIOs. The BD79112 has 32 pins
> for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet
> promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock,  whereas
> the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI
> clock.

...

>  - Return -ENODATA instead of -ENODEV when SPI match data is not
>    available.

I guess you were distracted by something, the error code is now introduced in
the very previous patch, fix it there.

...

> -	tristate "Rohm BD79112 ADC driver"
> +	tristate "ADC/GPIO Driver for ROHM BD79112 et al."

> - * ROHM ADC driver for BD79112 signal monitoring hub.
> + * ROHM ADC/GPIO driver for BD79112 and similar signal monitoring hubs.

Can this text be modified to be closer to the other two?
Something like:

 * ADC/GPIO Driver for ROHM BD79112 and similar signal monitoring hubs.

> -MODULE_DESCRIPTION("Driver for ROHM BD79112 ADC/GPIO");
> +MODULE_DESCRIPTION("ADC/GPIO Driver for ROHM BD79112 et al.");

...

Otherwise LGTM,
Reviewed-by; Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-11-20 14:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 12:26 [PATCH v2 0/3] Support ROHM BD79111 ADC/GPIO Matti Vaittinen
2026-11-20 12:27 ` [PATCH v2 1/3] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen
2026-11-20 12:28 ` [PATCH v2 2/3] iio: adc: rohm-bd79112: Add chip info structure Matti Vaittinen
2026-11-20 14:36   ` Andy Shevchenko
2026-11-20 12:28 ` [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111 Matti Vaittinen
2026-11-20 14:44   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awBc1qFMhydEXo69@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jakubszczudlo40@gmail.com \
    --cc=janani.sunil@analog.com \
    --cc=jic23@kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=joshua.crofts1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=matti.vaittinen@linux.dev \
    --cc=mazziesaccount@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=radu.sabau@analog.com \
    --cc=robh@kernel.org \
    --cc=salih.erim@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®