From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: [PATCH 07/16] staging: rtl8723bs: Remove function pointer SetBeaconRelatedRegistersHandler
Date: Tue, 5 Nov 2024 06:54:54 +0100 [thread overview]
Message-ID: <4c5eb3b6e6ad0015c97d89df637253318c18b520.1730749680.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1730749680.git.philipp.g.hortmann@gmail.com>
Remove function pointer SetBeaconRelatedRegistersHandler and use
rtl8723b_SetBeaconRelatedRegisters directly to increase readability.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 3 +--
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 +---
drivers/staging/rtl8723bs/include/hal_intf.h | 3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index f3666b26ffe1..483f0c163bef 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -297,8 +297,7 @@ void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter)
void beacon_timing_control(struct adapter *padapter)
{
- if (padapter->HalFunc.SetBeaconRelatedRegistersHandler)
- padapter->HalFunc.SetBeaconRelatedRegistersHandler(padapter);
+ rtl8723b_SetBeaconRelatedRegisters(padapter);
}
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 844ef4a80ad0..64eb1786d8db 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1625,7 +1625,7 @@ static void _BeaconFunctionEnable(struct adapter *padapter, u8 Enable, u8 Linked
rtw_write8(padapter, REG_RD_CTRL+1, 0x6F);
}
-static void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter)
+void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter)
{
u8 val8;
u32 value32;
@@ -1744,8 +1744,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level)
void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
{
- pHalFunc->SetBeaconRelatedRegistersHandler = &rtl8723b_SetBeaconRelatedRegisters;
-
pHalFunc->Add_RateATid = &rtl8723b_Add_RateATid;
pHalFunc->run_thread = &rtl8723b_start_thread;
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 1e2bed9ebeef..2df25c1e7b5d 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -164,8 +164,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
struct hal_ops {
void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
- void (*SetBeaconRelatedRegistersHandler)(struct adapter *padapter);
-
void (*Add_RateATid)(struct adapter *padapter, u32 bitmap, u8 *arg, u8 rssi_level);
void (*run_thread)(struct adapter *padapter);
@@ -300,4 +298,5 @@ void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int l
u8 GetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level);
+void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter);
#endif /* __HAL_INTF_H__ */
--
2.43.0
next prev parent reply other threads:[~2024-11-05 5:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 5:54 [PATCH 00/16] staging: rtl8723bs: Replace function pointers starting with UpdateRAMaskHandler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 01/16] staging: rtl8723bs: Remove function pointer UpdateRAMaskHandler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 02/16] staging: rtl8723bs: Remove function pointer set_channel_handler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 03/16] staging: rtl8723bs: Remove function pointer set_chnl_bw_handler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 04/16] staging: rtl8723bs: Remove function pointer set_tx_power_level_handler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 05/16] staging: rtl8723bs: Remove function pointer hal_dm_watchdog Philipp Hortmann
2024-11-05 5:54 ` [PATCH 06/16] staging: rtl8723bs: Remove function pointer hal_dm_watchdog_in_lps Philipp Hortmann
2024-11-05 5:54 ` Philipp Hortmann [this message]
2024-11-05 5:54 ` [PATCH 08/16] staging: rtl8723bs: Remove function pointer Add_RateATid Philipp Hortmann
2024-11-05 5:54 ` [PATCH 09/16] staging: rtl8723bs: Remove function pointer run_thread Philipp Hortmann
2024-11-05 5:54 ` [PATCH 10/16] staging: rtl8723bs: Remove function pointer cancel_thread Philipp Hortmann
2024-11-05 5:54 ` [PATCH 11/16] staging: rtl8723bs: Remove function pointer read_bbreg Philipp Hortmann
2024-11-05 5:54 ` [PATCH 12/16] staging: rtl8723bs: Remove function pointer write_bbreg Philipp Hortmann
2024-11-05 5:55 ` [PATCH 13/16] staging: rtl8723bs: Remove function pointer read_rfreg Philipp Hortmann
2024-11-05 5:55 ` [PATCH 14/16] staging: rtl8723bs: Remove function pointer write_rfreg Philipp Hortmann
2024-11-05 5:55 ` [PATCH 15/16] staging: rtl8723bs: Remove function pointer EfusePowerSwitch Philipp Hortmann
2024-11-05 5:55 ` [PATCH 16/16] staging: rtl8723bs: Remove function pointer ReadEFuse Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c5eb3b6e6ad0015c97d89df637253318c18b520.1730749680.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®