From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: [PATCH 14/16] staging: rtl8723bs: Remove function pointer write_rfreg
Date: Tue, 5 Nov 2024 06:55:01 +0100 [thread overview]
Message-ID: <8034bd15f264cf3857f1e5b72e3b4c21682e2e9a.1730749680.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1730749680.git.philipp.g.hortmann@gmail.com>
Remove function pointer write_rfreg and use PHY_SetRFReg_8723B directly
to increase readability.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 3 +--
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 --
drivers/staging/rtl8723bs/include/hal_intf.h | 2 --
drivers/staging/rtl8723bs/include/rtw_mp.h | 1 -
4 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 11f9254a3bd2..0db8f623b805 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -256,8 +256,7 @@ u32 rtw_hal_read_rfreg(struct adapter *padapter, u32 eRFPath, u32 RegAddr, u32 B
}
void rtw_hal_write_rfreg(struct adapter *padapter, u32 eRFPath, u32 RegAddr, u32 BitMask, u32 Data)
{
- if (padapter->HalFunc.write_rfreg)
- padapter->HalFunc.write_rfreg(padapter, eRFPath, RegAddr, BitMask, Data);
+ PHY_SetRFReg_8723B(padapter, eRFPath, RegAddr, BitMask, Data);
}
void rtw_hal_set_chan(struct adapter *padapter, u8 channel)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 3f42b1fadc13..24d722bbc34a 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1744,8 +1744,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level)
void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
{
- pHalFunc->write_rfreg = &PHY_SetRFReg_8723B;
-
/* Efuse related function */
pHalFunc->EfusePowerSwitch = &Hal_EfusePowerSwitch;
pHalFunc->ReadEFuse = &Hal_ReadEFuse;
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 5c19f329e78b..ae873147a561 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -164,8 +164,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
struct hal_ops {
void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
- void (*write_rfreg)(struct adapter *padapter, u8 eRFPath, u32 RegAddr, u32 BitMask, u32 Data);
-
void (*EfusePowerSwitch)(struct adapter *padapter, u8 bWrite, u8 PwrState);
void (*ReadEFuse)(struct adapter *padapter, u8 efuseType, u16 _offset, u16 _size_byte, u8 *pbuf, bool bPseudoTest);
void (*EFUSEGetEfuseDefinition)(struct adapter *padapter, u8 efuseType, u8 type, void *pOut, bool bPseudoTest);
diff --git a/drivers/staging/rtl8723bs/include/rtw_mp.h b/drivers/staging/rtl8723bs/include/rtw_mp.h
index 30d2539e37f3..5a1cbd2ed851 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mp.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mp.h
@@ -276,7 +276,6 @@ void _write_rfreg(struct adapter *padapter, u8 rfpath, u32 addr, u32 bitmask, u3
u32 read_macreg(struct adapter *padapter, u32 addr, u32 sz);
void write_macreg(struct adapter *padapter, u32 addr, u32 val, u32 sz);
-void write_rfreg(struct adapter *padapter, u8 rfpath, u32 addr, u32 val);
void SetChannel(struct adapter *padapter);
void SetBandwidth(struct adapter *padapter);
--
2.43.0
next prev parent reply other threads:[~2024-11-05 5:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 5:54 [PATCH 00/16] staging: rtl8723bs: Replace function pointers starting with UpdateRAMaskHandler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 01/16] staging: rtl8723bs: Remove function pointer UpdateRAMaskHandler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 02/16] staging: rtl8723bs: Remove function pointer set_channel_handler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 03/16] staging: rtl8723bs: Remove function pointer set_chnl_bw_handler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 04/16] staging: rtl8723bs: Remove function pointer set_tx_power_level_handler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 05/16] staging: rtl8723bs: Remove function pointer hal_dm_watchdog Philipp Hortmann
2024-11-05 5:54 ` [PATCH 06/16] staging: rtl8723bs: Remove function pointer hal_dm_watchdog_in_lps Philipp Hortmann
2024-11-05 5:54 ` [PATCH 07/16] staging: rtl8723bs: Remove function pointer SetBeaconRelatedRegistersHandler Philipp Hortmann
2024-11-05 5:54 ` [PATCH 08/16] staging: rtl8723bs: Remove function pointer Add_RateATid Philipp Hortmann
2024-11-05 5:54 ` [PATCH 09/16] staging: rtl8723bs: Remove function pointer run_thread Philipp Hortmann
2024-11-05 5:54 ` [PATCH 10/16] staging: rtl8723bs: Remove function pointer cancel_thread Philipp Hortmann
2024-11-05 5:54 ` [PATCH 11/16] staging: rtl8723bs: Remove function pointer read_bbreg Philipp Hortmann
2024-11-05 5:54 ` [PATCH 12/16] staging: rtl8723bs: Remove function pointer write_bbreg Philipp Hortmann
2024-11-05 5:55 ` [PATCH 13/16] staging: rtl8723bs: Remove function pointer read_rfreg Philipp Hortmann
2024-11-05 5:55 ` Philipp Hortmann [this message]
2024-11-05 5:55 ` [PATCH 15/16] staging: rtl8723bs: Remove function pointer EfusePowerSwitch Philipp Hortmann
2024-11-05 5:55 ` [PATCH 16/16] staging: rtl8723bs: Remove function pointer ReadEFuse Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8034bd15f264cf3857f1e5b72e3b4c21682e2e9a.1730749680.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®