mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: [PATCH 10/16] staging: rtl8723bs: Remove function pointer cancel_thread
Date: Tue,  5 Nov 2024 06:54:57 +0100	[thread overview]
Message-ID: <e4fdff174a8ddc6cd62232e0aac8e23f4f34b1b9.1730749680.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1730749680.git.philipp.g.hortmann@gmail.com>

Remove function pointer cancel_thread and use rtl8723b_stop_thread
directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_intf.c          | 3 +--
 drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 --
 drivers/staging/rtl8723bs/include/hal_intf.h      | 2 --
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 28d15536abbb..22c41e4deae4 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -238,8 +238,7 @@ void rtw_hal_start_thread(struct adapter *padapter)
 /*Start specifical interface thread		*/
 void rtw_hal_stop_thread(struct adapter *padapter)
 {
-	if (padapter->HalFunc.cancel_thread)
-		padapter->HalFunc.cancel_thread(padapter);
+	rtl8723b_stop_thread(padapter);
 }
 
 u32 rtw_hal_read_bbreg(struct adapter *padapter, u32 RegAddr, u32 BitMask)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 8d8270d85f96..d23e4b1c36b6 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -1744,8 +1744,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level)
 
 void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
 {
-	pHalFunc->cancel_thread = &rtl8723b_stop_thread;
-
 	pHalFunc->read_bbreg = &PHY_QueryBBReg_8723B;
 	pHalFunc->write_bbreg = &PHY_SetBBReg_8723B;
 	pHalFunc->read_rfreg = &PHY_QueryRFReg_8723B;
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 3306c26ed2a4..02b31c142b9a 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -164,8 +164,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
 struct hal_ops {
 	void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet);
 
-	void (*cancel_thread)(struct adapter *padapter);
-
 	u32 (*read_bbreg)(struct adapter *padapter, u32 RegAddr, u32 BitMask);
 	void (*write_bbreg)(struct adapter *padapter, u32 RegAddr, u32 BitMask, u32 Data);
 	u32 (*read_rfreg)(struct adapter *padapter, u8 eRFPath, u32 RegAddr, u32 BitMask);
-- 
2.43.0


  parent reply	other threads:[~2024-11-05  5:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05  5:54 [PATCH 00/16] staging: rtl8723bs: Replace function pointers starting with UpdateRAMaskHandler Philipp Hortmann
2024-11-05  5:54 ` [PATCH 01/16] staging: rtl8723bs: Remove function pointer UpdateRAMaskHandler Philipp Hortmann
2024-11-05  5:54 ` [PATCH 02/16] staging: rtl8723bs: Remove function pointer set_channel_handler Philipp Hortmann
2024-11-05  5:54 ` [PATCH 03/16] staging: rtl8723bs: Remove function pointer set_chnl_bw_handler Philipp Hortmann
2024-11-05  5:54 ` [PATCH 04/16] staging: rtl8723bs: Remove function pointer set_tx_power_level_handler Philipp Hortmann
2024-11-05  5:54 ` [PATCH 05/16] staging: rtl8723bs: Remove function pointer hal_dm_watchdog Philipp Hortmann
2024-11-05  5:54 ` [PATCH 06/16] staging: rtl8723bs: Remove function pointer hal_dm_watchdog_in_lps Philipp Hortmann
2024-11-05  5:54 ` [PATCH 07/16] staging: rtl8723bs: Remove function pointer SetBeaconRelatedRegistersHandler Philipp Hortmann
2024-11-05  5:54 ` [PATCH 08/16] staging: rtl8723bs: Remove function pointer Add_RateATid Philipp Hortmann
2024-11-05  5:54 ` [PATCH 09/16] staging: rtl8723bs: Remove function pointer run_thread Philipp Hortmann
2024-11-05  5:54 ` Philipp Hortmann [this message]
2024-11-05  5:54 ` [PATCH 11/16] staging: rtl8723bs: Remove function pointer read_bbreg Philipp Hortmann
2024-11-05  5:54 ` [PATCH 12/16] staging: rtl8723bs: Remove function pointer write_bbreg Philipp Hortmann
2024-11-05  5:55 ` [PATCH 13/16] staging: rtl8723bs: Remove function pointer read_rfreg Philipp Hortmann
2024-11-05  5:55 ` [PATCH 14/16] staging: rtl8723bs: Remove function pointer write_rfreg Philipp Hortmann
2024-11-05  5:55 ` [PATCH 15/16] staging: rtl8723bs: Remove function pointer EfusePowerSwitch Philipp Hortmann
2024-11-05  5:55 ` [PATCH 16/16] staging: rtl8723bs: Remove function pointer ReadEFuse Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4fdff174a8ddc6cd62232e0aac8e23f4f34b1b9.1730749680.git.philipp.g.hortmann@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®