* [PATCH 7/7] fix lines over 80 characters
@ 2008-01-28 23:08 Paolo Ciarrocchi
2008-01-29 12:46 ` Stefan Richter
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Ciarrocchi @ 2008-01-28 23:08 UTC (permalink / raw)
To: Ingo Molnar, Linux Kernel
fix lines over 80 characters
Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
---
arch/x86/math-emu/errors.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
index 569a62e..e5a5b80 100644
--- a/arch/x86/math-emu/errors.c
+++ b/arch/x86/math-emu/errors.c
@@ -75,7 +75,8 @@ void FPU_printall(void)
FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
if (FPU_modrm >= 0300)
- printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8, FPU_modrm & 7);
+ printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
+ FPU_modrm & 7);
else
printk(KERN_ERR " /%d, mod=%d rm=%d\n",
(FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
@@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
if (n == EX_INTERNAL) {
- printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n", int_type);
+ printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
+ int_type);
FPU_printall();
}
#ifdef PRINT_MESSAGES
--
1.5.4.rc3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 7/7] fix lines over 80 characters
2008-01-28 23:08 [PATCH 7/7] fix lines over 80 characters Paolo Ciarrocchi
@ 2008-01-29 12:46 ` Stefan Richter
2008-01-31 22:54 ` Paolo Ciarrocchi
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Richter @ 2008-01-29 12:46 UTC (permalink / raw)
To: Paolo Ciarrocchi; +Cc: Ingo Molnar, Linux Kernel
Paolo Ciarrocchi wrote:
> --- a/arch/x86/math-emu/errors.c
> +++ b/arch/x86/math-emu/errors.c
> @@ -75,7 +75,8 @@ void FPU_printall(void)
> FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
>
> if (FPU_modrm >= 0300)
> - printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8, FPU_modrm & 7);
> + printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> + FPU_modrm & 7);
> else
> printk(KERN_ERR " /%d, mod=%d rm=%d\n",
> (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
> @@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
> printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
>
> if (n == EX_INTERNAL) {
> - printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n", int_type);
> + printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> + int_type);
> FPU_printall();
> }
> #ifdef PRINT_MESSAGES
The "fix" is still not conforming to CodingStyle.
Besides, why don't you leave these lines as they are? There is no
important information hidden behind the 80th column in the existing code.
--
Stefan Richter
-=====-==--- ---= ===-=
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 7/7] fix lines over 80 characters
2008-01-29 12:46 ` Stefan Richter
@ 2008-01-31 22:54 ` Paolo Ciarrocchi
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Ciarrocchi @ 2008-01-31 22:54 UTC (permalink / raw)
To: Stefan Richter; +Cc: Ingo Molnar, Linux Kernel
On 1/29/08, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Paolo Ciarrocchi wrote:
> > --- a/arch/x86/math-emu/errors.c
> > +++ b/arch/x86/math-emu/errors.c
> > @@ -75,7 +75,8 @@ void FPU_printall(void)
> > FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
> >
> > if (FPU_modrm >= 0300)
> > - printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> FPU_modrm & 7);
> > + printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> > + FPU_modrm & 7);
> > else
> > printk(KERN_ERR " /%d, mod=%d rm=%d\n",
> > (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
> > @@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
> > printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
> >
> > if (n == EX_INTERNAL) {
> > - printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> int_type);
> > + printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> > + int_type);
> > FPU_printall();
> > }
> > #ifdef PRINT_MESSAGES
>
>
> The "fix" is still not conforming to CodingStyle.
>
> Besides, why don't you leave these lines as they are? There is no
> important information hidden behind the 80th column in the existing code.
Yes, you are right.
Ingo, patch 7 deserves to be deleted.
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-31 22:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-28 23:08 [PATCH 7/7] fix lines over 80 characters Paolo Ciarrocchi
2008-01-29 12:46 ` Stefan Richter
2008-01-31 22:54 ` Paolo Ciarrocchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®