mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Alexander Koskovich <akoskovich@pm.me>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: clk-rpmh: Make all VRMs optional by default
Date: Mon, 13 Apr 2026 10:48:07 +0200	[thread overview]
Message-ID: <4dafae66-1ef1-404c-854c-b72d3313f5af@oss.qualcomm.com> (raw)
In-Reply-To: <20260412-clk-rpmh-vrm-opt-v1-2-37c890c420ff@pm.me>

On 4/12/26 5:30 PM, Alexander Koskovich wrote:
> Some VRMs aren't present on all boards, so mark them as optional. This
> prevents probe failures on boards where not all VRMs are present.
> 
> This mirrors the downstream approach for this issue.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---

[...]

> @@ -976,6 +982,11 @@ static int clk_rpmh_probe(struct platform_device *pdev)
>  		rpmh_clk = to_clk_rpmh(hw_clks[i]);
>  		res_addr = cmd_db_read_addr(rpmh_clk->res_name);
>  		if (!res_addr) {
> +			hw_clks[i] = NULL;
> +
> +			if (rpmh_clk->optional)
> +				continue;

if (rpmh_clk->offset == CLK_RPMH_VRM_EN_OFFSET)?

That would let you drop the rest of the patch.

This also needs some additional background.. I would assume this comes from
a slightly different HW (PMIC) configuration

Could you please do `grep ^ /sys/kernel/debug/qcom_socinfo/*`, (perhaps
censoring your serial number)?

Konrad

  reply	other threads:[~2026-04-13  8:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 15:30 [PATCH 0/2] " Alexander Koskovich
2026-04-12 15:30 ` [PATCH 1/2] Revert "clk: qcom: rpmh: make clkaN optional" Alexander Koskovich
2026-04-12 17:10   ` Dmitry Baryshkov
2026-04-12 17:22     ` Alexander Koskovich
2026-04-12 15:30 ` [PATCH 2/2] clk: qcom: clk-rpmh: Make all VRMs optional by default Alexander Koskovich
2026-04-13  8:48   ` Konrad Dybcio [this message]
2026-04-13  9:02     ` Alexander Koskovich
2026-04-14  8:27       ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dafae66-1ef1-404c-854c-b72d3313f5af@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®