From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Alexander Koskovich <akoskovich@pm.me>,
Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: clk-rpmh: Make all VRMs optional by default
Date: Tue, 14 Apr 2026 10:27:00 +0200 [thread overview]
Message-ID: <fac86ab0-6479-422e-a9ae-27d643767a94@oss.qualcomm.com> (raw)
In-Reply-To: <70GGl_MdOrdjIh3ZXqqz5y2NU0HwZ-HIZIzhglTAIpsyiFeyFKqDUUQe8f-krzLSzirMGLjlDsk2YK3-Qo5c7XGqv8qq6NK5F_UCPdt_hqE=@pm.me>
On 4/13/26 11:02 AM, Alexander Koskovich wrote:
> On Monday, April 13th, 2026 at 4:48 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>
>> On 4/12/26 5:30 PM, Alexander Koskovich wrote:
>>> Some VRMs aren't present on all boards, so mark them as optional. This
>>> prevents probe failures on boards where not all VRMs are present.
>>>
>>> This mirrors the downstream approach for this issue.
>>>
>>> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
>>> ---
>>
>> [...]
>>
>>> @@ -976,6 +982,11 @@ static int clk_rpmh_probe(struct platform_device *pdev)
>>> rpmh_clk = to_clk_rpmh(hw_clks[i]);
>>> res_addr = cmd_db_read_addr(rpmh_clk->res_name);
>>> if (!res_addr) {
>>> + hw_clks[i] = NULL;
>>> +
>>> + if (rpmh_clk->optional)
>>> + continue;
>>
>> if (rpmh_clk->offset == CLK_RPMH_VRM_EN_OFFSET)?
>>
>> That would let you drop the rest of the patch.
>>
>> This also needs some additional background.. I would assume this comes from
>> a slightly different HW (PMIC) configuration
>>
>> Could you please do `grep ^ /sys/kernel/debug/qcom_socinfo/*`, (perhaps
>> censoring your serial number)?
>
> /sys/kernel/debug/qcom_socinfo/accessory_chip:0
> /sys/kernel/debug/qcom_socinfo/boot_cluster:0
> /sys/kernel/debug/qcom_socinfo/boot_core:0
> /sys/kernel/debug/qcom_socinfo/build_id:
> /sys/kernel/debug/qcom_socinfo/chip_family:0x0000009f
> /sys/kernel/debug/qcom_socinfo/chip_id:SM7750
> /sys/kernel/debug/qcom_socinfo/feature_code:2
> /sys/kernel/debug/qcom_socinfo/foundry_id:1
> /sys/kernel/debug/qcom_socinfo/hardware_platform:11
> /sys/kernel/debug/qcom_socinfo/hardware_platform_subtype:0
> /sys/kernel/debug/qcom_socinfo/info_fmt:0x00000016
> /sys/kernel/debug/qcom_socinfo/ncluster_array_offset:228
> /sys/kernel/debug/qcom_socinfo/nmodem_supported:4294967295
> /sys/kernel/debug/qcom_socinfo/nproduct_id:1135
> /sys/kernel/debug/qcom_socinfo/nsubset_parts_array_offset:232
> /sys/kernel/debug/qcom_socinfo/num_clusters:1
> /sys/kernel/debug/qcom_socinfo/num_func_clusters:1
> /sys/kernel/debug/qcom_socinfo/num_subset_parts:20
> /sys/kernel/debug/qcom_socinfo/oem_variant:0
> /sys/kernel/debug/qcom_socinfo/pcode:1
> /sys/kernel/debug/qcom_socinfo/platform_version:65536
> /sys/kernel/debug/qcom_socinfo/pmic_die_rev:2.1
> /sys/kernel/debug/qcom_socinfo/pmic_model:PMK8550
> /sys/kernel/debug/qcom_socinfo/pmic_model_array:PMK8550 2.1
> /sys/kernel/debug/qcom_socinfo/pmic_model_array:PM7550 1.1
> /sys/kernel/debug/qcom_socinfo/pmic_model_array:PM8550VS 2.0
> /sys/kernel/debug/qcom_socinfo/pmic_model_array:PM8550VS 2.0
> /sys/kernel/debug/qcom_socinfo/pmic_model_array:unknown (90)
> /sys/kernel/debug/qcom_socinfo/pmic_model_array:PMR735D 2.0
So you have:
your phone vs Abel's Eliza-MTP
PMK8550 PMK8550
PM7550 PM7550
PM8550VS PM8550VS
PM8550VS PM8550VS
PMIV0102 (90) PM7550BA [!]
PMR735D PMR735D
PM8010 [!]
PM8010 [!]
And hence the difference, makes sense
Konrad
prev parent reply other threads:[~2026-04-14 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 15:30 [PATCH 0/2] " Alexander Koskovich
2026-04-12 15:30 ` [PATCH 1/2] Revert "clk: qcom: rpmh: make clkaN optional" Alexander Koskovich
2026-04-12 17:10 ` Dmitry Baryshkov
2026-04-12 17:22 ` Alexander Koskovich
2026-04-12 15:30 ` [PATCH 2/2] clk: qcom: clk-rpmh: Make all VRMs optional by default Alexander Koskovich
2026-04-13 8:48 ` Konrad Dybcio
2026-04-13 9:02 ` Alexander Koskovich
2026-04-14 8:27 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac86ab0-6479-422e-a9ae-27d643767a94@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=akoskovich@pm.me \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®