mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Corrado Zoccolo <czoccolo@gmail.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Valdis.Kletnieks@vt.edu, Mike Galbraith <efault@gmx.de>,
	Jens Axboe <jens.axboe@oracle.com>, Ingo Molnar <mingo@elte.hu>,
	Ulrich Lukas <stellplatz-nr.13a@datenparkplatz.de>,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, dm-devel@redhat.com,
	nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com,
	mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it,
	ryov@valinux.co.jp, fernando@oss.ntt.co.jp, jmoyer@redhat.com,
	dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com,
	righi.andrea@gmail.com, m-ikeda@ds.jp.nec.com, agk@redhat.com,
	akpm@linux-foundation.org, peterz@infradead.org,
	jmarchan@redhat.com, torvalds@linux-foundation.org,
	riel@redhat.com
Subject: Re: IO scheduler based IO controller V10
Date: Sat, 3 Oct 2009 14:43:14 +0200	[thread overview]
Message-ID: <4e5e476b0910030543o776fb505ka0ce38da9d83b33c@mail.gmail.com> (raw)
In-Reply-To: <20091002222756.GG4494@redhat.com>

On Sat, Oct 3, 2009 at 12:27 AM, Vivek Goyal <vgoyal@redhat.com> wrote:
> On Sat, Oct 03, 2009 at 12:14:28AM +0200, Corrado Zoccolo wrote:
>> In fact I think that the 'rotating' flag name is misleading.
>> All the checks we are doing are actually checking if the device truly
>> supports multiple parallel operations, and this feature is shared by
>> hardware raids and NCQ enabled SSDs, but not by cheap SSDs or single
>> NCQ-enabled SATA disk.
>>
>
> While we are at it, what happens to notion of priority of tasks on SSDs?
This is not changed by proposed patch w.r.t. current CFQ.
> Without idling there is not continuous time slice and there is no
> fairness. So ioprio is out of the window for SSDs?
I haven't NCQ enabled SSDs here, so I can't test it, but it seems to
me that the way in which queues are sorted in the rr tree may still
provide some sort of fairness and service differentiation for
priorities, in terms of number of IOs.
Non-NCQ SSDs, instead, will still have the idle window enabled, so it
is not an issue for them.
>
> On SSDs, will it make more sense to provide fairness in terms of number or
> IO or size of IO and not in terms of time slices.
Not on all SSDs. There are still ones that have a non-negligible
penalty on non-sequential access pattern (hopefully the ones without
NCQ, but if we find otherwise, then we will have to benchmark access
time in I/O scheduler to select the best policy). For those, time
based may still be needed.

Thanks,
Corrado

>
> Thanks
> Vivek

  reply	other threads:[~2009-10-03 12:43 UTC|newest]

Thread overview: 140+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 10:55 Corrado Zoccolo
2009-10-02 11:04 ` Jens Axboe
2009-10-02 12:49 ` Vivek Goyal
2009-10-02 15:27   ` Corrado Zoccolo
2009-10-02 15:31     ` Vivek Goyal
2009-10-02 15:32     ` Mike Galbraith
2009-10-02 15:40       ` Vivek Goyal
2009-10-02 16:03         ` Mike Galbraith
2009-10-02 16:50         ` Valdis.Kletnieks
2009-10-02 19:58           ` Vivek Goyal
2009-10-02 22:14             ` Corrado Zoccolo
2009-10-02 22:27               ` Vivek Goyal
2009-10-03 12:43                 ` Corrado Zoccolo [this message]
2009-10-03 13:38                   ` Do we support ioprio on SSDs with NCQ (Was: Re: IO scheduler based IO controller V10) Vivek Goyal
2009-10-04  9:15                     ` Corrado Zoccolo
2009-10-04 12:11                       ` Vivek Goyal
2009-10-04 12:46                         ` Corrado Zoccolo
2009-10-04 16:20                           ` Fabio Checconi
2009-10-05 21:21                             ` Corrado Zoccolo
2009-10-05 15:06                           ` Jeff Moyer
2009-10-05 21:09                             ` Corrado Zoccolo
2009-10-06  8:41                               ` Jens Axboe
2009-10-06  9:00                                 ` Corrado Zoccolo
2009-10-06 18:53                                   ` Jens Axboe
2009-10-06 21:36                           ` Vivek Goyal
  -- strict thread matches above, loose matches on Subject: below --
2009-09-24 19:25 IO scheduler based IO controller V10 Vivek Goyal
2009-09-24 21:33 ` Andrew Morton
2009-09-25  1:09   ` KAMEZAWA Hiroyuki
2009-09-25  1:18     ` KAMEZAWA Hiroyuki
2009-09-25  5:29       ` Balbir Singh
2009-09-25  7:09         ` Ryo Tsuruta
2009-09-25  4:14     ` Vivek Goyal
2009-09-25  5:04   ` Vivek Goyal
2009-09-25  9:07     ` Ryo Tsuruta
2009-09-25 14:33       ` Vivek Goyal
2009-09-28  7:30         ` Ryo Tsuruta
2009-09-25 15:04       ` Rik van Riel
2009-09-28  7:38         ` Ryo Tsuruta
2009-09-25  2:20 ` Ulrich Lukas
2009-09-25 20:26   ` Vivek Goyal
2009-09-26 14:51     ` Mike Galbraith
2009-09-27  6:55       ` Mike Galbraith
2009-09-27 16:42         ` Jens Axboe
2009-09-27 18:15           ` Mike Galbraith
2009-09-28  4:04             ` Mike Galbraith
2009-09-28  5:55               ` Mike Galbraith
2009-09-28 17:48               ` Vivek Goyal
2009-09-28 18:24                 ` Mike Galbraith
2009-09-30 19:58           ` Mike Galbraith
2009-09-30 20:05             ` Mike Galbraith
2009-09-30 20:24               ` Vivek Goyal
2009-10-01  7:33                 ` Mike Galbraith
2009-10-01 18:58                   ` Jens Axboe
2009-10-02  6:23                     ` Mike Galbraith
2009-10-02  8:04                       ` Jens Axboe
2009-10-02  8:53                         ` Mike Galbraith
2009-10-02  9:00                           ` Mike Galbraith
2009-10-02  9:55                           ` Jens Axboe
2009-10-02 12:22                             ` Mike Galbraith
2009-10-02  9:24                         ` Ingo Molnar
2009-10-02  9:28                           ` Jens Axboe
2009-10-02 14:24                             ` Linus Torvalds
2009-10-02 14:45                               ` Mike Galbraith
2009-10-02 14:57                                 ` Jens Axboe
2009-10-02 14:56                               ` Jens Axboe
2009-10-02 15:14                                 ` Linus Torvalds
2009-10-02 16:01                                   ` jim owens
2009-10-02 17:11                                   ` Jens Axboe
2009-10-02 17:20                                     ` Ingo Molnar
2009-10-02 17:25                                       ` Jens Axboe
2009-10-02 17:28                                         ` Ingo Molnar
2009-10-02 17:37                                           ` Jens Axboe
2009-10-02 17:56                                             ` Ingo Molnar
2009-10-02 18:04                                               ` Jens Axboe
2009-10-02 18:22                                                 ` Mike Galbraith
2009-10-02 18:26                                                   ` Jens Axboe
2009-10-02 18:33                                                     ` Mike Galbraith
2009-10-02 18:36                                                 ` Theodore Tso
2009-10-02 18:45                                                   ` Jens Axboe
2009-10-02 19:01                                                     ` Ingo Molnar
2009-10-02 19:09                                                       ` Jens Axboe
2009-10-02 18:13                                             ` Mike Galbraith
2009-10-02 18:19                                               ` Jens Axboe
2009-10-02 18:57                                                 ` Mike Galbraith
2009-10-02 20:47                                                   ` Mike Galbraith
2009-10-03  5:48                                                 ` Mike Galbraith
2009-10-03  5:56                                                   ` Mike Galbraith
2009-10-03  7:24                                                     ` Jens Axboe
2009-10-03  9:00                                                       ` Mike Galbraith
2009-10-03  9:12                                                         ` Corrado Zoccolo
2009-10-03 13:18                                                           ` Jens Axboe
2009-10-03 13:17                                                         ` Jens Axboe
2009-10-03 11:29                                                     ` Vivek Goyal
2009-10-03  7:20                                                   ` Ingo Molnar
2009-10-03  7:25                                                     ` Jens Axboe
2009-10-03  8:53                                                       ` Mike Galbraith
2009-10-03  9:01                                                       ` Corrado Zoccolo
2009-10-02 16:33                                 ` Ray Lee
2009-10-02 17:13                                   ` Jens Axboe
2009-10-02 16:22                               ` Ingo Molnar
2009-10-02  9:36                           ` Mike Galbraith
2009-10-02 16:37                             ` Ingo Molnar
2009-10-02 18:08                   ` Jens Axboe
2009-10-02 18:29                     ` Mike Galbraith
2009-10-02 18:36                       ` Jens Axboe
2009-09-27 17:00     ` Corrado Zoccolo
2009-09-28 14:56       ` Vivek Goyal
2009-09-28 15:35         ` Corrado Zoccolo
2009-09-28 17:14           ` Vivek Goyal
2009-09-29  7:10             ` Corrado Zoccolo
2009-09-28 17:51           ` Mike Galbraith
2009-09-28 18:18             ` Vivek Goyal
2009-09-28 18:53               ` Mike Galbraith
2009-09-29  7:14                 ` Corrado Zoccolo
2009-09-29  5:55             ` Mike Galbraith
2009-09-29  0:37 ` Nauman Rafique
2009-09-29  3:22   ` Vivek Goyal
2009-09-29  9:56     ` Ryo Tsuruta
2009-09-29 10:49       ` Takuya Yoshikawa
2009-09-29 14:10       ` Vivek Goyal
2009-09-29 19:53         ` Nauman Rafique
2009-09-30  8:43         ` Ryo Tsuruta
2009-09-30 11:05           ` Vivek Goyal
2009-10-01  6:41             ` Ryo Tsuruta
2009-10-01 13:31               ` Vivek Goyal
2009-10-02  2:57                 ` Vivek Goyal
2009-10-02 20:27                   ` Munehiro Ikeda
2009-10-05 10:38                     ` Ryo Tsuruta
2009-10-05 12:31                       ` Vivek Goyal
2009-10-05 14:55                         ` Ryo Tsuruta
2009-10-05 17:10                           ` Vivek Goyal
2009-10-05 18:11                             ` Nauman Rafique
2009-10-06  7:17                               ` Ryo Tsuruta
2009-10-06 11:22                                 ` Vivek Goyal
2009-10-07 14:38                                   ` Ryo Tsuruta
2009-10-07 15:09                                     ` Vivek Goyal
2009-10-08  2:18                                       ` Ryo Tsuruta
2009-10-07 16:41                                     ` Rik van Riel
2009-10-08 10:22                                       ` Ryo Tsuruta
2009-09-30  3:11       ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e5e476b0910030543o776fb505ka0ce38da9d83b33c@mail.gmail.com \
    --to=czoccolo@gmail.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=dm-devel@redhat.com \
    --cc=dpshah@google.com \
    --cc=efault@gmx.de \
    --cc=fchecconi@gmail.com \
    --cc=fernando@oss.ntt.co.jp \
    --cc=jens.axboe@oracle.com \
    --cc=jmarchan@redhat.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=m-ikeda@ds.jp.nec.com \
    --cc=mikew@google.com \
    --cc=mingo@elte.hu \
    --cc=nauman@google.com \
    --cc=paolo.valente@unimore.it \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=righi.andrea@gmail.com \
    --cc=ryov@valinux.co.jp \
    --cc=stellplatz-nr.13a@datenparkplatz.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®