* [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask
@ 2022-11-07 10:37 Konrad Dybcio
2022-11-16 11:37 ` Abhinav Kumar
2023-01-09 22:41 ` Dmitry Baryshkov
0 siblings, 2 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-11-07 10:37 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: patches, Konrad Dybcio, Dmitry Baryshkov, Konrad Dybcio,
Rob Clark, Abhinav Kumar, Sean Paul, David Airlie, Daniel Vetter,
Kalyan Thota, AngeloGioacchino Del Regno, Loic Poulain,
dri-devel, freedreno, linux-kernel
From: Konrad Dybcio <konrad.dybcio@somainline.org>
SDM845 only has INTF0-3 and has no business caring about the INTF4 irq.
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 27f029fdc682..06897a497eb7 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -86,7 +86,6 @@
BIT(MDP_INTF1_INTR) | \
BIT(MDP_INTF2_INTR) | \
BIT(MDP_INTF3_INTR) | \
- BIT(MDP_INTF4_INTR) | \
BIT(MDP_AD4_0_INTR) | \
BIT(MDP_AD4_1_INTR))
--
2.38.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask
2022-11-07 10:37 [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask Konrad Dybcio
@ 2022-11-16 11:37 ` Abhinav Kumar
2023-01-09 22:41 ` Dmitry Baryshkov
1 sibling, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2022-11-16 11:37 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross
Cc: patches, Konrad Dybcio, Dmitry Baryshkov, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Kalyan Thota,
AngeloGioacchino Del Regno, Loic Poulain, dri-devel, freedreno,
linux-kernel
On 11/7/2022 2:37 AM, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@somainline.org>
>
> SDM845 only has INTF0-3 and has no business caring about the INTF4 irq.
>
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
It is true that SDM845 doesnt have INTF4. I was a bit concerned whether
this would impact SM8150 as that re-uses the IRQ_SDM845_MASK but even
SM8150 doesnt have INTF4.
A minor nit, the subject convention in this file seems to be drm/msm/dpu
and not drm/msm/dpu1.
Other than that,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 27f029fdc682..06897a497eb7 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -86,7 +86,6 @@
> BIT(MDP_INTF1_INTR) | \
> BIT(MDP_INTF2_INTR) | \
> BIT(MDP_INTF3_INTR) | \
> - BIT(MDP_INTF4_INTR) | \
> BIT(MDP_AD4_0_INTR) | \
> BIT(MDP_AD4_1_INTR))
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask
2022-11-07 10:37 [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask Konrad Dybcio
2022-11-16 11:37 ` Abhinav Kumar
@ 2023-01-09 22:41 ` Dmitry Baryshkov
2023-01-09 23:43 ` Dmitry Baryshkov
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-01-09 22:41 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, Konrad Dybcio
Cc: patches, Konrad Dybcio, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Kalyan Thota,
AngeloGioacchino Del Regno, Loic Poulain, dri-devel, freedreno,
linux-kernel
On Mon, 07 Nov 2022 11:37:36 +0100, Konrad Dybcio wrote:
> SDM845 only has INTF0-3 and has no business caring about the INTF4 irq.
>
>
Applied, thanks!
[1/1] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask
https://gitlab.freedesktop.org/lumag/msm/-/commit/a685d27f2201
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask
2023-01-09 22:41 ` Dmitry Baryshkov
@ 2023-01-09 23:43 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-01-09 23:43 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, Konrad Dybcio
Cc: patches, Konrad Dybcio, Rob Clark, Abhinav Kumar, Sean Paul,
David Airlie, Daniel Vetter, Kalyan Thota,
AngeloGioacchino Del Regno, Loic Poulain, dri-devel, freedreno,
linux-kernel
On Mon, 07 Nov 2022 11:37:36 +0100, Konrad Dybcio wrote:
> SDM845 only has INTF0-3 and has no business caring about the INTF4 irq.
>
>
Applied, thanks!
[1/1] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask
https://gitlab.freedesktop.org/lumag/msm/-/commit/a685d27f2201
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-09 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 10:37 [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask Konrad Dybcio
2022-11-16 11:37 ` Abhinav Kumar
2023-01-09 22:41 ` Dmitry Baryshkov
2023-01-09 23:43 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®