* [PATCH 1/3] arm64: dts: qcom: lemans: fix iommus SID mask for ethernet nodes
2026-10-23 9:02 [PATCH 0/3] arm64: dts: qcom: sa8255p: add ethernet nodes Bartosz Golaszewski
@ 2026-10-23 9:02 ` Bartosz Golaszewski
2026-10-23 12:30 ` Konrad Dybcio
2026-10-23 9:02 ` [PATCH 2/3] arm64: dts: qcom: lemans: make the emac compatible specific to the embedded variant Bartosz Golaszewski
2026-10-23 9:02 ` [PATCH 3/3] arm64: dts: qcom: lemans-sa8255p: add ethernet nodes Bartosz Golaszewski
2 siblings, 1 reply; 8+ messages in thread
From: Bartosz Golaszewski @ 2026-10-23 9:02 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
Shawn Guo
Cc: linux-arm-msm, devicetree, linux-kernel, netdev, Bartosz Golaszewski
The iommus mask for ethernet nodes is wrong, it makes the SMMU mask 16
stream IDs per MAC. We should actually only use 8 SIDs. This has
triggered a crash on sa8255p after a boot firmware update. Use the
correct value of 0x7.
Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/lemans.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
index c71b1a48c3832bb40abbfb7d771634f4d197b0e8..da740a0876d4adcff0bb9458564c868a6f406b0d 100644
--- a/arch/arm64/boot/dts/qcom/lemans.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
@@ -4395,7 +4395,7 @@ ethernet1: ethernet@23000000 {
<GIC_SPI 781 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq", "sfty";
- iommus = <&apps_smmu 0x140 0xf>;
+ iommus = <&apps_smmu 0x140 0x7>;
dma-coherent;
snps,tso;
@@ -4416,7 +4416,7 @@ ethernet0: ethernet@23040000 {
<GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq", "sfty";
- iommus = <&apps_smmu 0x120 0xf>;
+ iommus = <&apps_smmu 0x120 0x7>;
dma-coherent;
snps,tso;
--
2.47.3
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 2/3] arm64: dts: qcom: lemans: make the emac compatible specific to the embedded variant
2026-10-23 9:02 [PATCH 0/3] arm64: dts: qcom: sa8255p: add ethernet nodes Bartosz Golaszewski
2026-10-23 9:02 ` [PATCH 1/3] arm64: dts: qcom: lemans: fix iommus SID mask for " Bartosz Golaszewski
@ 2026-10-23 9:02 ` Bartosz Golaszewski
2026-10-23 12:30 ` Konrad Dybcio
2026-10-23 9:02 ` [PATCH 3/3] arm64: dts: qcom: lemans-sa8255p: add ethernet nodes Bartosz Golaszewski
2 siblings, 1 reply; 8+ messages in thread
From: Bartosz Golaszewski @ 2026-10-23 9:02 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
Shawn Guo
Cc: linux-arm-msm, devicetree, linux-kernel, netdev, Bartosz Golaszewski
The embedded and gearvm variants of the ethernet MAC use different
compatibles so move the one for sa8775p into lemans-embedded.dtsi and
make place for the gearvm variant to be placed in lemans-gearvm.dtsi.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/lemans-embedded.dtsi | 2 ++
arch/arm64/boot/dts/qcom/lemans.dtsi | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/lemans-embedded.dtsi b/arch/arm64/boot/dts/qcom/lemans-embedded.dtsi
index 3733c0b7bace10cad656144b31d02bd8b4dbf3ed..630c40d21ecdab40ec59135cc667e4eccfd23554 100644
--- a/arch/arm64/boot/dts/qcom/lemans-embedded.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans-embedded.dtsi
@@ -458,6 +458,7 @@ &cpufreq_hw {
};
ðernet1 {
+ compatible = "qcom,sa8775p-ethqos";
clocks = <&gcc GCC_EMAC1_AXI_CLK>,
<&gcc GCC_EMAC1_SLV_AHB_CLK>,
<&gcc GCC_EMAC1_PTP_CLK>,
@@ -481,6 +482,7 @@ &config_noc SLAVE_EMAC1_CFG QCOM_ICC_TAG_ALWAYS>,
};
ðernet0 {
+ compatible = "qcom,sa8775p-ethqos";
clocks = <&gcc GCC_EMAC0_AXI_CLK>,
<&gcc GCC_EMAC0_SLV_AHB_CLK>,
<&gcc GCC_EMAC0_PTP_CLK>,
diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
index da740a0876d4adcff0bb9458564c868a6f406b0d..77e4f57778fd54e414c86a32f5b068239bee6d24 100644
--- a/arch/arm64/boot/dts/qcom/lemans.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
@@ -4386,7 +4386,6 @@ port@1 {
};
ethernet1: ethernet@23000000 {
- compatible = "qcom,sa8775p-ethqos";
reg = <0x0 0x23000000 0x0 0x10000>,
<0x0 0x23016000 0x0 0x100>;
reg-names = "stmmaceth", "rgmii";
@@ -4407,7 +4406,6 @@ ethernet1: ethernet@23000000 {
};
ethernet0: ethernet@23040000 {
- compatible = "qcom,sa8775p-ethqos";
reg = <0x0 0x23040000 0x0 0x10000>,
<0x0 0x23056000 0x0 0x100>;
reg-names = "stmmaceth", "rgmii";
--
2.47.3
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 3/3] arm64: dts: qcom: lemans-sa8255p: add ethernet nodes
2026-10-23 9:02 [PATCH 0/3] arm64: dts: qcom: sa8255p: add ethernet nodes Bartosz Golaszewski
2026-10-23 9:02 ` [PATCH 1/3] arm64: dts: qcom: lemans: fix iommus SID mask for " Bartosz Golaszewski
2026-10-23 9:02 ` [PATCH 2/3] arm64: dts: qcom: lemans: make the emac compatible specific to the embedded variant Bartosz Golaszewski
@ 2026-10-23 9:02 ` Bartosz Golaszewski
2026-10-23 12:20 ` Andrew Lunn
2026-10-23 12:32 ` Konrad Dybcio
2 siblings, 2 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2026-10-23 9:02 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
Shawn Guo
Cc: linux-arm-msm, devicetree, linux-kernel, netdev, Bartosz Golaszewski
Add the ethernet nodes along with their serdes PHY nodes for the gearvm
variant of the lemans ride board. Enable scmi7 and scmi8 to serve the
EMACs.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi | 28 +++
arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts | 213 +++++++++++++++++++++++
2 files changed, 241 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi b/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
index 4c155cbc79754af632848cd55b738e3ef0511cb5..c64cfd279af458e24fb48083ae549c96cfc07485 100644
--- a/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
@@ -58,6 +58,14 @@ &cpufreq_hw {
clock-names = "xo", "alternate";
};
+ðernet1 {
+ compatible = "qcom,sa8255p-ethqos";
+};
+
+ðernet0 {
+ compatible = "qcom,sa8255p-ethqos";
+};
+
&firmware {
scm {
memory-region = <&tz_ffi_mem>;
@@ -3226,6 +3234,26 @@ cma: linux,cma {
};
};
+&soc {
+ serdes0: phy@8901000 {
+ compatible = "qcom,sa8255p-dwmac-sgmii-phy";
+ reg = <0x0 0x08901000 0x0 0xe10>;
+ #phy-cells = <0>;
+ power-domains = <&scmi7_dvfs 0>;
+ power-domain-names = "serdes";
+ status = "disabled";
+ };
+
+ serdes1: phy@8902000 {
+ compatible = "qcom,sa8255p-dwmac-sgmii-phy";
+ reg = <0x0 0x08902000 0x0 0xe10>;
+ #phy-cells = <0>;
+ power-domains = <&scmi8_dvfs 0>;
+ power-domain-names = "serdes";
+ status = "disabled";
+ };
+};
+
&ufs_mem_hc {
compatible = "qcom,sa8255p-ufshc";
power-domains = <&scmi3_pd 0>;
diff --git a/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts b/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
index 4273f47c3dffc4244ba7fd7cf10b06054c8c8001..99d014ffd07701ffde255df01a67cf808cff213e 100644
--- a/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
@@ -14,6 +14,8 @@ / {
compatible = "qcom,sa8255p-ride", "qcom,sa8255p";
aliases {
+ ethernet0 = ðernet0;
+ ethernet1 = ðernet1;
serial0 = &uart10;
serial1 = &uart4;
};
@@ -101,6 +103,185 @@ trip1 {
};
};
+ðernet0 {
+ phy-handle = <&sgmii_phy0>;
+ phy-mode = "2500base-x";
+
+ pinctrl-0 = <ðernet0_default>;
+ pinctrl-names = "default";
+
+ snps,mtl-rx-config = <&mtl_rx_setup>;
+ snps,mtl-tx-config = <&mtl_tx_setup>;
+ snps,ps-speed = <2500>;
+
+ power-domains = <&scmi7_pd 0>, <&scmi7_pd 1>;
+ power-domain-names = "core", "mdio";
+
+ phys = <&serdes0>;
+ phy-names = "serdes";
+
+ status = "okay";
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ sgmii_phy0: phy@8 {
+ compatible = "ethernet-phy-id31c3.1c33";
+ reg = <0x8>;
+ device_type = "ethernet-phy";
+ resets = <&scmi7_rst 0>;
+ reset-names = "phy";
+ reset-assert-us = <11000>;
+ reset-deassert-us = <70000>;
+ };
+
+ sgmii_phy1: phy@0 {
+ compatible = "ethernet-phy-id31c3.1c33";
+ reg = <0x0>;
+ device_type = "ethernet-phy";
+ resets = <&scmi8_rst 0>;
+ reset-names = "phy";
+ reset-assert-us = <11000>;
+ reset-deassert-us = <70000>;
+ };
+ };
+
+ mtl_rx_setup: rx-queues-config {
+ snps,rx-queues-to-use = <4>;
+ snps,rx-sched-sp;
+
+ queue0 {
+ snps,dcb-algorithm;
+ snps,map-to-dma-channel = <0x0>;
+ snps,route-up;
+ snps,priority = <0x1>;
+ };
+
+ queue1 {
+ snps,dcb-algorithm;
+ snps,map-to-dma-channel = <0x1>;
+ snps,route-ptp;
+ };
+
+ queue2 {
+ snps,avb-algorithm;
+ snps,map-to-dma-channel = <0x2>;
+ snps,route-avcp;
+ };
+
+ queue3 {
+ snps,avb-algorithm;
+ snps,map-to-dma-channel = <0x3>;
+ snps,priority = <0xc>;
+ };
+ };
+
+ mtl_tx_setup: tx-queues-config {
+ snps,tx-queues-to-use = <4>;
+
+ queue0 {
+ snps,dcb-algorithm;
+ };
+
+ queue1 {
+ snps,dcb-algorithm;
+ };
+
+ queue2 {
+ snps,avb-algorithm;
+ snps,send_slope = <0x1000>;
+ snps,idle_slope = <0x1000>;
+ snps,high_credit = <0x3e800>;
+ snps,low_credit = <0xffc18000>;
+ };
+
+ queue3 {
+ snps,avb-algorithm;
+ snps,send_slope = <0x1000>;
+ snps,idle_slope = <0x1000>;
+ snps,high_credit = <0x3e800>;
+ snps,low_credit = <0xffc18000>;
+ };
+ };
+};
+
+ðernet1 {
+ phy-mode = "2500base-x";
+ phy-handle = <&sgmii_phy1>;
+
+ snps,mtl-rx-config = <&mtl_rx_setup1>;
+ snps,mtl-tx-config = <&mtl_tx_setup1>;
+ snps,ps-speed = <2500>;
+
+ power-domains = <&scmi8_pd 0>, <&scmi8_pd 1>;
+ power-domain-names = "core", "mdio";
+
+ phys = <&serdes1>;
+ phy-names = "serdes";
+
+ status = "okay";
+
+ mtl_rx_setup1: rx-queues-config {
+ snps,rx-queues-to-use = <4>;
+ snps,rx-sched-sp;
+
+ queue0 {
+ snps,dcb-algorithm;
+ snps,map-to-dma-channel = <0x0>;
+ snps,route-up;
+ snps,priority = <0x1>;
+ };
+
+ queue1 {
+ snps,dcb-algorithm;
+ snps,map-to-dma-channel = <0x1>;
+ snps,route-ptp;
+ };
+
+ queue2 {
+ snps,avb-algorithm;
+ snps,map-to-dma-channel = <0x2>;
+ snps,route-avcp;
+ };
+
+ queue3 {
+ snps,avb-algorithm;
+ snps,map-to-dma-channel = <0x3>;
+ snps,priority = <0xc>;
+ };
+ };
+
+ mtl_tx_setup1: tx-queues-config {
+ snps,tx-queues-to-use = <4>;
+
+ queue0 {
+ snps,dcb-algorithm;
+ };
+
+ queue1 {
+ snps,dcb-algorithm;
+ };
+
+ queue2 {
+ snps,avb-algorithm;
+ snps,send_slope = <0x1000>;
+ snps,idle_slope = <0x1000>;
+ snps,high_credit = <0x3e800>;
+ snps,low_credit = <0xffc18000>;
+ };
+
+ queue3 {
+ snps,avb-algorithm;
+ snps,send_slope = <0x1000>;
+ snps,idle_slope = <0x1000>;
+ snps,high_credit = <0x3e800>;
+ snps,low_credit = <0xffc18000>;
+ };
+ };
+};
+
&gpll0_board_clk {
clock-frequency = <300000000>;
};
@@ -145,6 +326,14 @@ &scmi6 {
status = "okay";
};
+&scmi7 {
+ status = "okay";
+};
+
+&scmi8 {
+ status = "okay";
+};
+
&scmi11 {
status = "okay";
};
@@ -170,6 +359,22 @@ &uart10 {
};
&tlmm {
+ ethernet0_default: ethernet0-default-state {
+ ethernet0_mdc: ethernet0-mdc-pins {
+ pins = "gpio8";
+ function = "emac0_mdc";
+ drive-strength = <16>;
+ bias-pull-up;
+ };
+
+ ethernet0_mdio: ethernet0-mdio-pins {
+ pins = "gpio9";
+ function = "emac0_mdio";
+ drive-strength = <16>;
+ bias-pull-up;
+ };
+ };
+
pcie0_ep_clkreq_default: pcie0-ep-clkreq-default-state {
pins = "gpio1";
function = "pcie0_clkreq";
@@ -213,6 +418,14 @@ pcie1_ep_wake_default: pcie1-ep-wake-default-state {
};
};
+&serdes0 {
+ status = "okay";
+};
+
+&serdes1 {
+ status = "okay";
+};
+
&ufs_mem_hc {
status = "okay";
};
--
2.47.3
^ permalink raw reply [flat|nested] 8+ messages in thread