mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Huang, Kai" <kai.huang@intel.com>
To: "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>
Cc: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"sagis@google.com" <sagis@google.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>,
	"ashish.kalra@amd.com" <ashish.kalra@amd.com>,
	"nik.borisov@suse.com" <nik.borisov@suse.com>
Subject: Re: [PATCH v2 0/5] TDX host: kexec/kdump support
Date: Thu, 29 May 2025 11:06:58 +0000	[thread overview]
Message-ID: <51372e65ed19baa251ab8a11266509fdf7f868b8.camel@intel.com> (raw)
In-Reply-To: <9a88386d-6610-9ff3-2a71-42961e7168f3@amd.com>

On Wed, 2025-05-14 at 07:37 -0500, Tom Lendacky wrote:
> On 5/10/25 06:20, Kai Huang wrote:
> > Hi Dave,
> > 
> > This series is the latest attempt to support kexec on TDX host following
> > your suggestion to use a percpu boolean to control WBINVD during kexec.
> > I appreciate if you can help to review.
> > 
> > The last attempt was to have one patch to make TDX and kexec mutually
> > exclusive at runtime while allowing them to be both enabled in Kconfig,
> > but it turns out to be overkill.  Dave proposed another option of using
> > a percpu boolean to track the need for flushing:
> > 
> > https://lore.kernel.org/lkml/20250416230259.97989-1-kai.huang@intel.com/
> > 
> > One advantage of the percpu boolean is for TDX we could do optimization
> > to do:
> > 
> > 	wbinvd();
> > 	percpu(boolean) = 0;
> > 
> > for all CPUs at early stage to avoid having to do WBINVD in
> > stop_this_cpu() at kexec time.  I made a RFC patch to show the idea:
> > 
> > https://github.com/intel/tdx/commit/d9f0123b1d63ba24f472da6971181939ce53d2e3
> > 
> > I'll also reply this RFC patch to this coverletter in case anyone wants
> > to have a discussion.  Nevertheless, my exception is this series can be
> > merged first w/o the RFC patch.  We can follow up the optimizations
> > later.
> > 
> > This series is tagged v2, since it's a closer follow on to the RFC
> > patchset, which was posted before the single patch:
> > 
> > https://lore.kernel.org/all/cover.1741778537.git.kai.huang@intel.com/
> > 
> > This series is based on today's tip/master.
> 
> I'm on PTO for the next few days, so I'll try to review/test the SME
> related changes when I return.
> 

Hi Tom,

I hope you had a good time off? :-)

I appreciate if you can help to review/test.  This series can still be applied
cleanly on today's tip/master. :-)

      parent reply	other threads:[~2025-05-29 11:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-10 11:20 Kai Huang
2025-05-10 11:20 ` [PATCH v2 1/5] x86/sme: Use percpu boolean to control wbinvd during kexec Kai Huang
2025-05-10 11:20 ` [PATCH v2 2/5] x86/virt/tdx: Mark memory cache state incoherent when making SEAMCALL Kai Huang
2025-05-14 10:10   ` [PATCH v2.1 " Kai Huang
2025-05-14 15:52     ` Dave Hansen
2025-05-14 22:13       ` Huang, Kai
2025-05-10 11:20 ` [PATCH v2 3/5] x86/kexec: Disable kexec/kdump on platforms with TDX partial write erratum Kai Huang
2025-05-10 11:20 ` [PATCH v2 4/5] x86/virt/tdx: Remove the !KEXEC_CORE dependency Kai Huang
2025-05-10 11:20 ` [PATCH v2 5/5] x86/virt/tdx: Update the kexec section in the TDX documentation Kai Huang
2025-05-10 11:25 ` [RFC PATCH v2 6/5] KVM: TDX: Explicitly do WBINVD upon reboot notifier Kai Huang
2025-06-13 11:36   ` Paolo Bonzini
2025-06-16 10:39     ` Huang, Kai
2025-05-14 12:37 ` [PATCH v2 0/5] TDX host: kexec/kdump support Tom Lendacky
2025-05-14 22:09   ` Huang, Kai
2025-05-29 11:06   ` Huang, Kai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51372e65ed19baa251ab8a11266509fdf7f868b8.camel@intel.com \
    --to=kai.huang@intel.com \
    --cc=ashish.kalra@amd.com \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=hpa@zytor.com \
    --cc=isaku.yamahata@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nik.borisov@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=reinette.chatre@intel.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sagis@google.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®