From: Tom Lendacky <thomas.lendacky@amd.com>
To: Kai Huang <kai.huang@intel.com>,
dave.hansen@intel.com, bp@alien8.de, tglx@linutronix.de,
peterz@infradead.org, mingo@redhat.com
Cc: kirill.shutemov@linux.intel.com, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org, pbonzini@redhat.com,
seanjc@google.com, rick.p.edgecombe@intel.com,
isaku.yamahata@intel.com, reinette.chatre@intel.com,
dan.j.williams@intel.com, ashish.kalra@amd.com,
nik.borisov@suse.com, sagis@google.com
Subject: Re: [PATCH v2 0/5] TDX host: kexec/kdump support
Date: Wed, 14 May 2025 07:37:45 -0500 [thread overview]
Message-ID: <9a88386d-6610-9ff3-2a71-42961e7168f3@amd.com> (raw)
In-Reply-To: <cover.1746874095.git.kai.huang@intel.com>
On 5/10/25 06:20, Kai Huang wrote:
> Hi Dave,
>
> This series is the latest attempt to support kexec on TDX host following
> your suggestion to use a percpu boolean to control WBINVD during kexec.
> I appreciate if you can help to review.
>
> The last attempt was to have one patch to make TDX and kexec mutually
> exclusive at runtime while allowing them to be both enabled in Kconfig,
> but it turns out to be overkill. Dave proposed another option of using
> a percpu boolean to track the need for flushing:
>
> https://lore.kernel.org/lkml/20250416230259.97989-1-kai.huang@intel.com/
>
> One advantage of the percpu boolean is for TDX we could do optimization
> to do:
>
> wbinvd();
> percpu(boolean) = 0;
>
> for all CPUs at early stage to avoid having to do WBINVD in
> stop_this_cpu() at kexec time. I made a RFC patch to show the idea:
>
> https://github.com/intel/tdx/commit/d9f0123b1d63ba24f472da6971181939ce53d2e3
>
> I'll also reply this RFC patch to this coverletter in case anyone wants
> to have a discussion. Nevertheless, my exception is this series can be
> merged first w/o the RFC patch. We can follow up the optimizations
> later.
>
> This series is tagged v2, since it's a closer follow on to the RFC
> patchset, which was posted before the single patch:
>
> https://lore.kernel.org/all/cover.1741778537.git.kai.huang@intel.com/
>
> This series is based on today's tip/master.
I'm on PTO for the next few days, so I'll try to review/test the SME
related changes when I return.
Thanks,
Tom
>
next prev parent reply other threads:[~2025-05-14 12:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 11:20 Kai Huang
2025-05-10 11:20 ` [PATCH v2 1/5] x86/sme: Use percpu boolean to control wbinvd during kexec Kai Huang
2025-05-10 11:20 ` [PATCH v2 2/5] x86/virt/tdx: Mark memory cache state incoherent when making SEAMCALL Kai Huang
2025-05-14 10:10 ` [PATCH v2.1 " Kai Huang
2025-05-14 15:52 ` Dave Hansen
2025-05-14 22:13 ` Huang, Kai
2025-05-10 11:20 ` [PATCH v2 3/5] x86/kexec: Disable kexec/kdump on platforms with TDX partial write erratum Kai Huang
2025-05-10 11:20 ` [PATCH v2 4/5] x86/virt/tdx: Remove the !KEXEC_CORE dependency Kai Huang
2025-05-10 11:20 ` [PATCH v2 5/5] x86/virt/tdx: Update the kexec section in the TDX documentation Kai Huang
2025-05-10 11:25 ` [RFC PATCH v2 6/5] KVM: TDX: Explicitly do WBINVD upon reboot notifier Kai Huang
2025-06-13 11:36 ` Paolo Bonzini
2025-06-16 10:39 ` Huang, Kai
2025-05-14 12:37 ` Tom Lendacky [this message]
2025-05-14 22:09 ` [PATCH v2 0/5] TDX host: kexec/kdump support Huang, Kai
2025-05-29 11:06 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a88386d-6610-9ff3-2a71-42961e7168f3@amd.com \
--to=thomas.lendacky@amd.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®