From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Amit Daniel Kachhap <amit.daniel@samsung.com>
Cc: <linux-pm@vger.kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <eduardo.valentin@ti.com>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <amit.kachhap@gmail.com>,
Kukjin Kim <kgene.kim@samsung.com>, <jonghwa3.lee@samsung.com>
Subject: Re: [PATCH V6 14/30] thermal: exynos: Modify private_data to appropriate name driver_data
Date: Wed, 19 Jun 2013 18:44:23 -0400 [thread overview]
Message-ID: <51C23447.4020909@ti.com> (raw)
In-Reply-To: <1371451599-31035-15-git-send-email-amit.daniel@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 3121 bytes --]
On 17-06-2013 02:46, Amit Daniel Kachhap wrote:
> This patch renames member private_data to driver_data of the thermal
> zone registration structure as this item stores the driver related
> data and uses it to call the driver related callbacks.
>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> Acked-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/thermal/samsung/exynos_thermal_common.c | 4 ++--
> drivers/thermal/samsung/exynos_thermal_common.h | 2 +-
> drivers/thermal/samsung/exynos_tmu.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c
> index 2af1e3b..7064eb7 100644
> --- a/drivers/thermal/samsung/exynos_thermal_common.c
> +++ b/drivers/thermal/samsung/exynos_thermal_common.c
> @@ -221,7 +221,7 @@ static int exynos_get_temp(struct thermal_zone_device *thermal,
> pr_info("Temperature sensor not initialised\n");
> return -EINVAL;
> }
> - data = th_zone->sensor_conf->private_data;
> + data = th_zone->sensor_conf->driver_data;
> *temp = th_zone->sensor_conf->read_temperature(data);
> /* convert the temperature into millicelsius */
> *temp = *temp * MCELSIUS;
> @@ -240,7 +240,7 @@ static int exynos_set_emul_temp(struct thermal_zone_device *thermal,
> pr_info("Temperature sensor not initialised\n");
> return -EINVAL;
> }
> - data = th_zone->sensor_conf->private_data;
> + data = th_zone->sensor_conf->driver_data;
> if (th_zone->sensor_conf->write_emul_temp)
> ret = th_zone->sensor_conf->write_emul_temp(data, temp);
> return ret;
> diff --git a/drivers/thermal/samsung/exynos_thermal_common.h b/drivers/thermal/samsung/exynos_thermal_common.h
> index a845c2d..1e9a326 100644
> --- a/drivers/thermal/samsung/exynos_thermal_common.h
> +++ b/drivers/thermal/samsung/exynos_thermal_common.h
> @@ -83,7 +83,7 @@ struct thermal_sensor_conf {
> int (*write_emul_temp)(void *drv_data, unsigned long temp);
> struct thermal_trip_point_conf trip_data;
> struct thermal_cooling_conf cooling_data;
> - void *private_data;
> + void *driver_data;
> void *pzone_data;
> };
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index a7bba69..40e0cfd 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -504,7 +504,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
> exynos_tmu_control(pdev, true);
>
> /* Register the sensor with thermal management interface */
> - (&exynos_sensor_conf)->private_data = data;
> + (&exynos_sensor_conf)->driver_data = data;
> exynos_sensor_conf.trip_data.trip_count = pdata->trigger_enable[0] +
> pdata->trigger_enable[1] + pdata->trigger_enable[2]+
> pdata->trigger_enable[3];
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
next prev parent reply other threads:[~2013-06-19 22:44 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 6:46 [PATCH V6 00/30] thermal: exynos: Re-structure driver and add support for exynos5440 Amit Daniel Kachhap
2013-06-17 6:46 ` [PATCH V6 01/30] thermal: exynos: Moving exynos thermal files into samsung directory Amit Daniel Kachhap
2013-06-19 18:46 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 02/30] thermal: exynos: Use ARCH_HAS_BANDGAP config to know the supported soc's Amit Daniel Kachhap
2013-06-19 18:46 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 03/30] thermal: exynos: Remove un-necessary CPU_THERMAL dependency Amit Daniel Kachhap
2013-06-19 18:48 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 04/30] thermal: exynos: Bifurcate exynos thermal common and tmu controller code Amit Daniel Kachhap
2013-06-19 18:45 ` Eduardo Valentin
2013-06-21 1:50 ` amit daniel kachhap
2013-06-21 14:30 ` Eduardo Valentin
2013-06-19 19:01 ` Eduardo Valentin
2013-06-21 2:48 ` amit daniel kachhap
2013-06-21 14:23 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 05/30] thermal: exynos: Rename exynos_thermal.c to exynos_tmu.c Amit Daniel Kachhap
2013-06-17 6:46 ` [PATCH V6 06/30] thermal: exynos: Move exynos_thermal.h from include/* to driver/* folder Amit Daniel Kachhap
2013-06-19 19:18 ` Eduardo Valentin
2013-06-19 19:20 ` Eduardo Valentin
2013-06-21 4:34 ` amit daniel kachhap
2013-06-21 4:33 ` amit daniel kachhap
2013-06-17 6:46 ` [PATCH V6 07/30] thermal: exynos: Bifurcate exynos tmu driver and configuration data Amit Daniel Kachhap
2013-06-19 19:35 ` Eduardo Valentin
2013-06-19 19:43 ` Eduardo Valentin
2013-06-21 5:06 ` amit daniel kachhap
2013-06-17 6:46 ` [PATCH V6 08/30] thermal: exynos: Add missing definations and code cleanup Amit Daniel Kachhap
2013-06-19 19:55 ` Eduardo Valentin
2013-06-21 2:01 ` amit daniel kachhap
2013-06-21 14:31 ` Eduardo Valentin
2013-06-24 3:57 ` amit daniel kachhap
2013-06-17 6:46 ` [PATCH V6 09/30] thermal: exynos: Add extra entries in the tmu platform data Amit Daniel Kachhap
2013-06-19 20:19 ` Eduardo Valentin
2013-06-19 20:52 ` Eduardo Valentin
2013-06-21 8:50 ` amit daniel kachhap
2013-06-21 14:26 ` Eduardo Valentin
2013-06-21 6:39 ` amit daniel kachhap
2013-06-17 6:46 ` [PATCH V6 10/30] thermal: exynos: Move register definitions from driver to data file Amit Daniel Kachhap
2013-06-19 21:02 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 11/30] thermal: exynos: Support thermal tripping Amit Daniel Kachhap
2013-06-19 22:23 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 12/30] thermal: exynos: Fix to clear only the generated interrupts Amit Daniel Kachhap
2013-06-19 22:26 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 13/30] thermal: exynos: Add support for instance based register/unregister Amit Daniel Kachhap
2013-06-19 22:40 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 14/30] thermal: exynos: Modify private_data to appropriate name driver_data Amit Daniel Kachhap
2013-06-19 22:44 ` Eduardo Valentin [this message]
2013-06-17 6:46 ` [PATCH V6 15/30] thermal: exynos: Return success even if no cooling data supplied Amit Daniel Kachhap
2013-06-19 22:54 ` Eduardo Valentin
2013-06-19 23:04 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 16/30] thermal: exynos: Make the zone handling use trip information Amit Daniel Kachhap
2013-06-19 23:03 ` Eduardo Valentin
2013-06-21 12:30 ` amit daniel kachhap
2013-06-21 14:35 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 17/30] thermal: exynos: Remove non DT based support Amit Daniel Kachhap
2013-06-19 23:09 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 18/30] thermal: exynos: Add support to handle many instances of TMU Amit Daniel Kachhap
2013-06-19 23:27 ` Eduardo Valentin
2013-06-21 12:46 ` amit daniel kachhap
2013-06-21 14:28 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 19/30] thermal: exynos: Add TMU features to check instead of using SOC type Amit Daniel Kachhap
2013-06-19 23:35 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 20/30] thermal: exynos: use device resource management infrastructure Amit Daniel Kachhap
2013-06-19 23:42 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 21/30] ARM: dts: thermal: exynos4: Add documentation for Exynos SoC thermal bindings Amit Daniel Kachhap
2013-06-19 23:45 ` Eduardo Valentin
2013-06-21 14:34 ` amit daniel kachhap
2013-06-17 6:46 ` [PATCH V6 22/30] thermal: exynos: Add support to access common register for multistance Amit Daniel Kachhap
2013-06-19 23:53 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 23/30] thermal: exynos: Add driver support for exynos5440 TMU sensor Amit Daniel Kachhap
2013-06-20 2:06 ` Eduardo Valentin
2013-06-21 15:17 ` amit daniel kachhap
2013-06-17 6:46 ` [PATCH V6 24/30] thermal: exynos: Add thermal configuration data " Amit Daniel Kachhap
2013-06-20 2:18 ` Eduardo Valentin
2013-06-21 15:19 ` amit daniel kachhap
2013-06-21 15:21 ` amit daniel kachhap
2013-06-17 6:46 ` [PATCH V6 25/30] thermal: exynos: Fix to set the second point correction value Amit Daniel Kachhap
2013-06-20 2:22 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 26/30] thermal: exynos: Add hardware mode thermal calibration support Amit Daniel Kachhap
2013-06-20 2:30 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 27/30] Documentation: thermal: Explain the exynos thermal driver model Amit Daniel Kachhap
2013-06-20 2:32 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 28/30] thermal: exynos: Support for TMU regulator defined at device tree Amit Daniel Kachhap
2013-06-20 2:33 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 29/30] ARM: dts: Add device tree node for exynos5440 TMU controller Amit Daniel Kachhap
2013-06-20 2:37 ` Eduardo Valentin
2013-06-17 6:46 ` [PATCH V6 30/30] arm: exynos: enable ARCH_HAS_BANDGAP Amit Daniel Kachhap
2013-06-19 18:47 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C23447.4020909@ti.com \
--to=eduardo.valentin@ti.com \
--cc=amit.daniel@samsung.com \
--cc=amit.kachhap@gmail.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome