* [PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check
@ 2015-03-04 21:48 Maciej S. Szmigiero
2015-03-05 1:01 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Maciej S. Szmigiero @ 2015-03-04 21:48 UTC (permalink / raw)
To: alsa-devel, linux-kernel
Cc: Timur Tabi, Nicolin Chen, Xiubo Li, Liam Girdwood, Mark Brown
of_property_read_u32_array returns 0 on success,
so the return value shouldn't be inverted twice,
first on assignment then in condition expression.
Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1227,7 +1227,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
ssi_private->dma_params_tx.addr = ssi_private->ssi_phys + CCSR_SSI_STX0;
ssi_private->dma_params_rx.addr = ssi_private->ssi_phys + CCSR_SSI_SRX0;
- ret = !of_property_read_u32_array(np, "dmas", dmas, 4);
+ ret = of_property_read_u32_array(np, "dmas", dmas, 4);
if (ssi_private->use_dma && !ret && dmas[2] == IMX_DMATYPE_SSI_DUAL) {
ssi_private->use_dual_fifo = true;
/* When using dual fifo mode, we need to keep watermark
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check
2015-03-04 21:48 [PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check Maciej S. Szmigiero
@ 2015-03-05 1:01 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-03-05 1:01 UTC (permalink / raw)
To: Maciej S. Szmigiero
Cc: alsa-devel, linux-kernel, Timur Tabi, Nicolin Chen, Xiubo Li,
Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
On Wed, Mar 04, 2015 at 10:48:30PM +0100, Maciej S. Szmigiero wrote:
> of_property_read_u32_array returns 0 on success,
> so the return value shouldn't be inverted twice,
> first on assignment then in condition expression.
>
> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-05 1:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 21:48 [PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check Maciej S. Szmigiero
2015-03-05 1:01 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®