* [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
@ 2025-03-07 9:30 Dan Carpenter
2025-03-07 9:36 ` Dmitry Osipenko
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2025-03-07 9:30 UTC (permalink / raw)
To: Shreeya Patel
Cc: Mauro Carvalho Chehab, Dmitry Osipenko, Hans Verkuil,
Dingxian Wen, linux-media, kernel, linux-kernel, kernel-janitors
The num_clks is set this way:
hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
if (hdmirx_dev->num_clks < 1)
return -ENODEV;
The devm_clk_bulk_get_all() function returns negative error codes so the
hdmirx_dev->num_cks variable needs to be signed for the error handling to
work.
Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index 4ffc86ad6c35..e0d3fed87a92 100644
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -154,7 +154,7 @@ struct snps_hdmirx_dev {
bool hpd_trigger_level_high;
bool tmds_clk_ratio;
bool plugged;
- u32 num_clks;
+ int num_clks;
u32 edid_blocks_written;
u32 cur_fmt_fourcc;
u32 color_depth;
--
2.47.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
2025-03-07 9:30 [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt() Dan Carpenter
@ 2025-03-07 9:36 ` Dmitry Osipenko
2025-03-07 9:45 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Osipenko @ 2025-03-07 9:36 UTC (permalink / raw)
To: Dan Carpenter, Shreeya Patel
Cc: Mauro Carvalho Chehab, Hans Verkuil, Dingxian Wen, linux-media,
kernel, linux-kernel, kernel-janitors
On 3/7/25 12:30, Dan Carpenter wrote:
> The num_clks is set this way:
>
> hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
> if (hdmirx_dev->num_clks < 1)
> return -ENODEV;
>
> The devm_clk_bulk_get_all() function returns negative error codes so the
> hdmirx_dev->num_cks variable needs to be signed for the error handling to
> work.
>
> Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index 4ffc86ad6c35..e0d3fed87a92 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -154,7 +154,7 @@ struct snps_hdmirx_dev {
> bool hpd_trigger_level_high;
> bool tmds_clk_ratio;
> bool plugged;
> - u32 num_clks;
> + int num_clks;
> u32 edid_blocks_written;
> u32 cur_fmt_fourcc;
> u32 color_depth;
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Would be also good to return the original error code. There is no need
to check for the < 1 clock, it should be the < 0 check. Can be done in a
separate patch later. Thanks for the fix!
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
2025-03-07 9:36 ` Dmitry Osipenko
@ 2025-03-07 9:45 ` Dan Carpenter
2025-03-07 9:47 ` Dmitry Osipenko
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2025-03-07 9:45 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Shreeya Patel, Mauro Carvalho Chehab, Hans Verkuil, Dingxian Wen,
linux-media, kernel, linux-kernel, kernel-janitors
On Fri, Mar 07, 2025 at 12:36:47PM +0300, Dmitry Osipenko wrote:
> On 3/7/25 12:30, Dan Carpenter wrote:
> > diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> > index 4ffc86ad6c35..e0d3fed87a92 100644
> > --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> > +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> > @@ -154,7 +154,7 @@ struct snps_hdmirx_dev {
> > bool hpd_trigger_level_high;
> > bool tmds_clk_ratio;
> > bool plugged;
> > - u32 num_clks;
> > + int num_clks;
> > u32 edid_blocks_written;
> > u32 cur_fmt_fourcc;
> > u32 color_depth;
>
> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>
> Would be also good to return the original error code. There is no need
> to check for the < 1 clock, it should be the < 0 check. Can be done in a
> separate patch later. Thanks for the fix!
I'm not very familiar with th edevm_clk_bulk_get_all() function and it's
not documented. But clk_bulk_get_all() does return zero, so I can see why
people would be confused.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
2025-03-07 9:45 ` Dan Carpenter
@ 2025-03-07 9:47 ` Dmitry Osipenko
2025-03-07 9:58 ` Hans Verkuil
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Osipenko @ 2025-03-07 9:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Shreeya Patel, Mauro Carvalho Chehab, Hans Verkuil, Dingxian Wen,
linux-media, kernel, linux-kernel, kernel-janitors
On 3/7/25 12:45, Dan Carpenter wrote:
> On Fri, Mar 07, 2025 at 12:36:47PM +0300, Dmitry Osipenko wrote:
>> On 3/7/25 12:30, Dan Carpenter wrote:
>>> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>> index 4ffc86ad6c35..e0d3fed87a92 100644
>>> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>> @@ -154,7 +154,7 @@ struct snps_hdmirx_dev {
>>> bool hpd_trigger_level_high;
>>> bool tmds_clk_ratio;
>>> bool plugged;
>>> - u32 num_clks;
>>> + int num_clks;
>>> u32 edid_blocks_written;
>>> u32 cur_fmt_fourcc;
>>> u32 color_depth;
>>
>> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>
>> Would be also good to return the original error code. There is no need
>> to check for the < 1 clock, it should be the < 0 check. Can be done in a
>> separate patch later. Thanks for the fix!
>
> I'm not very familiar with th edevm_clk_bulk_get_all() function and it's
> not documented. But clk_bulk_get_all() does return zero, so I can see why
> people would be confused.
We will take care of it, thanks again.
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
2025-03-07 9:47 ` Dmitry Osipenko
@ 2025-03-07 9:58 ` Hans Verkuil
2025-03-07 10:00 ` Dmitry Osipenko
0 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2025-03-07 9:58 UTC (permalink / raw)
To: Dmitry Osipenko, Dan Carpenter
Cc: Shreeya Patel, Mauro Carvalho Chehab, Dingxian Wen, linux-media,
kernel, linux-kernel, kernel-janitors
On 07/03/2025 10:47, Dmitry Osipenko wrote:
> On 3/7/25 12:45, Dan Carpenter wrote:
>> On Fri, Mar 07, 2025 at 12:36:47PM +0300, Dmitry Osipenko wrote:
>>> On 3/7/25 12:30, Dan Carpenter wrote:
>>>> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>>> index 4ffc86ad6c35..e0d3fed87a92 100644
>>>> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>>> @@ -154,7 +154,7 @@ struct snps_hdmirx_dev {
>>>> bool hpd_trigger_level_high;
>>>> bool tmds_clk_ratio;
>>>> bool plugged;
>>>> - u32 num_clks;
>>>> + int num_clks;
>>>> u32 edid_blocks_written;
>>>> u32 cur_fmt_fourcc;
>>>> u32 color_depth;
>>>
>>> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>
>>> Would be also good to return the original error code. There is no need
>>> to check for the < 1 clock, it should be the < 0 check. Can be done in a
>>> separate patch later. Thanks for the fix!
>>
>> I'm not very familiar with th edevm_clk_bulk_get_all() function and it's
>> not documented. But clk_bulk_get_all() does return zero, so I can see why
>> people would be confused.
>
> We will take care of it, thanks again.
>
I'm confused. Is Dan's patch correct or is more work needed? If more work is
needed, then I prefer to have a single patch correcting the devm_clk_bulk_get_all()
handling.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
2025-03-07 9:58 ` Hans Verkuil
@ 2025-03-07 10:00 ` Dmitry Osipenko
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2025-03-07 10:00 UTC (permalink / raw)
To: Hans Verkuil, Dan Carpenter
Cc: Shreeya Patel, Mauro Carvalho Chehab, Dingxian Wen, linux-media,
kernel, linux-kernel, kernel-janitors
On 3/7/25 12:58, Hans Verkuil wrote:
> On 07/03/2025 10:47, Dmitry Osipenko wrote:
>> On 3/7/25 12:45, Dan Carpenter wrote:
>>> On Fri, Mar 07, 2025 at 12:36:47PM +0300, Dmitry Osipenko wrote:
>>>> On 3/7/25 12:30, Dan Carpenter wrote:
>>>>> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>>>> index 4ffc86ad6c35..e0d3fed87a92 100644
>>>>> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>>>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>>>> @@ -154,7 +154,7 @@ struct snps_hdmirx_dev {
>>>>> bool hpd_trigger_level_high;
>>>>> bool tmds_clk_ratio;
>>>>> bool plugged;
>>>>> - u32 num_clks;
>>>>> + int num_clks;
>>>>> u32 edid_blocks_written;
>>>>> u32 cur_fmt_fourcc;
>>>>> u32 color_depth;
>>>>
>>>> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>>
>>>> Would be also good to return the original error code. There is no need
>>>> to check for the < 1 clock, it should be the < 0 check. Can be done in a
>>>> separate patch later. Thanks for the fix!
>>>
>>> I'm not very familiar with th edevm_clk_bulk_get_all() function and it's
>>> not documented. But clk_bulk_get_all() does return zero, so I can see why
>>> people would be confused.
>>
>> We will take care of it, thanks again.
>>
>
> I'm confused. Is Dan's patch correct or is more work needed? If more work is
> needed, then I prefer to have a single patch correcting the devm_clk_bulk_get_all()
> handling.
Dan's patch is good, please merge it.
Propagation of original error code that I said about will be additional
improvement.
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-07 10:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-07 9:30 [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt() Dan Carpenter
2025-03-07 9:36 ` Dmitry Osipenko
2025-03-07 9:45 ` Dan Carpenter
2025-03-07 9:47 ` Dmitry Osipenko
2025-03-07 9:58 ` Hans Verkuil
2025-03-07 10:00 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®