From: Shuah Khan <shuahkh@osg.samsung.com>
To: Andrey Vagin <avagin@openvz.org>,
linux-kernel@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests/exec: take into account that zero is a success code
Date: Fri, 13 Mar 2015 10:07:40 -0600 [thread overview]
Message-ID: <55030B4C.1080000@osg.samsung.com> (raw)
In-Reply-To: <1426262228-14688-1-git-send-email-avagin@openvz.org>
On 03/13/2015 09:57 AM, Andrey Vagin wrote:
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Signed-off-by: Andrey Vagin <avagin@openvz.org>
Andrey,
Please add a meaningful commit log for this patch and resend.
-- Shuah
> ---
> tools/testing/selftests/exec/execveat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c
> index e238c95..6747a3f 100644
> --- a/tools/testing/selftests/exec/execveat.c
> +++ b/tools/testing/selftests/exec/execveat.c
> @@ -47,7 +47,7 @@ static int _check_execveat_fail(int fd, const char *path, int flags,
> fd, path?:"(null)", flags, errno_str);
> rc = execveat_(fd, path, argv, envp, flags);
>
> - if (rc > 0) {
> + if (rc >= 0) {
> printf("[FAIL] (unexpected success from execveat(2))\n");
> return 1;
> }
>
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
prev parent reply other threads:[~2015-03-13 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 15:57 Andrey Vagin
2015-03-13 16:07 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55030B4C.1080000@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®