* [PATCH] selftests/exec: take into account that zero is a success code
@ 2015-03-13 15:57 Andrey Vagin
2015-03-13 16:07 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Vagin @ 2015-03-13 15:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrey Vagin, Shuah Khan
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
tools/testing/selftests/exec/execveat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c
index e238c95..6747a3f 100644
--- a/tools/testing/selftests/exec/execveat.c
+++ b/tools/testing/selftests/exec/execveat.c
@@ -47,7 +47,7 @@ static int _check_execveat_fail(int fd, const char *path, int flags,
fd, path?:"(null)", flags, errno_str);
rc = execveat_(fd, path, argv, envp, flags);
- if (rc > 0) {
+ if (rc >= 0) {
printf("[FAIL] (unexpected success from execveat(2))\n");
return 1;
}
--
2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] selftests/exec: take into account that zero is a success code
2015-03-13 15:57 [PATCH] selftests/exec: take into account that zero is a success code Andrey Vagin
@ 2015-03-13 16:07 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2015-03-13 16:07 UTC (permalink / raw)
To: Andrey Vagin, linux-kernel, Shuah Khan
On 03/13/2015 09:57 AM, Andrey Vagin wrote:
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Signed-off-by: Andrey Vagin <avagin@openvz.org>
Andrey,
Please add a meaningful commit log for this patch and resend.
-- Shuah
> ---
> tools/testing/selftests/exec/execveat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c
> index e238c95..6747a3f 100644
> --- a/tools/testing/selftests/exec/execveat.c
> +++ b/tools/testing/selftests/exec/execveat.c
> @@ -47,7 +47,7 @@ static int _check_execveat_fail(int fd, const char *path, int flags,
> fd, path?:"(null)", flags, errno_str);
> rc = execveat_(fd, path, argv, envp, flags);
>
> - if (rc > 0) {
> + if (rc >= 0) {
> printf("[FAIL] (unexpected success from execveat(2))\n");
> return 1;
> }
>
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-13 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-13 15:57 [PATCH] selftests/exec: take into account that zero is a success code Andrey Vagin
2015-03-13 16:07 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®