From: yangxingui <yangxingui@huawei.com>
To: John Garry <john.g.garry@oracle.com>,
<James.Bottomley@HansenPartnership.com>,
<martin.petersen@oracle.com>, <dlemoal@kernel.org>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <liuyonglong@huawei.com>,
<kangfenglong@huawei.com>, <hare@suse.com>
Subject: Re: [PATCH v2 2/2] scsi: hisi_sas: add spinup_notify callback to handle Active_Wait/Idle_Wait SSP devices
Date: Tue, 21 Jul 2026 19:10:27 +0800 [thread overview]
Message-ID: <55307987-d86b-f28c-7c39-0a6bafe182bb@huawei.com> (raw)
In-Reply-To: <c9a91dd7-b158-4416-93bb-9ae1e1acb8a3@oracle.com>
On 2026/7/20 17:47, John Garry wrote:
> +
>
>> +void hisi_sas_spinup_notify(struct scsi_device *sdev)
>> +{
>> + struct domain_device *dev = sdev_to_domain_dev(sdev);
>> + struct sas_ha_struct *sha;
>> + struct hisi_hba *hisi_hba;
>> + struct sas_phy *local_phy;
>> + struct hisi_sas_phy *phy;
>> +
>> + if (dev->parent && dev_is_expander(dev->parent->dev_type))
>> + return;
>> +
>> + sha = SHOST_TO_SAS_HA(sdev->host);
>> + hisi_hba = sha->lldd_ha;
>> +
>> + local_phy = sas_get_local_phy(dev);
>> + phy = &hisi_hba->phy[local_phy->number];
>> + if (phy->identify.target_port_protocols & SAS_PROTOCOL_SSP)
>> + hisi_sas_notify_phy_event(phy, HISI_PHYE_SPINUP_NOTIFY);
>> + sas_put_local_phy(local_phy);
>> +}
>> +EXPORT_SYMBOL_GPL(hisi_sas_spinup_notify);
> This could go in libsas
Hi, John.
Are you suggesting that we add an event like `PHYE_NOTIFY_ENABLE_SPINUP`
and a callback like `lldd_notify_enable_spinup` to libsas? If so, should
libsas parse the sense data directly—for instance, by handling it within
the `sas_ssp_task_response()` function?
Thanks,
Xingui
next prev parent reply other threads:[~2026-07-21 11:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 2:28 [PATCH v2 0/2] scsi: support spinup notification for SAS SSP devices in Active_Wait/Idle_Wait state Xingui Yang
2026-07-03 2:28 ` [PATCH v2 1/2] scsi: scsi_lib: add spinup_notify callback for ASC/ASCQ=0x04/0x11 Xingui Yang
2026-07-20 9:46 ` John Garry
2026-07-03 2:28 ` [PATCH v2 2/2] scsi: hisi_sas: add spinup_notify callback to handle Active_Wait/Idle_Wait SSP devices Xingui Yang
2026-07-20 9:47 ` John Garry
2026-07-21 11:10 ` yangxingui [this message]
2026-07-21 12:33 ` John Garry
2026-07-21 13:33 ` yangxingui
2026-07-22 8:47 ` John Garry
2026-07-22 9:11 ` yangxingui
2026-07-20 2:37 ` [PATCH v2 0/2] scsi: support spinup notification for SAS SSP devices in Active_Wait/Idle_Wait state yangxingui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55307987-d86b-f28c-7c39-0a6bafe182bb@huawei.com \
--to=yangxingui@huawei.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.com \
--cc=john.g.garry@oracle.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®