From: John Garry <john.g.garry@oracle.com>
To: yangxingui <yangxingui@huawei.com>,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, dlemoal@kernel.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, liuyonglong@huawei.com,
kangfenglong@huawei.com, hare@suse.com
Subject: Re: [PATCH v2 2/2] scsi: hisi_sas: add spinup_notify callback to handle Active_Wait/Idle_Wait SSP devices
Date: Wed, 22 Jul 2026 09:47:05 +0100 [thread overview]
Message-ID: <c5390973-6db4-4191-8330-dea5830da4f0@oracle.com> (raw)
In-Reply-To: <7baf77e4-345b-3419-6562-f0e435227e5a@huawei.com>
On 21/07/2026 14:33, yangxingui wrote:
>>
>> Yeah, it would be something like that.
>>
>> But the method to solve this issue is unclear.
>>
>> Back to the original issue: hisi_sas_spinup_notify_work() calls
>> sl_notify_ssp, but sl_notify_ssp is called already in
>> hisi_sas_phyup_work_common() - so why is it needed to be called again?
> In fact, the trigger for this point sometimes fails to take effect.
>
>> If it is because hisi_sas_phyup_work_common() is only for direct-
>> attached disks, and we need to call sl_notify_ssp for expander
>> attached disks?
>
> NOTIFY(SPIN UP) is primarily intended for direct-attached HDD wake-up
> post-IDENTIFY exchange. Routing it to an Expander may conflict with SAS
> topology constraints and could disrupt link-layer arbitration,
> indicating that a conditional disable mechanism for cfg_notify_en in
> non-direct topologies is advisable.
This problem which you are trying to solve is only for direct-attached
disks, right?
next prev parent reply other threads:[~2026-07-22 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 2:28 [PATCH v2 0/2] scsi: support spinup notification for SAS SSP devices in Active_Wait/Idle_Wait state Xingui Yang
2026-07-03 2:28 ` [PATCH v2 1/2] scsi: scsi_lib: add spinup_notify callback for ASC/ASCQ=0x04/0x11 Xingui Yang
2026-07-20 9:46 ` John Garry
2026-07-03 2:28 ` [PATCH v2 2/2] scsi: hisi_sas: add spinup_notify callback to handle Active_Wait/Idle_Wait SSP devices Xingui Yang
2026-07-20 9:47 ` John Garry
2026-07-21 11:10 ` yangxingui
2026-07-21 12:33 ` John Garry
2026-07-21 13:33 ` yangxingui
2026-07-22 8:47 ` John Garry [this message]
2026-07-22 9:11 ` yangxingui
2026-07-20 2:37 ` [PATCH v2 0/2] scsi: support spinup notification for SAS SSP devices in Active_Wait/Idle_Wait state yangxingui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5390973-6db4-4191-8330-dea5830da4f0@oracle.com \
--to=john.g.garry@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®