From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Richard Henderson <rth@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Vladimir Makarov <vmakarov@redhat.com>,
Jakub Jelinek <jakub@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
"gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: [RFC] Design for flag bit outputs from asms
Date: Mon, 04 May 2015 13:42:01 -0700 [thread overview]
Message-ID: <5547D999.9040005@zytor.com> (raw)
In-Reply-To: <CA+55aFzCuu=n0SFiVyxv7ETxFTYZCBW-0S_RX=WZnwzORh4-7g@mail.gmail.com>
On 05/04/2015 01:35 PM, Linus Torvalds wrote:
> On Mon, May 4, 2015 at 1:14 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>>
>> I would argue that for x86 what you actually want is to model the
>> *conditions* that are available on the flags, not the flags themselves.
>
> Yes. Otherwise it would be a nightmare to try to describe simple
> conditions like "le", which a rather complicated combination of three
> of the actual flag bits:
>
> ((SF ^^ OF) || ZF) = 1
>
> which would just be ridiculously painful for (a) the user to describe
> and (b) fior the compiler to recognize once described.
>
> Now, I do admit that most of the cases where you'd use inline asm with
> condition codes would probably fall into just simple "test ZF or CF".
> But I could certainly imagine other cases.
>
Yes, although once again I'm more than happy to let gcc do the boolean
optimizations if it already has logic to do so (which it might have/want
for its own reasons.)
-hpa
next prev parent reply other threads:[~2015-05-04 20:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 15:16 [PATCH] x86: Optimize variable_test_bit() Peter Zijlstra
2015-05-01 16:03 ` Linus Torvalds
2015-05-01 16:16 ` Peter Zijlstra
2015-05-01 16:29 ` Peter Zijlstra
2015-05-01 16:18 ` Peter Zijlstra
2015-05-01 16:33 ` Jakub Jelinek
2015-05-01 16:45 ` Linus Torvalds
2015-05-01 16:46 ` Peter Zijlstra
2015-05-01 17:17 ` Ingo Molnar
2015-05-01 19:02 ` Vladimir Makarov
2015-05-01 20:49 ` Linus Torvalds
2015-05-01 22:22 ` Vladimir Makarov
2015-05-02 12:39 ` Peter Zijlstra
2015-05-04 15:37 ` Richard Henderson
2015-05-04 19:33 ` [RFC] Design for flag bit outputs from asms Richard Henderson
2015-05-04 20:14 ` H. Peter Anvin
2015-05-04 20:27 ` H. Peter Anvin
2015-05-04 20:33 ` Richard Henderson
2015-05-04 20:45 ` Linus Torvalds
2015-05-04 20:57 ` Richard Henderson
2015-05-04 21:23 ` H. Peter Anvin
2015-05-04 20:35 ` Linus Torvalds
2015-05-04 20:42 ` H. Peter Anvin [this message]
2015-05-05 9:01 ` Gabriel Paubert
2015-05-05 13:50 ` Segher Boessenkool
2015-05-05 15:37 ` Linus Torvalds
2015-05-05 16:10 ` Segher Boessenkool
2015-05-02 12:43 ` [PATCH] x86: Optimize variable_test_bit() Peter Zijlstra
2015-05-04 18:07 ` Vladimir Makarov
2015-05-04 20:14 ` H. Peter Anvin
2015-05-04 13:42 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547D999.9040005@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rth@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome