From: Michael Neuling <mikey@neuling.org>
To: Diwakar Tundlam <dtundlam@nvidia.com>
Cc: "'Peter Zijlstra'" <a.p.zijlstra@chello.nl>,
"'Ingo Molnar'" <mingo@kernel.org>,
"'Andrew Morton'" <akpm@linux-foundation.org>,
"'Christoph Lameter'" <cl@gentwo.org>,
"'Stephen Rothwell'" <sfr@canb.auug.org.au>,
"'Benjamin Herrenschmidt'" <benh@kernel.crashing.org>,
"'David Rientjes'" <rientjes@google.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Subject: Re: [PATCH] sched: Enable arch-specific asym packing option in sched domain
Date: Sat, 05 May 2012 08:47:52 +1000 [thread overview]
Message-ID: <5568.1336171672@neuling.org> (raw)
In-Reply-To: <1DD7BFEDD3147247B1355BEFEFE46652379C3DF102@HQMAIL04.nvidia.com>
Diwakar Tundlam <dtundlam@nvidia.com> wrote:
> >> A repost doesn't make it right to add sibling (SMT) properties to a package/socket and will still upset Power7.
>
> Agreed. I only fixed the whitespace and commitId.
>
> arch_sd_sibling_asym_packing() is already present under ifdef CONFIG_SMT.
> I didn't touch that. I only added it to SD_CPU_INIT for all cpu's.
> I assumed Power7 shouldn't use SD_CPU_INIT.
You are using sibling at the cpu level. POWER7 sets this at the sibling
level and we don't really want it at the cpu level.
> I don't understand Power7 arch to comment on impact.
> Michael Neuling should review this carefully and advise.
Ask Peter said, it's broken for POWER7. We don't want to set this at
the cpu level.
> Maybe I should define a separate weak symbol, say
> arch_sd_bias_to_lower_num_cpu()? Then Power7 can define
> arch_sd_sibling_asym_packing() to be '1' and it will not break all-cpu
> init.
This sounds better but I'd follow the old name call it
arch_sd_cpu_asym_packing()
Mikey
next prev parent reply other threads:[~2012-05-04 22:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 20:28 Diwakar Tundlam
2012-05-04 21:17 ` Peter Zijlstra
2012-05-04 22:06 ` Diwakar Tundlam
2012-05-04 22:10 ` Peter Zijlstra
2012-05-04 22:18 ` Diwakar Tundlam
2012-05-04 22:29 ` Peter Zijlstra
2012-05-04 23:18 ` Diwakar Tundlam
2012-05-04 23:20 ` Michael Neuling
2012-05-04 23:25 ` Diwakar Tundlam
2012-05-04 23:41 ` Michael Neuling
2012-05-07 2:59 ` Michael Wang
2012-05-04 23:55 ` Suresh Siddha
2012-05-05 20:35 ` Peter Zijlstra
2012-05-07 17:25 ` Diwakar Tundlam
2012-05-08 9:46 ` Peter Zijlstra
2012-05-04 22:47 ` Michael Neuling [this message]
2012-05-04 22:51 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5568.1336171672@neuling.org \
--to=mikey@neuling.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cl@gentwo.org \
--cc=dtundlam@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome