Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

[Guenter Roeck]

alpha:allmodconfig fails to build in -next with

drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared

BOTHER is not defined for all architectures and otherwise only
used with '#ifdef BOTHER'.

Guenter

Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

[Marcel Holtmann]

Hi Guenter,

> alpha:allmodconfig fails to build in -next with
> 
> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
> 
> BOTHER is not defined for all architectures and otherwise only
> used with '#ifdef BOTHER'.

thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.

Regards

Marcel

Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

[Guenter Roeck]

On 06/15/2015 06:58 AM, Marcel Holtmann wrote:
> Hi Guenter,
>
>> alpha:allmodconfig fails to build in -next with
>>
>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>
>> BOTHER is not defined for all architectures and otherwise only
>> used with '#ifdef BOTHER'.
>
> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>

So far it has been fixed with #ifdef, and this is the first code which
uses it outside drivers/tty. So my first tendency would be to fix it
on the user side.

However, looking into it, I think only alpha and avr32 are affected.
Let me submit patches against those and see where it goes.

Guenter

RE: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

[Ilya Faenson]

Hi Guenter,

-----Original Message-----
From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-owner@vger.kernel.org] On Behalf Of Guenter Roeck
Sent: Monday, June 15, 2015 10:25 AM
To: Marcel Holtmann
Cc: linux-kernel@vger.kernel.org; Frederic Danis; BlueZ development; linux-serial@vger.kernel.org
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

On 06/15/2015 06:58 AM, Marcel Holtmann wrote:
> Hi Guenter,
>
>> alpha:allmodconfig fails to build in -next with
>>
>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>
>> BOTHER is not defined for all architectures and otherwise only
>> used with '#ifdef BOTHER'.
>
> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>

So far it has been fixed with #ifdef, and this is the first code which
uses it outside drivers/tty. So my first tendency would be to fix it
on the user side.

However, looking into it, I think only alpha and avr32 are affected.
Let me submit patches against those and see where it goes.

IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion).

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

[Marcel Holtmann]

Hi Ilya,

>>> alpha:allmodconfig fails to build in -next with
>>> 
>>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>> 
>>> BOTHER is not defined for all architectures and otherwise only
>>> used with '#ifdef BOTHER'.
>> 
>> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>> 
> 
> So far it has been fixed with #ifdef, and this is the first code which
> uses it outside drivers/tty. So my first tendency would be to fix it
> on the user side.
> 
> However, looking into it, I think only alpha and avr32 are affected.
> Let me submit patches against those and see where it goes.
> 
> IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion).

can you extract this and just submit that version. We might just take that into hci_ldisc.c right away.

However fixing the #ifdef around BOTHER is useful as well since they look unneeded. At least I can not see a reason why a platform would not define them.

Regards

Marcel

RE: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

[Ilya Faenson]

Hi Marcel,

-----Original Message-----
From: Marcel Holtmann [mailto:marcel@holtmann.org] 
Sent: Monday, June 15, 2015 10:43 AM
To: Ilya Faenson
Cc: Guenter Roeck; linux-kernel@vger.kernel.org; Frederic Danis; BlueZ development; linux-serial@vger.kernel.org
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

Hi Ilya,

>>> alpha:allmodconfig fails to build in -next with
>>> 
>>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
>>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared
>>> 
>>> BOTHER is not defined for all architectures and otherwise only
>>> used with '#ifdef BOTHER'.
>> 
>> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.
>> 
> 
> So far it has been fixed with #ifdef, and this is the first code which
> uses it outside drivers/tty. So my first tendency would be to fix it
> on the user side.
> 
> However, looking into it, I think only alpha and avr32 are affected.
> Let me submit patches against those and see where it goes.
> 
> IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion).

can you extract this and just submit that version. We might just take that into hci_ldisc.c right away.

IF: I've published my version now, thanks.

However fixing the #ifdef around BOTHER is useful as well since they look unneeded. At least I can not see a reason why a platform would not define them.

Regards

Marcel