[PATCH v2] firmware: stratix10-svc: populate kaddr1 from config status response

[PATCH v2] firmware: stratix10-svc: populate kaddr1 from config status response

[adrian.ho.yin.ng]

From: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>

Set kaddr1 from res.a1 when the configuration status completes, matching
the existing error path and allowing callers to retrieve firmware-returned
status details through the standard kaddr1 interface.

Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
---
Changes in v2:
- Drop the callback-data lifetime / dangling-pointer changes.
- Reduce the series to this standalone patch. Set kaddr1 with &res.a1
  on the completed path, matching the existing error path.

v1 patch link:
https://lore.kernel.org/all/cover.1779780223.git.adrian.ho.yin.ng@altera.com/
---
 drivers/firmware/stratix10-svc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 34c591d7fd58..2333ea31e741 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -444,6 +444,7 @@ static void svc_thread_cmd_config_status(struct stratix10_svc_controller *ctrl,
 		cb_data->status = BIT(SVC_STATUS_BUSY);
 	} else if (res.a0 == INTEL_SIP_SMC_STATUS_OK) {
 		cb_data->status = BIT(SVC_STATUS_COMPLETED);
+		cb_data->kaddr1 = &res.a1;
 		cb_data->kaddr2 = (res.a2) ?
 				  svc_pa_to_va(res.a2) : NULL;
 		cb_data->kaddr3 = (res.a3) ? &res.a3 : NULL;
-- 
2.49.GIT

Re: [PATCH v2] firmware: stratix10-svc: populate kaddr1 from config status response

[Dinh Nguyen]

On 9/11/26 03:44, adrian.ho.yin.ng@altera.com wrote:
> From: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
> 
> Set kaddr1 from res.a1 when the configuration status completes, matching
> the existing error path and allowing callers to retrieve firmware-returned
> status details through the standard kaddr1 interface.
> 
> Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
> ---
> Changes in v2:
> - Drop the callback-data lifetime / dangling-pointer changes.
> - Reduce the series to this standalone patch. Set kaddr1 with &res.a1
>    on the completed path, matching the existing error path.
> 
> v1 patch link:
> https://lore.kernel.org/all/cover.1779780223.git.adrian.ho.yin.ng@altera.com/
> ---
>   drivers/firmware/stratix10-svc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
> index 34c591d7fd58..2333ea31e741 100644
> --- a/drivers/firmware/stratix10-svc.c
> +++ b/drivers/firmware/stratix10-svc.c
> @@ -444,6 +444,7 @@ static void svc_thread_cmd_config_status(struct stratix10_svc_controller *ctrl,
>   		cb_data->status = BIT(SVC_STATUS_BUSY);
>   	} else if (res.a0 == INTEL_SIP_SMC_STATUS_OK) {
>   		cb_data->status = BIT(SVC_STATUS_COMPLETED);
> +		cb_data->kaddr1 = &res.a1;
>   		cb_data->kaddr2 = (res.a2) ?
>   				  svc_pa_to_va(res.a2) : NULL;
>   		cb_data->kaddr3 = (res.a3) ? &res.a3 : NULL;

Applied!

Thanks,
Dinh