* [PATCH] fix return value error
@ 2015-10-14 8:17 Heloise NH
2015-10-14 11:59 ` Leon Romanovsky
0 siblings, 1 reply; 7+ messages in thread
From: Heloise NH @ 2015-10-14 8:17 UTC (permalink / raw)
To: infinipath, dledford, sean.hefty, hal.rosenstock
Cc: linux-rdma, os, linux-kernel
Signed-off-by: Heloise NH <os@iscas.ac.cn>
---
drivers/infiniband/hw/ipath/ipath_fs.c | 2 +-
drivers/infiniband/hw/qib/qib_fs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ipath/ipath_fs.c b/drivers/infiniband/hw/ipath/ipath_fs.c
index 25422a3..da753bc 100644
--- a/drivers/infiniband/hw/ipath/ipath_fs.c
+++ b/drivers/infiniband/hw/ipath/ipath_fs.c
@@ -53,7 +53,7 @@ static int ipathfs_mknod(struct inode *dir, struct dentry *dentry,
struct inode *inode = new_inode(dir->i_sb);
if (!inode) {
- error = -EPERM;
+ error = -ENOMEM;
goto bail;
}
diff --git a/drivers/infiniband/hw/qib/qib_fs.c b/drivers/infiniband/hw/qib/qib_fs.c
index 13ef22b..a4c5a6a 100644
--- a/drivers/infiniband/hw/qib/qib_fs.c
+++ b/drivers/infiniband/hw/qib/qib_fs.c
@@ -55,7 +55,7 @@ static int qibfs_mknod(struct inode *dir, struct dentry *dentry,
struct inode *inode = new_inode(dir->i_sb);
if (!inode) {
- error = -EPERM;
+ error = -ENOMEM;
goto bail;
}
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] fix return value error
2015-10-14 8:17 [PATCH] fix return value error Heloise NH
@ 2015-10-14 11:59 ` Leon Romanovsky
2015-10-14 13:55 ` Or Gerlitz
0 siblings, 1 reply; 7+ messages in thread
From: Leon Romanovsky @ 2015-10-14 11:59 UTC (permalink / raw)
To: Heloise NH
Cc: infinipath, dledford, sean.hefty, hal.rosenstock, linux-rdma,
linux-kernel
On Wed, Oct 14, 2015 at 11:17 AM, Heloise NH <os@iscas.ac.cn> wrote:
> Signed-off-by: Heloise NH <os@iscas.ac.cn>
The patch is a correct one, however can you update the subject and
description to be more informative?
Please add that new_inode() function can fail for allocation only.
> ---
> drivers/infiniband/hw/ipath/ipath_fs.c | 2 +-
> drivers/infiniband/hw/qib/qib_fs.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ipath/ipath_fs.c b/drivers/infiniband/hw/ipath/ipath_fs.c
> index 25422a3..da753bc 100644
> --- a/drivers/infiniband/hw/ipath/ipath_fs.c
> +++ b/drivers/infiniband/hw/ipath/ipath_fs.c
> @@ -53,7 +53,7 @@ static int ipathfs_mknod(struct inode *dir, struct dentry *dentry,
> struct inode *inode = new_inode(dir->i_sb);
>
> if (!inode) {
> - error = -EPERM;
> + error = -ENOMEM;
> goto bail;
> }
>
> diff --git a/drivers/infiniband/hw/qib/qib_fs.c b/drivers/infiniband/hw/qib/qib_fs.c
> index 13ef22b..a4c5a6a 100644
> --- a/drivers/infiniband/hw/qib/qib_fs.c
> +++ b/drivers/infiniband/hw/qib/qib_fs.c
> @@ -55,7 +55,7 @@ static int qibfs_mknod(struct inode *dir, struct dentry *dentry,
> struct inode *inode = new_inode(dir->i_sb);
>
> if (!inode) {
> - error = -EPERM;
> + error = -ENOMEM;
> goto bail;
> }
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] fix return value error
2015-10-14 11:59 ` Leon Romanovsky
@ 2015-10-14 13:55 ` Or Gerlitz
0 siblings, 0 replies; 7+ messages in thread
From: Or Gerlitz @ 2015-10-14 13:55 UTC (permalink / raw)
To: Leon Romanovsky, Heloise NH
Cc: infinipath, dledford, sean.hefty, hal.rosenstock, linux-rdma,
linux-kernel
On 10/14/2015 2:59 PM, Leon Romanovsky wrote:
> On Wed, Oct 14, 2015 at 11:17 AM, Heloise NH<os@iscas.ac.cn> wrote:
>> >Signed-off-by: Heloise NH<os@iscas.ac.cn>
> The patch is a correct one, however can you update the subject and
> description to be more informative?
> Please add that new_inode() function can fail for allocation only.
>
>> >---
>> > drivers/infiniband/hw/ipath/ipath_fs.c | 2 +-
>> > drivers/infiniband/hw/qib/qib_fs.c | 2 +-
NO... the ipath driver has moved to staging as part of its EOL process,
it's now under drivers/staging/rdma/ipath
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] fix return value error
@ 2015-10-14 7:46 Heloise NH
2015-10-14 14:12 ` Marciniszyn, Mike
2015-10-14 14:17 ` Marciniszyn, Mike
0 siblings, 2 replies; 7+ messages in thread
From: Heloise NH @ 2015-10-14 7:46 UTC (permalink / raw)
To: infinipath, dledford, sean.hefty, hal.rosenstock
Cc: linux-rdna, os, linux-kernel
Signed-off-by: Heloise NH <os@iscas.ac.cn>
---
drivers/infiniband/hw/ipath/ipath_fs.c | 2 +-
drivers/infiniband/hw/qib/qib_fs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ipath/ipath_fs.c b/drivers/infiniband/hw/ipath/ipath_fs.c
index 25422a3..da753bc 100644
--- a/drivers/infiniband/hw/ipath/ipath_fs.c
+++ b/drivers/infiniband/hw/ipath/ipath_fs.c
@@ -53,7 +53,7 @@ static int ipathfs_mknod(struct inode *dir, struct dentry *dentry,
struct inode *inode = new_inode(dir->i_sb);
if (!inode) {
- error = -EPERM;
+ error = -ENOMEM;
goto bail;
}
diff --git a/drivers/infiniband/hw/qib/qib_fs.c b/drivers/infiniband/hw/qib/qib_fs.c
index 13ef22b..a4c5a6a 100644
--- a/drivers/infiniband/hw/qib/qib_fs.c
+++ b/drivers/infiniband/hw/qib/qib_fs.c
@@ -55,7 +55,7 @@ static int qibfs_mknod(struct inode *dir, struct dentry *dentry,
struct inode *inode = new_inode(dir->i_sb);
if (!inode) {
- error = -EPERM;
+ error = -ENOMEM;
goto bail;
}
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH] fix return value error
2015-10-14 7:46 Heloise NH
@ 2015-10-14 14:12 ` Marciniszyn, Mike
2015-10-14 14:17 ` Marciniszyn, Mike
1 sibling, 0 replies; 7+ messages in thread
From: Marciniszyn, Mike @ 2015-10-14 14:12 UTC (permalink / raw)
To: Heloise NH, dledford, Hefty, Sean, hal.rosenstock
Cc: linux-kernel, linux-rdma
> Subject: [PATCH] fix return value error
>
I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (-ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM).
Not entirely consistent but this matches the majority.
I agree -EPERM is pretty misleading.
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] fix return value error
2015-10-14 7:46 Heloise NH
2015-10-14 14:12 ` Marciniszyn, Mike
@ 2015-10-14 14:17 ` Marciniszyn, Mike
2015-10-14 14:29 ` Leon Romanovsky
1 sibling, 1 reply; 7+ messages in thread
From: Marciniszyn, Mike @ 2015-10-14 14:17 UTC (permalink / raw)
To: Heloise NH, dledford, Hefty, Sean, hal.rosenstock,
Or Gerlitz (gerlitz.or@gmail.com)
Cc: linux-kernel, linux-rdma
> > Subject: [PATCH] fix return value error
> >
>
> I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (-
> ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM).
>
> Not entirely consistent but this matches the majority.
>
> I agree -EPERM is pretty misleading.
>
> Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Thanks Or on catching the bad directory in the patch.
Doug, can you fix this up or do you want it resubmitted?
Mike
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fix return value error
2015-10-14 14:17 ` Marciniszyn, Mike
@ 2015-10-14 14:29 ` Leon Romanovsky
0 siblings, 0 replies; 7+ messages in thread
From: Leon Romanovsky @ 2015-10-14 14:29 UTC (permalink / raw)
To: Marciniszyn, Mike
Cc: Heloise NH, dledford, Hefty, Sean, hal.rosenstock,
Or Gerlitz (gerlitz.or@gmail.com),
linux-kernel, linux-rdma
On Wed, Oct 14, 2015 at 5:17 PM, Marciniszyn, Mike
<mike.marciniszyn@intel.com> wrote:
>> > Subject: [PATCH] fix return value error
>> >
>>
>> I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (-
>> ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM).
>>
>> Not entirely consistent but this matches the majority.
>>
>> I agree -EPERM is pretty misleading.
>>
>> Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
>
> Thanks Or on catching the bad directory in the patch.
Thanks Or
>
> Doug, can you fix this up or do you want it resubmitted?
>
> Mike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-10-14 14:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-14 8:17 [PATCH] fix return value error Heloise NH
2015-10-14 11:59 ` Leon Romanovsky
2015-10-14 13:55 ` Or Gerlitz
-- strict thread matches above, loose matches on Subject: below --
2015-10-14 7:46 Heloise NH
2015-10-14 14:12 ` Marciniszyn, Mike
2015-10-14 14:17 ` Marciniszyn, Mike
2015-10-14 14:29 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome