From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle
Date: Mon, 24 Nov 2025 20:53:18 +0100 [thread overview]
Message-ID: <563ac54a-de2d-49af-a6a6-3230c8070c67@kernel.org> (raw)
In-Reply-To: <20251124111914.3187803-2-neeraj.soni@oss.qualcomm.com>
On 24/11/2025 12:19, Neeraj Soni wrote:
> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
$ git grep kodiak
Nothing. Please do not introduce some new namings.
> So add the qcom,ice property to reference it.
>
...
> + else:
> + properties:
> + reg:
> + minItems: 2
> + items:
> + - description: Host controller register map
> + - description: SD Core register map
> + - description: CQE register map
> + - description: Inline Crypto Engine register map
> + reg-names:
> + minItems: 2
> + items:
> + - const: hc
> + - const: core
> + - const: cqhci
> + - const: ice
No, look at the binding - it says there are variants without core. You
cannot just rewrite everyone here.
I don't get what you want to achieve here, but the amount of errors this
patch generates should make you think whether it is even correct. Or you
never tested this?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-24 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 11:19 [PATCH 0/2] Enable Inline crypto engine for kodiak Neeraj Soni
2025-11-24 11:19 ` [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni
2025-11-24 19:53 ` Krzysztof Kozlowski [this message]
2025-11-25 5:10 ` Neeraj Soni
2025-11-24 11:19 ` [PATCH 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni
2025-11-24 19:54 ` Krzysztof Kozlowski
2025-11-24 14:28 ` [PATCH 0/2] Enable Inline crypto engine for kodiak Rob Herring
2025-11-25 4:58 ` Neeraj Soni
2025-11-25 10:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563ac54a-de2d-49af-a6a6-3230c8070c67@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®