From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC
Date: Mon, 24 Nov 2025 20:54:13 +0100 [thread overview]
Message-ID: <db24d435-edd7-4b90-99d2-8e62c53340de@kernel.org> (raw)
In-Reply-To: <20251124111914.3187803-3-neeraj.soni@oss.qualcomm.com>
On 24/11/2025 12:19, Neeraj Soni wrote:
> Add an ICE node to kodiak SoC description and enable it by adding a
> phandle to the SDHC node.
>
> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/kodiak.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> index c2ccbb67f800..9d2029a906ce 100644
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> @@ -1069,6 +1069,15 @@ opp-384000000 {
> opp-avg-kBps = <390000 0>;
> };
> };
> +
> + qcom,ice = <&sdhc_ice>;
This wasn't tested, for sure you have warnings - you placed the property
randomly or at the end (even worse...). Please read DTS coding style as
well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-24 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 11:19 [PATCH 0/2] Enable Inline crypto engine for kodiak Neeraj Soni
2025-11-24 11:19 ` [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni
2025-11-24 19:53 ` Krzysztof Kozlowski
2025-11-25 5:10 ` Neeraj Soni
2025-11-24 11:19 ` [PATCH 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni
2025-11-24 19:54 ` Krzysztof Kozlowski [this message]
2025-11-24 14:28 ` [PATCH 0/2] Enable Inline crypto engine for kodiak Rob Herring
2025-11-25 4:58 ` Neeraj Soni
2025-11-25 10:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db24d435-edd7-4b90-99d2-8e62c53340de@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®