Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Neeraj Soni <neeraj.soni@oss.qualcomm.com>]

Hi,

On 11/25/2025 1:23 AM, Krzysztof Kozlowski wrote:
> On 24/11/2025 12:19, Neeraj Soni wrote:
>> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
> 
> $ git grep kodiak
> Nothing. Please do not introduce some new namings.
This change renames sc7280 to kodiak:
https://lore.kernel.org/r/20251030-rename-dts-2-v1-2-80c0b81c4d77@oss.qualcomm.com
so i kept both the names. I will remove kodiak and just keep sc7280.
> 
> 
> 
>> So add the qcom,ice property to reference it.
>>
> 
> ...
> 
>> +    else:
>> +      properties:
>> +        reg:
>> +          minItems: 2
>> +          items:
>> +            - description: Host controller register map
>> +            - description: SD Core register map
>> +            - description: CQE register map
>> +            - description: Inline Crypto Engine register map
>> +        reg-names:
>> +          minItems: 2
>> +          items:
>> +            - const: hc
>> +            - const: core
>> +            - const: cqhci
>> +            - const: ice
> 
> No, look at the binding - it says there are variants without core. You
> cannot just rewrite everyone here.
> 
> I don't get what you want to achieve here, but the amount of errors this
> patch generates should make you think whether it is even correct. Or you
> never tested this?
Thanks for the comment. I tested the change with below commands:
pip install dtschema
make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
make dtbs_check
but did not see any errors. I will re-check what i missed and re-test to fix accordingly.
> 
> Best regards,
> Krzysztof
> 
Regards,
Neeraj