* [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a
@ 2015-12-23 13:29 Rameshswar Prasad Sahu
2016-01-05 10:25 ` Rameshwar Sahu
2016-01-27 14:15 ` Ulf Hansson
0 siblings, 2 replies; 6+ messages in thread
From: Rameshswar Prasad Sahu @ 2015-12-23 13:29 UTC (permalink / raw)
To: ulf.hansson, michal.simek, soren.brinkmann
Cc: linux-mmc, arnd, linux-kernel, devicetree, linux-arm-kernel, jcm,
patches, kgondkar, Rameshwar Prasad Sahu
From: Rameshwar Prasad Sahu <rsahu@apm.com>
The Arason SD host controller supports set block count command (cmd23)
and high speed mode. This patch re-enable both of these features that
was disabled. For device that doesn't support high speed, it should
configure its capability register accordingly instead disables it
explicitly.
Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 75379cb..5d9fdb3 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
goto clk_disable_all;
}
- if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
- host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
- host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
- }
-
sdhci_get_of_property(pdev);
pltfm_host = sdhci_priv(host);
pltfm_host->priv = sdhci_arasan;
--
1.7.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a
2015-12-23 13:29 [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a Rameshswar Prasad Sahu
@ 2016-01-05 10:25 ` Rameshwar Sahu
2016-01-07 1:33 ` Jaehoon Chung
2016-01-27 14:15 ` Ulf Hansson
1 sibling, 1 reply; 6+ messages in thread
From: Rameshwar Sahu @ 2016-01-05 10:25 UTC (permalink / raw)
To: ulf.hansson, michal.simek, soren.brinkmann
Cc: linux-mmc, Arnd Bergmann, linux-kernel, devicetree,
linux-arm-kernel, jcm, patches, Kaustubh Gondkar,
Rameshwar Prasad Sahu
Hi Ulf,
On Wed, Dec 23, 2015 at 6:59 PM, Rameshswar Prasad Sahu <rsahu@apm.com> wrote:
> From: Rameshwar Prasad Sahu <rsahu@apm.com>
>
> The Arason SD host controller supports set block count command (cmd23)
> and high speed mode. This patch re-enable both of these features that
> was disabled. For device that doesn't support high speed, it should
> configure its capability register accordingly instead disables it
> explicitly.
>
> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 75379cb..5d9fdb3 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> goto clk_disable_all;
> }
>
> - if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
> - host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
> - host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> - }
> -
> sdhci_get_of_property(pdev);
> pltfm_host = sdhci_priv(host);
> pltfm_host->priv = sdhci_arasan;
> --
> 1.7.1
>
Any comment on this patch ??
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a
2016-01-05 10:25 ` Rameshwar Sahu
@ 2016-01-07 1:33 ` Jaehoon Chung
2016-01-07 12:32 ` Rameshwar Sahu
0 siblings, 1 reply; 6+ messages in thread
From: Jaehoon Chung @ 2016-01-07 1:33 UTC (permalink / raw)
To: Rameshwar Sahu, ulf.hansson, michal.simek, soren.brinkmann
Cc: linux-mmc, Arnd Bergmann, linux-kernel, devicetree,
linux-arm-kernel, jcm, patches, Kaustubh Gondkar
Hi,
On 01/05/2016 07:25 PM, Rameshwar Sahu wrote:
> Hi Ulf,
>
> On Wed, Dec 23, 2015 at 6:59 PM, Rameshswar Prasad Sahu <rsahu@apm.com> wrote:
>> From: Rameshwar Prasad Sahu <rsahu@apm.com>
>>
>> The Arason SD host controller supports set block count command (cmd23)
>> and high speed mode. This patch re-enable both of these features that
>> was disabled. For device that doesn't support high speed, it should
>> configure its capability register accordingly instead disables it
>> explicitly.
>>
>> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
>> ---
>> drivers/mmc/host/sdhci-of-arasan.c | 5 -----
>> 1 files changed, 0 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index 75379cb..5d9fdb3 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>> goto clk_disable_all;
>> }
>>
>> - if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
>> - host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
>> - host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
I'm not sure what's correct since i didn't have any information for arasan.
But in case of exynos, SDHCI_QUIRK_NO_HISPD_BIT is used because that bit is used as other purpose.
If your SoC is not used anymore, i think this patch looks good.
Best Regards,
Jaehoon Chung
>> - }
>> -
>> sdhci_get_of_property(pdev);
>> pltfm_host = sdhci_priv(host);
>> pltfm_host->priv = sdhci_arasan;
>> --
>> 1.7.1
>>
>
> Any comment on this patch ??
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a
2016-01-07 1:33 ` Jaehoon Chung
@ 2016-01-07 12:32 ` Rameshwar Sahu
0 siblings, 0 replies; 6+ messages in thread
From: Rameshwar Sahu @ 2016-01-07 12:32 UTC (permalink / raw)
To: Jaehoon Chung
Cc: Ulf Hansson, michal.simek, soren.brinkmann, linux-mmc,
Arnd Bergmann, linux-kernel, devicetree, linux-arm-kernel, jcm,
patches, Kaustubh Gondkar
Hi Jaehoon,
On Thu, Jan 7, 2016 at 7:03 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi,
>
> On 01/05/2016 07:25 PM, Rameshwar Sahu wrote:
>> Hi Ulf,
>>
>> On Wed, Dec 23, 2015 at 6:59 PM, Rameshswar Prasad Sahu <rsahu@apm.com> wrote:
>>> From: Rameshwar Prasad Sahu <rsahu@apm.com>
>>>
>>> The Arason SD host controller supports set block count command (cmd23)
>>> and high speed mode. This patch re-enable both of these features that
>>> was disabled. For device that doesn't support high speed, it should
>>> configure its capability register accordingly instead disables it
>>> explicitly.
>>>
>>> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
>>> ---
>>> drivers/mmc/host/sdhci-of-arasan.c | 5 -----
>>> 1 files changed, 0 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>>> index 75379cb..5d9fdb3 100644
>>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>>> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>>> goto clk_disable_all;
>>> }
>>>
>>> - if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
>>> - host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
>>> - host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
>
> I'm not sure what's correct since i didn't have any information for arasan.
> But in case of exynos, SDHCI_QUIRK_NO_HISPD_BIT is used because that bit is used as other purpose.
> If your SoC is not used anymore, i think this patch looks good.
Our SoC doesn't need that bit, that's why we are going to remove it.
>
> Best Regards,
> Jaehoon Chung
>
>>> - }
>>> -
>>> sdhci_get_of_property(pdev);
>>> pltfm_host = sdhci_priv(host);
>>> pltfm_host->priv = sdhci_arasan;
>>> --
>>> 1.7.1
>>>
>>
>> Any comment on this patch ??
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a
2015-12-23 13:29 [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a Rameshswar Prasad Sahu
2016-01-05 10:25 ` Rameshwar Sahu
@ 2016-01-27 14:15 ` Ulf Hansson
1 sibling, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2016-01-27 14:15 UTC (permalink / raw)
To: Rameshswar Prasad Sahu
Cc: Michal Simek, Sören Brinkmann, linux-mmc, Arnd Bergmann,
linux-kernel, devicetree, linux-arm-kernel, Jon Masters, patches,
kgondkar
On 23 December 2015 at 14:29, Rameshswar Prasad Sahu <rsahu@apm.com> wrote:
> From: Rameshwar Prasad Sahu <rsahu@apm.com>
>
> The Arason SD host controller supports set block count command (cmd23)
> and high speed mode. This patch re-enable both of these features that
> was disabled. For device that doesn't support high speed, it should
> configure its capability register accordingly instead disables it
> explicitly.
>
> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 75379cb..5d9fdb3 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> goto clk_disable_all;
> }
>
> - if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
> - host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
> - host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> - }
> -
> sdhci_get_of_property(pdev);
> pltfm_host = sdhci_priv(host);
> pltfm_host->priv = sdhci_arasan;
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a
@ 2015-12-22 13:20 Rameshwar Prasad Sahu
0 siblings, 0 replies; 6+ messages in thread
From: Rameshwar Prasad Sahu @ 2015-12-22 13:20 UTC (permalink / raw)
To: ulf.hansson, michal.simek, soren.brinkmann
Cc: linux-mmc, arnd, linux-kernel, devicetree, linux-arm-kernel, jcm,
patches, kgondkar, Rameshwar Prasad Sahu
The Arason SD host controller supports set block count command (cmd23)
and high speed mode. This patch re-enable both of these features that
was disabled. For device that doesn't support high speed, it should
configure its capability register accordingly instead disables it
explicitly.
Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 75379cb..5d9fdb3 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
goto clk_disable_all;
}
- if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
- host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
- host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
- }
-
sdhci_get_of_property(pdev);
pltfm_host = sdhci_priv(host);
pltfm_host->priv = sdhci_arasan;
--
1.7.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-27 14:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-23 13:29 [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a Rameshswar Prasad Sahu
2016-01-05 10:25 ` Rameshwar Sahu
2016-01-07 1:33 ` Jaehoon Chung
2016-01-07 12:32 ` Rameshwar Sahu
2016-01-27 14:15 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2015-12-22 13:20 Rameshwar Prasad Sahu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome