* Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list
[not found] <1452206137-12441-1-git-send-email-mike.kravetz@oracle.com>
@ 2016-01-07 23:13 ` Andrew Morton
2016-01-07 23:51 ` Mike Kravetz
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2016-01-07 23:13 UTC (permalink / raw)
To: Mike Kravetz
Cc: linux-kernel, linux-mm, Hillf Danton, Hugh Dickins,
Naoya Horiguchi, Davidlohr Bueso, Dave Hansen, stable
On Thu, 7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine.
> The argument end is of type pgoff_t. It was being converted to a
> vaddr offset and passed to unmap_hugepage_range. However, end
> was also being used as an argument to the vma_interval_tree_foreach
> controlling loop. In addition, the conversion of end to vaddr offset
> was incorrect.
Could we please have a description of the user-visible effects of the
bug? It's always needed for -stable things. And for all bugfixes, really.
(stable@vger.kernel.org[4.3] isn't an email address btw - my client barfed)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list
2016-01-07 23:13 ` [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list Andrew Morton
@ 2016-01-07 23:51 ` Mike Kravetz
0 siblings, 0 replies; 2+ messages in thread
From: Mike Kravetz @ 2016-01-07 23:51 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-kernel, linux-mm, Hillf Danton, Hugh Dickins,
Naoya Horiguchi, Davidlohr Bueso, Dave Hansen, stable
On 01/07/2016 03:13 PM, Andrew Morton wrote:
> On Thu, 7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine.
>> The argument end is of type pgoff_t. It was being converted to a
>> vaddr offset and passed to unmap_hugepage_range. However, end
>> was also being used as an argument to the vma_interval_tree_foreach
>> controlling loop. In addition, the conversion of end to vaddr offset
>> was incorrect.
>
> Could we please have a description of the user-visible effects of the
> bug? It's always needed for -stable things. And for all bugfixes, really.
>
> (stable@vger.kernel.org[4.3] isn't an email address btw - my client barfed)
Will do.
As I stare at the code to come up with user visible effects, I am not
convinced the fix is correct. An update will come after more study.
--
Mike Kravetz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-07 23:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1452206137-12441-1-git-send-email-mike.kravetz@oracle.com>
2016-01-07 23:13 ` [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list Andrew Morton
2016-01-07 23:51 ` Mike Kravetz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome