From: K Prateek Nayak <kprateek.nayak@amd.com>
To: "Chen, Yu C" <yu.c.chen@intel.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrea Righi <arighi@nvidia.com>, Len Brown <lenb@kernel.org>,
<ricardo.neri@intel.com>, <linux-kernel@vger.kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Tim C Chen <tim.c.chen@linux.intel.com>,
Valentin Schneider <vschneid@redhat.com>,
Christian Loehle <christian.loehle@arm.com>,
Barry Song <baohua@kernel.org>
Subject: Re: [PATCH v4 1/6] sched/fair: Do not skip CPUs of similar capacity with busy SMT siblings
Date: Tue, 9 Jun 2026 11:59:00 +0530 [thread overview]
Message-ID: <56c534bb-a96d-45f7-ac31-1a5234271ba8@amd.com> (raw)
In-Reply-To: <32d47573-75fd-4a8f-aefb-ce7fb1136346@intel.com>
Hello Chenyu,
On 6/9/2026 11:54 AM, Chen, Yu C wrote:
>>> @@ -12964,8 +12965,12 @@ static struct rq *sched_balance_find_src_rq(struct lb_env *env,
>>> * eventually lead to active_balancing high->low capacity.
>>> * Higher per-CPU capacity is considered better than balancing
>>> * average load.
>>> + *
>>> + * Busy SMT siblings reduce the capacity of CPU i. Do not skip
>>> + * it in this case.
>>> */
>>> if (env->sd->flags & SD_ASYM_CPUCAPACITY &&
>>
>> ...
>>
>> if (asym_balance) {
>> /* Busy SMT reduces capacity */
>> if (sched_smt_active() && !is_core_idle(i))
>> continue;
>
> We might not want to skip i if it has SMT busy siblings?
> if ((!sched_smt_active() || is_core_idle(i)) && ...
Ah yes! I forgot to do the ! of the condition :-)
Thank you for the correction.
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-06-09 6:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 12:57 [PATCH v4 0/6] sched: Fix cluster scheduling in the presence of asymmetric capacity Ricardo Neri
2026-06-08 12:57 ` [PATCH v4 1/6] sched/fair: Do not skip CPUs of similar capacity with busy SMT siblings Ricardo Neri
2026-06-08 13:50 ` Christian Loehle
2026-06-10 3:32 ` Ricardo Neri
2026-06-09 4:26 ` K Prateek Nayak
2026-06-09 6:24 ` Chen, Yu C
2026-06-09 6:29 ` K Prateek Nayak [this message]
2026-06-10 3:29 ` Ricardo Neri
2026-06-08 12:57 ` [PATCH v4 2/6] sched/fair: Also gate overloaded status update for SD_ASYM_CPUCAPACITY Ricardo Neri
2026-06-08 12:57 ` [PATCH v4 3/6] sched/fair: Check CPU capacity before comparing group types during load balance Ricardo Neri
2026-06-08 12:57 ` [PATCH v4 4/6] sched/fair: Skip misfit load accounting when the destination CPU cannot help Ricardo Neri
2026-06-08 12:57 ` [PATCH v4 5/6] sched/fair: Allow load balancing between CPUs of identical capacity Ricardo Neri
2026-06-08 12:57 ` [PATCH v4 6/6] sched/topology: Do not clear SD_PREFER_SIBLING in domains with clusters Ricardo Neri
2026-06-08 17:37 ` [PATCH v4 0/6] sched: Fix cluster scheduling in the presence of asymmetric capacity Christian Loehle
2026-06-09 3:19 ` Ricardo Neri
2026-06-09 20:09 ` Christian Loehle
2026-06-10 3:28 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56c534bb-a96d-45f7-ac31-1a5234271ba8@amd.com \
--to=kprateek.nayak@amd.com \
--cc=arighi@nvidia.com \
--cc=baohua@kernel.org \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®