From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Renjiang Han <quic_renjiang@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: [PATCH v8 0/3] media: venus: enable venus on qcs615
Date: Thu, 5 Jun 2025 13:34:31 +0100 [thread overview]
Message-ID: <5854a587-aba7-4e71-87f8-249ba00cbc59@linaro.org> (raw)
In-Reply-To: <285cae4a-219c-4514-818f-34c8225529de@quicinc.com>
On 31/05/2025 01:05, Renjiang Han wrote:
>>>
>>> Note:
>>> This series consist of DT patches and a venus driver patch. The patch
>>> 1/3, which is venus driver patch, can be picked independently without
>>> having any functional dependency. But patch 2/3 & patch 3/3, which are
>>> DT patches, still depend on [1].
>> I'd say 2/3 and 3/3 still depend on 1/3, otherwise we can get video core
>> on QCS615 over(?)clocked.
> Agree, so we need to make sure that the driver patch is not picked after
> the DT patch.
This statement is confusing.
1/3 states that there will be a fallback if there is no OPP table present.
Giving the code a glance, I believe that is so, freq_table should be
used if there is no OPP specified in the DT.
I think we are having a hard time here understanding what you are saying.
My understanding:
- venus modification is standalone 1/3
Qcs615 will fallback if no OPP is present
- dt modification 2/3 3/3 is therefore also independent of driver
---
bod
next prev parent reply other threads:[~2025-06-05 12:34 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 4:02 Renjiang Han
2025-05-30 4:02 ` [PATCH v8 1/3] media: venus: pm_helpers: use opp-table for the frequency Renjiang Han
2025-05-30 20:26 ` Dmitry Baryshkov
2025-06-03 2:31 ` Renjiang Han
2025-05-31 11:11 ` Konrad Dybcio
2025-06-06 7:12 ` Renjiang Han
2025-05-30 4:02 ` [PATCH v8 2/3] arm64: dts: qcom: qcs615: add venus node to devicetree Renjiang Han
2025-05-30 10:51 ` Konrad Dybcio
2025-05-30 4:02 ` [PATCH v8 3/3] arm64: dts: qcom: qcs615-ride: enable venus node to initialize video codec Renjiang Han
2025-05-30 20:31 ` Dmitry Baryshkov
2025-05-31 0:07 ` Renjiang Han
2025-06-02 6:14 ` Dmitry Baryshkov
2025-05-30 12:52 ` [PATCH v8 0/3] media: venus: enable venus on qcs615 Rob Herring (Arm)
2025-05-30 20:27 ` Dmitry Baryshkov
2025-05-31 0:05 ` Renjiang Han
2025-06-02 6:16 ` Dmitry Baryshkov
2025-06-05 11:24 ` Renjiang Han
2025-06-05 11:46 ` Dmitry Baryshkov
2025-06-05 12:13 ` Krzysztof Kozlowski
2025-06-05 12:30 ` Dmitry Baryshkov
2025-06-05 12:33 ` Krzysztof Kozlowski
2025-06-05 12:40 ` Bryan O'Donoghue
2025-06-05 16:02 ` Dmitry Baryshkov
2025-06-05 16:39 ` Bryan O'Donoghue
2025-06-05 16:40 ` Dmitry Baryshkov
2025-06-05 17:12 ` Krzysztof Kozlowski
2025-06-05 17:13 ` Dmitry Baryshkov
2025-06-06 3:52 ` Renjiang Han
2025-06-06 7:51 ` Renjiang Han
2025-06-06 7:54 ` Krzysztof Kozlowski
2025-06-07 2:08 ` Dmitry Baryshkov
2025-06-05 12:34 ` Bryan O'Donoghue [this message]
2025-06-06 12:37 ` Renjiang Han
2025-06-06 12:44 ` Krzysztof Kozlowski
2025-06-06 12:51 ` Renjiang Han
2025-06-06 12:56 ` Krzysztof Kozlowski
2025-06-06 13:32 ` Renjiang Han
2025-06-06 14:53 ` Bryan O'Donoghue
2025-06-06 15:35 ` Vikash Garodia
2025-06-07 2:13 ` Dmitry Baryshkov
2025-06-07 2:31 ` Renjiang Han
2025-06-07 9:16 ` Bryan O'Donoghue
2025-06-07 10:32 ` Dmitry Baryshkov
2025-06-07 9:46 ` Krzysztof Kozlowski
2025-06-11 15:06 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5854a587-aba7-4e71-87f8-249ba00cbc59@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=quic_dikshita@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®