From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Renjiang Han <quic_renjiang@quicinc.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: [PATCH v8 0/3] media: venus: enable venus on qcs615
Date: Thu, 5 Jun 2025 14:33:04 +0200 [thread overview]
Message-ID: <b710e357-09e3-460e-b097-28cf0c856aeb@kernel.org> (raw)
In-Reply-To: <CAO9ioeWkLu+ne18kjEST7YU7b1aBzcMBBeyfpagzis99BAeOHg@mail.gmail.com>
On 05/06/2025 14:30, Dmitry Baryshkov wrote:
> On Thu, 5 Jun 2025 at 13:13, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 02/06/2025 08:16, Dmitry Baryshkov wrote:
>>> On Sat, May 31, 2025 at 08:05:24AM +0800, Renjiang Han wrote:
>>>>
>>>> On 5/31/2025 4:27 AM, Dmitry Baryshkov wrote:
>>>>> On Fri, May 30, 2025 at 09:32:12AM +0530, Renjiang Han wrote:
>>>>>> QCS615 uses the same video core as SC7180, so reuse the same resource
>>>>>> data of SC7180 for QCS615 to enable video functionality.
>>>>>>
>>>>>> There are no resources for the video-decoder and video-encoder nodes
>>>>>> in the device tree, so remove these two nodes from the device tree. In
>>>>>> addition, to ensure that the video codec functions properly, use [3]
>>>>>> to add encoder and decoder node entries in the venus driver.
>>>>>>
>>>>>> Validated this series on QCS615 and SC7180.
>>>>>>
>>>>>> Note:
>>>>>> This series consist of DT patches and a venus driver patch. The patch
>>>>>> 1/3, which is venus driver patch, can be picked independently without
>>>>>> having any functional dependency. But patch 2/3 & patch 3/3, which are
>>>>>> DT patches, still depend on [1].
>>>>> I'd say 2/3 and 3/3 still depend on 1/3, otherwise we can get video core
>>>>> on QCS615 over(?)clocked.
>>>> Agree, so we need to make sure that the driver patch is not picked after the
>>>> DT patch.
>>>
>>> Worse: we need to make sure that the driver patch is present in the
>>> branch which picks up DT patches. Otherwise building & testing that
>>
>>
>> Well, that's a NAK then (although depends what you mean by DT).
>
> I mean qcs615.dtsi. I'd suggest an immutable branch for the driver
Sorry, but no, DTS cannot depend on drivers. You CANNOT merge them into
one branch.
> patch. Or just merging the patches in two consequent releases.
That's a new device nodes, new hardware so it should not be blocked by
any driver patch. This is just totally broken process / patchset / work.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-05 12:33 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 4:02 Renjiang Han
2025-05-30 4:02 ` [PATCH v8 1/3] media: venus: pm_helpers: use opp-table for the frequency Renjiang Han
2025-05-30 20:26 ` Dmitry Baryshkov
2025-06-03 2:31 ` Renjiang Han
2025-05-31 11:11 ` Konrad Dybcio
2025-06-06 7:12 ` Renjiang Han
2025-05-30 4:02 ` [PATCH v8 2/3] arm64: dts: qcom: qcs615: add venus node to devicetree Renjiang Han
2025-05-30 10:51 ` Konrad Dybcio
2025-05-30 4:02 ` [PATCH v8 3/3] arm64: dts: qcom: qcs615-ride: enable venus node to initialize video codec Renjiang Han
2025-05-30 20:31 ` Dmitry Baryshkov
2025-05-31 0:07 ` Renjiang Han
2025-06-02 6:14 ` Dmitry Baryshkov
2025-05-30 12:52 ` [PATCH v8 0/3] media: venus: enable venus on qcs615 Rob Herring (Arm)
2025-05-30 20:27 ` Dmitry Baryshkov
2025-05-31 0:05 ` Renjiang Han
2025-06-02 6:16 ` Dmitry Baryshkov
2025-06-05 11:24 ` Renjiang Han
2025-06-05 11:46 ` Dmitry Baryshkov
2025-06-05 12:13 ` Krzysztof Kozlowski
2025-06-05 12:30 ` Dmitry Baryshkov
2025-06-05 12:33 ` Krzysztof Kozlowski [this message]
2025-06-05 12:40 ` Bryan O'Donoghue
2025-06-05 16:02 ` Dmitry Baryshkov
2025-06-05 16:39 ` Bryan O'Donoghue
2025-06-05 16:40 ` Dmitry Baryshkov
2025-06-05 17:12 ` Krzysztof Kozlowski
2025-06-05 17:13 ` Dmitry Baryshkov
2025-06-06 3:52 ` Renjiang Han
2025-06-06 7:51 ` Renjiang Han
2025-06-06 7:54 ` Krzysztof Kozlowski
2025-06-07 2:08 ` Dmitry Baryshkov
2025-06-05 12:34 ` Bryan O'Donoghue
2025-06-06 12:37 ` Renjiang Han
2025-06-06 12:44 ` Krzysztof Kozlowski
2025-06-06 12:51 ` Renjiang Han
2025-06-06 12:56 ` Krzysztof Kozlowski
2025-06-06 13:32 ` Renjiang Han
2025-06-06 14:53 ` Bryan O'Donoghue
2025-06-06 15:35 ` Vikash Garodia
2025-06-07 2:13 ` Dmitry Baryshkov
2025-06-07 2:31 ` Renjiang Han
2025-06-07 9:16 ` Bryan O'Donoghue
2025-06-07 10:32 ` Dmitry Baryshkov
2025-06-07 9:46 ` Krzysztof Kozlowski
2025-06-11 15:06 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b710e357-09e3-460e-b097-28cf0c856aeb@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=quic_dikshita@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®