Re: [PATCH v8 0/3] media: venus: enable venus on qcs615

[Renjiang Han <quic_renjiang@quicinc.com>]

On 6/6/2025 11:52 AM, Renjiang Han wrote:
>
> On 6/5/2025 8:40 PM, Bryan O'Donoghue wrote:
>>>>> Well, that's a NAK then (although depends what you mean by DT).
>>>>
>>>> I mean qcs615.dtsi. I'd suggest an immutable branch for the driver
>>>
>>> Sorry, but no, DTS cannot depend on drivers. You CANNOT merge them into
>>> one branch.
>>>
>>>> patch. Or just merging the patches in two consequent releases.
>>>
>>> That's a new device nodes, new hardware so it should not be blocked by
>>> any driver patch. This is just totally broken process / patchset / 
>>> work.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Reading this thread, I don't think that is the case.
>>
>> I don't see how patches 2/3 or 3/3 depend on 1/3.
>>
>> The frequency table is a fallback in the driver and the DT changes 
>> are completely straight forward.
>>
>> TBH, I think we are hitting an email comms/social barrier here, not a 
>> technical one.
>>
>> @Renjiang can you please confirm that freq_table is a fallback, 
>> qcs615 will work without OPP table and the DTS stuff doesn't depend 
>> on the driver.
> yes, freq_table is a fallback. driver will use freq_table without OPP 
> table. the DTS doesn't depend on the driver.
To correct my previous response:
For this project, the driver patch needs to be merged first. Since it
falls back to SC7180, but their frequencies are different which is
reflected in the OPP table defined in the DTS.

The DTS patch is intended to enable video function on the QCS615 platform.

The driver patch is to switch from using the driver freq_table to the
OPP table from the DTS. Without it, the driver will continue to use the
internal freq_table as before.

Therefore, if the DTS patch is applied without the driver patch, the video
function will be enabled on the QCS615 platform, but the driver will use
the SC7180 frequency table, which can lead to an overclocking issue.
>>
>> TBH, I don't see how the DTS can or should but...
>>
>> ---
>> bod 
>
-- 
Best Regards,
Renjiang