* [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup()
@ 2026-11-18 9:29 Vítor Hugo Silva
2026-11-19 16:49 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Vítor Hugo Silva @ 2026-11-18 9:29 UTC (permalink / raw)
To: linux; +Cc: linux-hwmon, linux-kernel, Vítor Hugo Silva
The ads7871 probe() ignores the spi_setup() error return value
and it attempts to write to registers even if spi_setup() fails.
Return the setup error before accessing any registers.
AI was used for peer-review the patch.
Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
---
Changes in v2:
- Clarify what happens when spi_setup() fails.
- Describe the fix in imperative mood.
drivers/hwmon/ads7871.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
index 36297bc6d047..a1ffc35d9272 100644
--- a/drivers/hwmon/ads7871.c
+++ b/drivers/hwmon/ads7871.c
@@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
/* Configure the SPI bus */
spi->mode = (SPI_MODE_0);
spi->bits_per_word = 8;
- spi_setup(spi);
+ ret = spi_setup(spi);
+ if (ret)
+ return ret;
pdata = devm_kzalloc_obj(dev, *pdata);
if (!pdata)
--
2.56.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup()
2026-11-18 9:29 [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup() Vítor Hugo Silva
@ 2026-11-19 16:49 ` Guenter Roeck
2026-11-19 17:08 ` Vítor Silva
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2026-11-19 16:49 UTC (permalink / raw)
To: Vítor Hugo Silva; +Cc: linux-hwmon, linux-kernel
On Wed, Nov 18, 2026 at 09:29:28AM +0000, Vítor Hugo Silva wrote:
> The ads7871 probe() ignores the spi_setup() error return value
> and it attempts to write to registers even if spi_setup() fails.
>
> Return the setup error before accessing any registers.
>
> AI was used for peer-review the patch.
>
> Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
>
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
Applied.
Thanks,
Guenter
> ---
> Changes in v2:
> - Clarify what happens when spi_setup() fails.
> - Describe the fix in imperative mood.
>
> drivers/hwmon/ads7871.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
> index 36297bc6d047..a1ffc35d9272 100644
> --- a/drivers/hwmon/ads7871.c
> +++ b/drivers/hwmon/ads7871.c
> @@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
> /* Configure the SPI bus */
> spi->mode = (SPI_MODE_0);
> spi->bits_per_word = 8;
> - spi_setup(spi);
> + ret = spi_setup(spi);
> + if (ret)
> + return ret;
>
> pdata = devm_kzalloc_obj(dev, *pdata);
> if (!pdata)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup()
2026-11-19 16:49 ` Guenter Roeck
@ 2026-11-19 17:08 ` Vítor Silva
0 siblings, 0 replies; 3+ messages in thread
From: Vítor Silva @ 2026-11-19 17:08 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel
Thanks!
Vítor
Guenter Roeck <linux@roeck-us.net> escreveu (quinta, 19/11/2026 à(s) 16:49):
>
> On Wed, Nov 18, 2026 at 09:29:28AM +0000, Vítor Hugo Silva wrote:
> > The ads7871 probe() ignores the spi_setup() error return value
> > and it attempts to write to registers even if spi_setup() fails.
> >
> > Return the setup error before accessing any registers.
> >
> > AI was used for peer-review the patch.
> >
> > Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
> >
> > Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
>
> Applied.
>
> Thanks,
> Guenter
>
> > ---
> > Changes in v2:
> > - Clarify what happens when spi_setup() fails.
> > - Describe the fix in imperative mood.
> >
> > drivers/hwmon/ads7871.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
> > index 36297bc6d047..a1ffc35d9272 100644
> > --- a/drivers/hwmon/ads7871.c
> > +++ b/drivers/hwmon/ads7871.c
> > @@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
> > /* Configure the SPI bus */
> > spi->mode = (SPI_MODE_0);
> > spi->bits_per_word = 8;
> > - spi_setup(spi);
> > + ret = spi_setup(spi);
> > + if (ret)
> > + return ret;
> >
> > pdata = devm_kzalloc_obj(dev, *pdata);
> > if (!pdata)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-19 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 9:29 [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup() Vítor Hugo Silva
2026-11-19 16:49 ` Guenter Roeck
2026-11-19 17:08 ` Vítor Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®