* [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove
@ 2017-10-19 21:18 frowand.list
2017-10-19 21:49 ` Frank Rowand
2017-10-19 22:13 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: frowand.list @ 2017-10-19 21:18 UTC (permalink / raw)
To: Rob Herring, atull, pantelis.antoniou, Pantelis Antoniou
Cc: devicetree, linux-kernel
From: Frank Rowand <frank.rowand@sony.com>
A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
or an embedded errno. overlay_notify() incorrectly reports an
error for NOTIFY_OK.
Reported-by: atull@kernel.org
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
drivers/of/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index c99842bb4b09..f5fce0fea40b 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
ret = blocking_notifier_call_chain(&overlay_notify_chain,
action, &nd);
- if (ret == NOTIFY_STOP)
+ if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
return 0;
if (ret) {
ret = notifier_to_errno(ret);
--
Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove
2017-10-19 21:18 [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove frowand.list
@ 2017-10-19 21:49 ` Frank Rowand
2017-10-19 22:13 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Frank Rowand @ 2017-10-19 21:49 UTC (permalink / raw)
To: Rob Herring, atull, pantelis.antoniou, Pantelis Antoniou
Cc: devicetree, linux-kernel
On 10/19/17 14:18, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
> or an embedded errno. overlay_notify() incorrectly reports an
> error for NOTIFY_OK.
>
> Reported-by: atull@kernel.org
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/overlay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index c99842bb4b09..f5fce0fea40b 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
>
> ret = blocking_notifier_call_chain(&overlay_notify_chain,
> action, &nd);
> - if (ret == NOTIFY_STOP)
> + if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
> return 0;
> if (ret) {
> ret = notifier_to_errno(ret);
>
Not needed in any stable kernel. This is caused by
"[PATCH v3 00/12] of: overlay: clean up device tree overlay code".
-Frank
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove
2017-10-19 21:18 [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove frowand.list
2017-10-19 21:49 ` Frank Rowand
@ 2017-10-19 22:13 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2017-10-19 22:13 UTC (permalink / raw)
To: Frank Rowand
Cc: Alan Tull, Pantelis Antoniou, Pantelis Antoniou, devicetree,
linux-kernel
On Thu, Oct 19, 2017 at 4:18 PM, <frowand.list@gmail.com> wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
> or an embedded errno. overlay_notify() incorrectly reports an
> error for NOTIFY_OK.
>
> Reported-by: atull@kernel.org
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/overlay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-19 22:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-19 21:18 [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove frowand.list
2017-10-19 21:49 ` Frank Rowand
2017-10-19 22:13 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome