From: Ping-Ke Shih <pkshih@realtek.com>
To: Rishik Yechuri <epicrishik@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rishik Yechuri <rishik.yechuri.code@gmail.com>
Subject: RE: [PATCH rtw-next 5/6] wifi: rtlwifi: use ieee80211_is_ctl() instead of WLAN_FC_GET_TYPE()
Date: Tue, 17 Nov 2026 02:44:42 +0000 [thread overview]
Message-ID: <5a469b9bb1e3450c93899dbe1e503170@realtek.com> (raw)
In-Reply-To: <20261110184409.42205-6-rishik.yechuri.code@gmail.com>
Rishik Yechuri <epicrishik@gmail.com> wrote:
> Six RX status parsers read the frame type with WLAN_FC_GET_TYPE() from
> wifi.h only to compare it against IEEE80211_FTYPE_CTL.
> ieee80211_is_ctl() from <linux/ieee80211.h> does that test directly on
> the little endian frame control.
>
> Use it at the six sites, drop the type variables that only held the
> result, and remove WLAN_FC_GET_TYPE() together with WLAN_FC_GET_VERS(),
> WLAN_FC_GET_STYPE() and WLAN_FC_MORE_DATA(), which have no users.
Please reword your commit messages.
The subject has pointed out the key point. No need much verbose
messages generated by LLM.
next prev parent reply other threads:[~2026-11-17 2:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 18:44 [PATCH rtw-next 0/6] wifi: rtlwifi: replace the 802.11 header helper macros with kernel ones Rishik Yechuri
2026-11-10 18:44 ` [PATCH rtw-next 1/6] wifi: rtlwifi: use struct ieee80211_pspoll for the PS Poll reserved page Rishik Yechuri
2026-11-17 2:18 ` Ping-Ke Shih
2026-11-10 18:44 ` [PATCH rtw-next 2/6] wifi: rtlwifi: use struct ieee80211_hdr for the reserved page headers Rishik Yechuri
2026-11-17 2:24 ` Ping-Ke Shih
2026-11-10 18:44 ` [PATCH rtw-next 3/6] wifi: rtlwifi: call msecs_to_jiffies() directly Rishik Yechuri
2026-11-17 2:34 ` Ping-Ke Shih
2026-11-10 18:44 ` [PATCH rtw-next 4/6] wifi: rtlwifi: rtl8192se: use ALIGN() for the H2C command length Rishik Yechuri
2026-11-17 2:41 ` Ping-Ke Shih
2026-11-10 18:44 ` [PATCH rtw-next 5/6] wifi: rtlwifi: use ieee80211_is_ctl() instead of WLAN_FC_GET_TYPE() Rishik Yechuri
2026-11-17 2:44 ` Ping-Ke Shih [this message]
2026-11-10 18:44 ` [PATCH rtw-next 6/6] wifi: rtlwifi: remove byte(), packet_get_type() and FILL_OCTET_STRING() Rishik Yechuri
2026-11-17 2:48 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a469b9bb1e3450c93899dbe1e503170@realtek.com \
--to=pkshih@realtek.com \
--cc=epicrishik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rishik.yechuri.code@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®