[PATCH 0/4] arm64 defconfig: enable additional led triggers

[PATCH 0/4] arm64 defconfig: enable additional led triggers

[Amit Kucheria]

This patchset enables the kernel panic and disk-activity trigger for LEDs and
then enables the panic trigger for three 96Boards - DB410c, Hikey and Hikey960.

DB410c and Hikey panic behaviour has been tested by triggering a panic through
/proc/sysrq-trigger, while Hikey960 is only compile-tested.

Amit Kucheria (4):
  arm64: defconfig: enable new trigger modes for leds
  arm64: dts: qcom: apq8016-sbc: Allow USR4 LED to notify kernel panic
  arm64: dts: hisilicon: hi6220-hikey: Allow USR1 LED to notify kernel
    panic
  arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify
    kernel panic

 arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 +
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts    | 1 +
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi         | 1 +
 arch/arm64/configs/defconfig                      | 2 ++
 4 files changed, 5 insertions(+)

-- 
2.7.4

[PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

[Amit Kucheria]

Enable panic and disk activity triggers to tie to LED activity

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 34480e9..4ed357f 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -460,6 +460,8 @@ CONFIG_LEDS_SYSCON=y
 CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_LEDS_TRIGGER_CPU=y
 CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
+CONFIG_LEDS_TRIGGER_PANIC=y
+CONFIG_LEDS_TRIGGER_DISK=y
 CONFIG_EDAC=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
-- 
2.7.4

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

[Timur Tabi]

On 10/18/17 3:57 PM, Amit Kucheria wrote:
> Enable panic and disk activity triggers to tie to LED activity

Could you provide some explanation as to why we want this enabled for 
ARM64?  I don't have a problem with the change itself, but I think patch 
descriptions for defconfig changes should include justifications.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

[Amit Kucheria]

On Thu, Oct 19, 2017 at 8:54 PM, Timur Tabi <timur@codeaurora.org> wrote:
> On 10/18/17 3:57 PM, Amit Kucheria wrote:
>>
>> Enable panic and disk activity triggers to tie to LED activity
>
>
> Could you provide some explanation as to why we want this enabled for ARM64?
> I don't have a problem with the change itself, but I think patch
> descriptions for defconfig changes should include justifications.

Indeed.

The blurb should be modified as follows:

"Most development boards and devices have one or more LEDs. It is
useful during debugging if they can be wired to show different
behaviours such as disk or cpu activity or a load-average dependent
heartbeat. Enable panic and disk activity triggers so they can be tied
to LED activity during debugging as well."

If this blurb works, I'll send out another version.

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

[Timur Tabi]

On 10/22/2017 11:56 PM, Amit Kucheria wrote:
> 
> "Most development boards and devices have one or more LEDs. It is
> useful during debugging if they can be wired to show different
> behaviours such as disk or cpu activity or a load-average dependent
> heartbeat. Enable panic and disk activity triggers so they can be tied
> to LED activity during debugging as well."

This is great, thanks.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

[Amit Kucheria]

On Mon, Oct 23, 2017 at 8:54 PM, Timur Tabi <timur@codeaurora.org> wrote:
> On 10/22/2017 11:56 PM, Amit Kucheria wrote:
>>
>>
>> "Most development boards and devices have one or more LEDs. It is
>> useful during debugging if they can be wired to show different
>> behaviours such as disk or cpu activity or a load-average dependent
>> heartbeat. Enable panic and disk activity triggers so they can be tied
>> to LED activity during debugging as well."
>
>
> This is great, thanks.

Can I take this as an ACK?

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

[Timur Tabi]

On 10/23/17 6:11 PM, Amit Kucheria wrote:
>> This is great, thanks.
> Can I take this as an ACK?

Sure, but I'm not a maintainer for the defconfig, so it's just my 
personal opinion.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

[Manivannan Sadhasivam]

On 19 October 2017 at 02:27, Amit Kucheria <amit.kucheria@linaro.org> wrote:
> Enable panic and disk activity triggers to tie to LED activity
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Regards,
Mani
> ---
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 34480e9..4ed357f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -460,6 +460,8 @@ CONFIG_LEDS_SYSCON=y
>  CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>  CONFIG_LEDS_TRIGGER_CPU=y
>  CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
> +CONFIG_LEDS_TRIGGER_PANIC=y
> +CONFIG_LEDS_TRIGGER_DISK=y
>  CONFIG_EDAC=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_MAX77686=y
> --
> 2.7.4
>

[PATCH 2/4] arm64: dts: qcom: apq8016-sbc: Allow USR4 LED to notify kernel panic

[Amit Kucheria]

Blink the LED on a kernel panic.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 1d63e6b..e4a6850 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -174,6 +174,7 @@
 				label = "apq8016-sbc:green:user4";
 				gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
 				linux,default-trigger = "none";
+				panic-indicator;
 				default-state = "off";
 			};
 
-- 
2.7.4

[PATCH 3/4] arm64: dts: hisilicon: hi6220-hikey: Allow USR1 LED to notify kernel panic

[Amit Kucheria]

Blink the LED on a kernel panic.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 2b52630..c536403 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -358,6 +358,7 @@
 		user_led1 {
 			label = "user_led1";
 			gpios = <&gpio4 3 0>; /* <&gpio_user_led_4>; */
+			panic-indicator;
 			linux,default-trigger = "cpu0";
 		};
 
-- 
2.7.4

[PATCH 4/4] arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify kernel panic

[Amit Kucheria]

Blink the LED on a kernel panic.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index fd4705c..febbcb5 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -108,6 +108,7 @@
 			label = "user_led4";
 			/* gpio_190_user_led4 */
 			gpios = <&gpio23 6 0>;
+			panic-indicator;
 			linux,default-trigger = "cpu0";
 		};
 
-- 
2.7.4

Re: [PATCH 4/4] arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify kernel panic

[Amit Kucheria]

On Thu, Oct 19, 2017 at 5:30 PM, Guodong Xu <guodong.xu@linaro.org> wrote:
>
>
> On Thu, Oct 19, 2017 at 4:57 AM, Amit Kucheria <amit.kucheria@linaro.org>
> wrote:
>>
>> Blink the LED on a kernel panic.
>>
>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> index fd4705c..febbcb5 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> @@ -108,6 +108,7 @@
>>                         label = "user_led4";
>>                         /* gpio_190_user_led4 */
>>                         gpios = <&gpio23 6 0>;
>> +                       panic-indicator;
>
>
> Looks good to me.

Can I take that as an Ack? How about the Hikey960 patch?

>
>
>>
>>                         linux,default-trigger = "cpu0";
>>                 };
>>
>> --
>> 2.7.4
>>
>

Re: [PATCH 4/4] arm64: dts: hisilicon: hi3660-hikey960: Allow USR4 LED to notify kernel panic

[Guodong Xu]

On Mon, Oct 23, 2017 at 12:43 PM, Amit Kucheria
<amit.kucheria@linaro.org> wrote:
> On Thu, Oct 19, 2017 at 5:30 PM, Guodong Xu <guodong.xu@linaro.org> wrote:
>>
>>
>> On Thu, Oct 19, 2017 at 4:57 AM, Amit Kucheria <amit.kucheria@linaro.org>
>> wrote:
>>>
>>> Blink the LED on a kernel panic.
>>>
>>> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
>>> ---
>>>  arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>> b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>> index fd4705c..febbcb5 100644
>>> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>> @@ -108,6 +108,7 @@
>>>                         label = "user_led4";
>>>                         /* gpio_190_user_led4 */
>>>                         gpios = <&gpio23 6 0>;
>>> +                       panic-indicator;
>>
>>
>> Looks good to me.
>
> Can I take that as an Ack? How about the Hikey960 patch?
>

Acked-by: Guodong Xu <guodong.xu@linaro.org>

-Guodong

>>
>>
>>>
>>>                         linux,default-trigger = "cpu0";
>>>                 };
>>>
>>> --
>>> 2.7.4
>>>
>>