From: Michal Luczaj <mhal@rbox.co>
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Shuah Khan <shuah@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Lorenz Bauer <lmb@cloudflare.com>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH bpf-next 2/3] bpf, sockmap: Restrict iter-context sockmap updates to iter/sockmap
Date: Mon, 19 Oct 2026 17:20:28 +0200 [thread overview]
Message-ID: <5b549646-90c8-4f60-9160-26adf328354d@rbox.co> (raw)
In-Reply-To: <874ieiey9c.fsf@cloudflare.com>
On 10/19/26 13:16, Jakub Sitnicki wrote:
> On Fri, Oct 16, 2026 at 11:09 PM +02, Michal Luczaj wrote:
>> @@ -10341,7 +10342,12 @@ static bool may_update_sockmap(struct bpf_verifier_env *env, int func_id)
>> */
>> switch (type) {
>> case BPF_PROG_TYPE_TRACING:
>> - if (eatype == BPF_TRACE_ITER)
>> + /* iter/sockmap only; type check rejects a freplace of any
>> + * iterator's bpf_iter_sockmap() subprog.
>> + */
>> + if (eatype == BPF_TRACE_ITER &&
>> + env->prog->type == BPF_PROG_TYPE_TRACING &&
>> + !strcmp(afname + strlen(BPF_ITER_FUNC_PREFIX), "sockmap"))
>> return true;
>> break;
>> case BPF_PROG_TYPE_SOCK_OPS:
>
> Explicit bailout when prog->type == BPF_PROG_TYPE_EXT might be more
> self-explanatory.
I just though that such explicit allow-criteria approach is safer than a
deny-criteria (should other special prog types come along). But I agree
that would be more self-explanatory.
next prev parent reply other threads:[~2026-10-19 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 21:09 [PATCH bpf-next 0/3] bpf, sockmap: Restrict iter-context sockmap updates to sockmap iterators Michal Luczaj
2026-10-16 21:09 ` [PATCH bpf-next 1/3] selftests/bpf: Remove sockmap update from bpf_iter_unix Michal Luczaj
2026-10-16 21:09 ` [PATCH bpf-next 2/3] bpf, sockmap: Restrict iter-context sockmap updates to iter/sockmap Michal Luczaj
2026-10-16 23:52 ` Alexei Starovoitov
2026-10-19 15:20 ` Michal Luczaj
2026-10-19 19:40 ` Alexei Starovoitov
2026-10-21 11:12 ` Michal Luczaj
2026-10-27 22:20 ` Michal Luczaj
2026-11-01 1:28 ` Alexei Starovoitov
2026-11-02 1:20 ` Michal Luczaj
2026-10-19 11:16 ` Jakub Sitnicki
2026-10-19 15:20 ` Michal Luczaj [this message]
2026-10-16 21:09 ` [PATCH bpf-next 3/3] selftests/bpf: Add negative test for sockmap update from non-sockmap iter Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b549646-90c8-4f60-9160-26adf328354d@rbox.co \
--to=mhal@rbox.co \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lmb@cloudflare.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=sashiko-bot@kernel.org \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®