From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Marco Crivellari <marco.crivellari@suse.com>,
<linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@kernel.org>, Michal Hocko <mhocko@suse.com>,
Aaron Tomlin <atomlin@atomlin.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Thomas Gleixner <tglx@kernel.org>
Subject: Re: [PATCH v2 2/4] sched/idle: Don't handle polling idle as dynticks idle
Date: Thu, 12 Nov 2026 08:57:58 +0530 [thread overview]
Message-ID: <5c8f7574-d480-45fe-b658-c705511fde61@amd.com> (raw)
In-Reply-To: <20261111114406.346953-3-marco.crivellari@suse.com>
Hello Marco,
On 11/11/2026 5:13 PM, Marco Crivellari wrote:
> void tick_nohz_idle_exit(void)
> {
> struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched);
> + unsigned long flags;
> ktime_t now;
>
> - local_irq_disable();
> + local_irq_save(flags);
nit.
Use:
guard(irqsave)();
and you can directly return for below condition. No "flags" or
"out" label needed.
> +
> + if (!tick_sched_flag_test(ts, TS_FLAG_INIDLE))
> + goto out;
>
> - WARN_ON_ONCE(!tick_sched_flag_test(ts, TS_FLAG_INIDLE));
> WARN_ON_ONCE(ts->timer_expires_base);
>
> tick_sched_flag_clear(ts, TS_FLAG_INIDLE);
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-11-12 3:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 11:43 [PATCH v2 0/4] Stop the idle tick on polling idle on nohz_full CPUs Marco Crivellari
2026-11-11 11:43 ` [PATCH v2 1/4] tick/nohz: Re-evaluate the tick on return to user space Marco Crivellari
2026-11-11 16:25 ` Frederic Weisbecker
2026-11-11 11:43 ` [PATCH v2 2/4] sched/idle: Don't handle polling idle as dynticks idle Marco Crivellari
2026-11-11 16:57 ` Frederic Weisbecker
2026-11-11 16:58 ` Peter Zijlstra
2026-11-12 3:27 ` K Prateek Nayak [this message]
2026-11-11 11:43 ` [PATCH v2 3/4] tick/nohz: Remove tick_nohz_idle_restart_tick() Marco Crivellari
2026-11-11 16:59 ` Frederic Weisbecker
2026-11-11 11:43 ` [PATCH v2 4/4] Documentation: no_hz: Add tick stop in polling idle Marco Crivellari
2026-11-11 17:00 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c8f7574-d480-45fe-b658-c705511fde61@amd.com \
--to=kprateek.nayak@amd.com \
--cc=anna-maria@linutronix.de \
--cc=atomlin@atomlin.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®