* [PATCH 0/3] net: remove redundant __GFP_NOWARN
@ 2025-08-10 7:29 Qianfeng Rong
2025-08-10 7:29 ` [PATCH 1/3] tcp: cdg: " Qianfeng Rong
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Qianfeng Rong @ 2025-08-10 7:29 UTC (permalink / raw)
To: Eric Dumazet, Neal Cardwell, Kuniyuki Iwashima, David S. Miller,
David Ahern, Jakub Kicinski, Paolo Abeni, Simon Horman,
Allison Henderson, Trond Myklebust, Anna Schumaker, Chuck Lever,
Jeff Layton, NeilBrown, Olga Kornievskaia, Dai Ngo, Tom Talpey,
Qianfeng Rong, open list:NETWORKING [TCP],
open list, open list:RDS - RELIABLE DATAGRAM SOCKETS,
moderated list:RDS - RELIABLE DATAGRAM SOCKETS, open list:NFS,
SUNRPC, AND LOCKD CLIENTS
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
GFP_NOWAIT implicitly include __GFP_NOWARN.
Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
`GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean up these
redundant flags across subsystems.
No functional changes.
Qianfeng Rong (3):
tcp: cdg: remove redundant __GFP_NOWARN
RDS: remove redundant __GFP_NOWARN
SUNRPC: Remove redundant __GFP_NOWARN
net/ipv4/tcp_cdg.c | 2 +-
net/rds/ib_recv.c | 2 +-
net/sunrpc/socklib.c | 2 +-
net/sunrpc/xprtrdma/rpc_rdma.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/3] tcp: cdg: remove redundant __GFP_NOWARN
2025-08-10 7:29 [PATCH 0/3] net: remove redundant __GFP_NOWARN Qianfeng Rong
@ 2025-08-10 7:29 ` Qianfeng Rong
2025-08-11 8:54 ` Eric Dumazet
2025-08-10 7:29 ` [PATCH 2/3] RDS: " Qianfeng Rong
2025-08-10 7:29 ` [PATCH 3/3] SUNRPC: Remove " Qianfeng Rong
2 siblings, 1 reply; 7+ messages in thread
From: Qianfeng Rong @ 2025-08-10 7:29 UTC (permalink / raw)
To: Eric Dumazet, Neal Cardwell, Kuniyuki Iwashima, David S. Miller,
David Ahern, Jakub Kicinski, Paolo Abeni, Simon Horman,
open list:NETWORKING [TCP],
open list
Cc: Qianfeng Rong
GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
__GFP_NOWARN.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
net/ipv4/tcp_cdg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_cdg.c b/net/ipv4/tcp_cdg.c
index ba4d98e510e0..fbad6c35dee9 100644
--- a/net/ipv4/tcp_cdg.c
+++ b/net/ipv4/tcp_cdg.c
@@ -379,7 +379,7 @@ static void tcp_cdg_init(struct sock *sk)
/* We silently fall back to window = 1 if allocation fails. */
if (window > 1)
ca->gradients = kcalloc(window, sizeof(ca->gradients[0]),
- GFP_NOWAIT | __GFP_NOWARN);
+ GFP_NOWAIT);
ca->rtt_seq = tp->snd_nxt;
ca->shadow_wnd = tcp_snd_cwnd(tp);
}
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] tcp: cdg: remove redundant __GFP_NOWARN
2025-08-10 7:29 ` [PATCH 1/3] tcp: cdg: " Qianfeng Rong
@ 2025-08-11 8:54 ` Eric Dumazet
0 siblings, 0 replies; 7+ messages in thread
From: Eric Dumazet @ 2025-08-11 8:54 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Neal Cardwell, Kuniyuki Iwashima, David S. Miller, David Ahern,
Jakub Kicinski, Paolo Abeni, Simon Horman,
open list:NETWORKING [TCP],
open list
On Sun, Aug 10, 2025 at 12:30 AM Qianfeng Rong <rongqianfeng@vivo.com> wrote:
>
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> net/ipv4/tcp_cdg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/tcp_cdg.c b/net/ipv4/tcp_cdg.c
> index ba4d98e510e0..fbad6c35dee9 100644
> --- a/net/ipv4/tcp_cdg.c
> +++ b/net/ipv4/tcp_cdg.c
> @@ -379,7 +379,7 @@ static void tcp_cdg_init(struct sock *sk)
> /* We silently fall back to window = 1 if allocation fails. */
> if (window > 1)
> ca->gradients = kcalloc(window, sizeof(ca->gradients[0]),
> - GFP_NOWAIT | __GFP_NOWARN);
> + GFP_NOWAIT);
Reviewed-by: Eric Dumazet <edumazet@google.com>
It is unclear why GFP_NOWAIT was used here, while all other TCP
allocations use GFP_ATOMIC or GFP_KERNEL.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] RDS: remove redundant __GFP_NOWARN
2025-08-10 7:29 [PATCH 0/3] net: remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-10 7:29 ` [PATCH 1/3] tcp: cdg: " Qianfeng Rong
@ 2025-08-10 7:29 ` Qianfeng Rong
2025-08-12 6:54 ` Allison Henderson
2025-08-10 7:29 ` [PATCH 3/3] SUNRPC: Remove " Qianfeng Rong
2 siblings, 1 reply; 7+ messages in thread
From: Qianfeng Rong @ 2025-08-10 7:29 UTC (permalink / raw)
To: Allison Henderson, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman,
open list:RDS - RELIABLE DATAGRAM SOCKETS,
open list:RDS - RELIABLE DATAGRAM SOCKETS,
moderated list:RDS - RELIABLE DATAGRAM SOCKETS, open list
Cc: Qianfeng Rong
GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
__GFP_NOWARN.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
net/rds/ib_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
index e53b7f266bd7..4248dfa816eb 100644
--- a/net/rds/ib_recv.c
+++ b/net/rds/ib_recv.c
@@ -1034,7 +1034,7 @@ void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic,
rds_ib_stats_inc(s_ib_rx_ring_empty);
if (rds_ib_ring_low(&ic->i_recv_ring)) {
- rds_ib_recv_refill(conn, 0, GFP_NOWAIT | __GFP_NOWARN);
+ rds_ib_recv_refill(conn, 0, GFP_NOWAIT);
rds_ib_stats_inc(s_ib_rx_refill_from_cq);
}
}
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] RDS: remove redundant __GFP_NOWARN
2025-08-10 7:29 ` [PATCH 2/3] RDS: " Qianfeng Rong
@ 2025-08-12 6:54 ` Allison Henderson
0 siblings, 0 replies; 7+ messages in thread
From: Allison Henderson @ 2025-08-12 6:54 UTC (permalink / raw)
To: linux-rdma, rongqianfeng, davem, rds-devel, linux-kernel, netdev,
horms, edumazet, kuba, pabeni
On Sun, 2025-08-10 at 15:29 +0800, Qianfeng Rong wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Looks pretty straight forward to me. Thanks Qianfeng.
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> net/rds/ib_recv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
> index e53b7f266bd7..4248dfa816eb 100644
> --- a/net/rds/ib_recv.c
> +++ b/net/rds/ib_recv.c
> @@ -1034,7 +1034,7 @@ void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic,
> rds_ib_stats_inc(s_ib_rx_ring_empty);
>
> if (rds_ib_ring_low(&ic->i_recv_ring)) {
> - rds_ib_recv_refill(conn, 0, GFP_NOWAIT | __GFP_NOWARN);
> + rds_ib_recv_refill(conn, 0, GFP_NOWAIT);
> rds_ib_stats_inc(s_ib_rx_refill_from_cq);
> }
> }
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] SUNRPC: Remove redundant __GFP_NOWARN
2025-08-10 7:29 [PATCH 0/3] net: remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-10 7:29 ` [PATCH 1/3] tcp: cdg: " Qianfeng Rong
2025-08-10 7:29 ` [PATCH 2/3] RDS: " Qianfeng Rong
@ 2025-08-10 7:29 ` Qianfeng Rong
2025-08-10 15:34 ` Chuck Lever
2 siblings, 1 reply; 7+ messages in thread
From: Qianfeng Rong @ 2025-08-10 7:29 UTC (permalink / raw)
To: Chuck Lever, Jeff Layton, NeilBrown, Olga Kornievskaia, Dai Ngo,
Tom Talpey, Trond Myklebust, Anna Schumaker, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Qianfeng Rong, open list:KERNEL NFSD, SUNRPC, AND LOCKD SERVERS,
open list:NETWORKING [GENERAL],
open list
GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
__GFP_NOWARN.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
net/sunrpc/socklib.c | 2 +-
net/sunrpc/xprtrdma/rpc_rdma.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/socklib.c b/net/sunrpc/socklib.c
index 4e92e2a50168..d8d8842c7de5 100644
--- a/net/sunrpc/socklib.c
+++ b/net/sunrpc/socklib.c
@@ -86,7 +86,7 @@ xdr_partial_copy_from_skb(struct xdr_buf *xdr, struct xdr_skb_reader *desc)
/* ACL likes to be lazy in allocating pages - ACLs
* are small by default but can get huge. */
if ((xdr->flags & XDRBUF_SPARSE_PAGES) && *ppage == NULL) {
- *ppage = alloc_page(GFP_NOWAIT | __GFP_NOWARN);
+ *ppage = alloc_page(GFP_NOWAIT);
if (unlikely(*ppage == NULL)) {
if (copied == 0)
return -ENOMEM;
diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c
index 1478c41c7e9d..3aac1456e23e 100644
--- a/net/sunrpc/xprtrdma/rpc_rdma.c
+++ b/net/sunrpc/xprtrdma/rpc_rdma.c
@@ -190,7 +190,7 @@ rpcrdma_alloc_sparse_pages(struct xdr_buf *buf)
ppages = buf->pages + (buf->page_base >> PAGE_SHIFT);
while (len > 0) {
if (!*ppages)
- *ppages = alloc_page(GFP_NOWAIT | __GFP_NOWARN);
+ *ppages = alloc_page(GFP_NOWAIT);
if (!*ppages)
return -ENOBUFS;
ppages++;
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] SUNRPC: Remove redundant __GFP_NOWARN
2025-08-10 7:29 ` [PATCH 3/3] SUNRPC: Remove " Qianfeng Rong
@ 2025-08-10 15:34 ` Chuck Lever
0 siblings, 0 replies; 7+ messages in thread
From: Chuck Lever @ 2025-08-10 15:34 UTC (permalink / raw)
To: Qianfeng Rong, Jeff Layton, NeilBrown, Olga Kornievskaia,
Dai Ngo, Tom Talpey, Trond Myklebust, Anna Schumaker,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, open list:KERNEL NFSD, SUNRPC, AND LOCKD SERVERS,
open list:NETWORKING [GENERAL],
open list
On 8/10/25 3:29 AM, Qianfeng Rong wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> net/sunrpc/socklib.c | 2 +-
> net/sunrpc/xprtrdma/rpc_rdma.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/socklib.c b/net/sunrpc/socklib.c
> index 4e92e2a50168..d8d8842c7de5 100644
> --- a/net/sunrpc/socklib.c
> +++ b/net/sunrpc/socklib.c
> @@ -86,7 +86,7 @@ xdr_partial_copy_from_skb(struct xdr_buf *xdr, struct xdr_skb_reader *desc)
> /* ACL likes to be lazy in allocating pages - ACLs
> * are small by default but can get huge. */
> if ((xdr->flags & XDRBUF_SPARSE_PAGES) && *ppage == NULL) {
> - *ppage = alloc_page(GFP_NOWAIT | __GFP_NOWARN);
> + *ppage = alloc_page(GFP_NOWAIT);
> if (unlikely(*ppage == NULL)) {
> if (copied == 0)
> return -ENOMEM;
> diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c
> index 1478c41c7e9d..3aac1456e23e 100644
> --- a/net/sunrpc/xprtrdma/rpc_rdma.c
> +++ b/net/sunrpc/xprtrdma/rpc_rdma.c
> @@ -190,7 +190,7 @@ rpcrdma_alloc_sparse_pages(struct xdr_buf *buf)
> ppages = buf->pages + (buf->page_base >> PAGE_SHIFT);
> while (len > 0) {
> if (!*ppages)
> - *ppages = alloc_page(GFP_NOWAIT | __GFP_NOWARN);
> + *ppages = alloc_page(GFP_NOWAIT);
> if (!*ppages)
> return -ENOBUFS;
> ppages++;
Acked-by: Chuck Lever <chuck.lever@oracle.com>
--
Chuck Lever
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-08-12 6:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-10 7:29 [PATCH 0/3] net: remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-10 7:29 ` [PATCH 1/3] tcp: cdg: " Qianfeng Rong
2025-08-11 8:54 ` Eric Dumazet
2025-08-10 7:29 ` [PATCH 2/3] RDS: " Qianfeng Rong
2025-08-12 6:54 ` Allison Henderson
2025-08-10 7:29 ` [PATCH 3/3] SUNRPC: Remove " Qianfeng Rong
2025-08-10 15:34 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®