mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Igor Velkov <iav@iav.lv>
Cc: shawn.lin@rock-chips.com,
	"Enrique Hernández Bello" <ehbello@gmail.com>,
	lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org,
	bhelgaas@google.com, robh@kernel.org, heiko@sntech.de,
	linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] PCI: rockchip-host: Retry training and hot-reset a JMB585 on RK3399
Date: Mon, 9 Nov 2026 10:06:55 +0800	[thread overview]
Message-ID: <60fbb95c-63cc-4d22-9e2b-51332a50054d@rock-chips.com> (raw)
In-Reply-To: <20261109-rockchip-pcie-deskew-result-1@iav.lv>

在 2026/11/09 星期一 7:05, Igor Velkov 写道:
> Hi Shawn,
> 
> Thanks. Deskew makes no difference. Helios64, x2, bind/unbind, variants
> alternating every cycle, bad link bring-ups:
> 
>    defaults 6/104, auto deskew off + trim 0xf: 5/104
>    defaults 6/104, magnitude off: 6/104
> 
> Your mail has the magnitude at 0xb, but TRM V1.3 part 2, 17.6.10.1 has
> TX_TERMINATION_TRIM there and DESKEW_MAGNITUDE at 0xc, so I wrote 0xc.

Sorry, my typo.

> 
> DEBUG_DATA_OUT did show something. With Debug Mux Control (0x208) = 5,
> share of samples with in_dllp0_data_valid set, 100 ms window after hot reset:
> 
>    good bring-ups 0.16% (99), bad bring-ups 51% (3, range 45-53)
> 
> The first training looks the same: 0.15% (97) against 47% (5). mgmt_dllp_error,
> crc32_error and in_tlp_error stay 0 in all of them. With the mux at 4,
> start_replay, replay timeout and dl_protocol_error stay 0 too.
> 
> So in a bad bring-up the RC receives a constant error-free stream of DLLPs.
> I read that as the JMB585 repeating flow control init because it does not
> get what the RC sends, but this bus does not show the DLLP type. It would put
> the fault in the RC to JMB585 direction, on x2 only.
> 
> Is there an RC transmitter setting worth trying for that, such as swing or
> de-emphasis? If not, I will stop looking for the cause here.
> 

Reg 0xa is for swing, it says: "This value should be set to (64-56*0 .9/
VDD09) depending on actual voltage of VDD09"

But de-emphasis is fixed in each kind of bus speed.

> Igor
> 


      reply	other threads:[~2026-11-09  2:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24  1:02 Igor Velkov via B4 Relay
2026-10-24  1:02 ` [PATCH RFC 1/2] PCI: rockchip-host: Retry link training that times out Igor Velkov via B4 Relay
2026-10-24  1:02 ` [PATCH RFC 2/2] PCI: rockchip-host: Hot-reset the endpoint before using the link Igor Velkov via B4 Relay
2026-10-26  9:08 ` [PATCH RFC 0/2] PCI: rockchip-host: Retry training and hot-reset a JMB585 on RK3399 Shawn Lin
2026-10-26 18:28   ` Igor Velkov
2026-10-27  0:44     ` Shawn Lin
2026-10-27  1:15       ` Igor Velkov
2026-10-28 17:31       ` Enrique Hernández Bello
2026-10-30 21:30         ` Igor Velkov
2026-11-06  5:09           ` Igor Velkov
2026-11-07  2:35             ` Shawn Lin
2026-11-08 23:05               ` Igor Velkov
2026-11-09  2:06                 ` Shawn Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60fbb95c-63cc-4d22-9e2b-51332a50054d@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=bhelgaas@google.com \
    --cc=ehbello@gmail.com \
    --cc=heiko@sntech.de \
    --cc=iav@iav.lv \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®