mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] ALSA: hda: tas2781-spi: Delete some dead code
       [not found] <cover.1737530177.git.dan.carpenter@linaro.org>
@ 2025-01-22  7:18 ` Dan Carpenter
  2025-01-22  7:18 ` [PATCH 2/2] ALSA: hda: tas2781-spi: Fix error code in tas2781_read_acpi() Dan Carpenter
  1 sibling, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2025-01-22  7:18 UTC (permalink / raw)
  To: Jaroslav Kysela
  Cc: Takashi Iwai, Nathan Chancellor, Baojun Xu, linux-sound, linux-kernel

The scnprintf() function never returns negatives.  And it won't return
zero here either, plus if it did we'd need to fix the error code.
Delete this dead code.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 sound/pci/hda/tas2781_hda_spi.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/pci/hda/tas2781_hda_spi.c b/sound/pci/hda/tas2781_hda_spi.c
index 5be71b538ce0..02794fd6003d 100644
--- a/sound/pci/hda/tas2781_hda_spi.c
+++ b/sound/pci/hda/tas2781_hda_spi.c
@@ -274,13 +274,9 @@ static int tascodec_spi_init(struct tasdevice_priv *tas_priv,
 	 */
 	guard(mutex)(&tas_priv->codec_lock);
 
-	ret = scnprintf(tas_priv->rca_binaryname,
+	scnprintf(tas_priv->rca_binaryname,
 		sizeof(tas_priv->rca_binaryname), "%sRCA%d.bin",
 		tas_priv->dev_name, tas_priv->index);
-	if (ret <= 0) {
-		dev_err(tas_priv->dev, "rca name err:0x%08x\n", ret);
-		return ret;
-	}
 	crc8_populate_msb(tas_priv->crc8_lkp_tbl, TASDEVICE_CRC8_POLYNOMIAL);
 	tas_priv->codec = codec;
 	ret = request_firmware_nowait(module, FW_ACTION_UEVENT,
-- 
2.45.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 2/2] ALSA: hda: tas2781-spi: Fix error code in tas2781_read_acpi()
       [not found] <cover.1737530177.git.dan.carpenter@linaro.org>
  2025-01-22  7:18 ` [PATCH 1/2] ALSA: hda: tas2781-spi: Delete some dead code Dan Carpenter
@ 2025-01-22  7:18 ` Dan Carpenter
  1 sibling, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2025-01-22  7:18 UTC (permalink / raw)
  To: Baojun Xu
  Cc: Jaroslav Kysela, Takashi Iwai, Nathan Chancellor, linux-sound,
	linux-kernel

Propagate the error code from devm_gpiod_get_index_optional().  The
current code returns success.

Fixes: bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 sound/pci/hda/tas2781_hda_spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/tas2781_hda_spi.c b/sound/pci/hda/tas2781_hda_spi.c
index 02794fd6003d..eba9c3a3b944 100644
--- a/sound/pci/hda/tas2781_hda_spi.c
+++ b/sound/pci/hda/tas2781_hda_spi.c
@@ -447,6 +447,7 @@ static int tas2781_read_acpi(struct tas2781_hda *tas_hda,
 		p->reset = devm_gpiod_get_index_optional(physdev, "reset",
 			p->index, GPIOD_OUT_LOW);
 		if (IS_ERR(p->reset)) {
+			ret = PTR_ERR(p->reset);
 			dev_err_probe(p->dev, ret, "Failed on reset GPIO\n");
 			goto err;
 		}
-- 
2.45.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-22  7:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <cover.1737530177.git.dan.carpenter@linaro.org>
2025-01-22  7:18 ` [PATCH 1/2] ALSA: hda: tas2781-spi: Delete some dead code Dan Carpenter
2025-01-22  7:18 ` [PATCH 2/2] ALSA: hda: tas2781-spi: Fix error code in tas2781_read_acpi() Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®