[PATCH 0/2] Add C7xv DSP for AM62A

[PATCH 0/2] Add C7xv DSP for AM62A

[Hari Nagalla]

AM62A SoC family has a C7xv DSP subsystem with Analytics engine. This
susbystem is intended for deep learning purposes. C7xv is similar to C71
DSPs on K3 J7 SoCs with additional harware accelerators and IP updates
for deep learining.

Hari Nagalla (2):
  dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs
  remoteproc: k3-c7x: Add support for C7xv DSP on AM62A SoC

 .../bindings/remoteproc/ti,k3-dsp-rproc.yaml         |  3 +++
 drivers/remoteproc/ti_k3_dsp_remoteproc.c            | 12 ++++++++++++
 2 files changed, 15 insertions(+)

-- 
2.17.1

[PATCH 1/2] dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs

[Hari Nagalla]

The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep
learning purposes. The DSP part is similar to the C71x DSP found on
K3 J7 SoCs, but additional hardware accelerators and IP are added to
the subsystem for deep learning.

Compatible info is updated to match AM62A SoCs.

Signed-off-by: Hari Nagalla <hnagalla@ti.com>
---
 .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml        | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
index cedbc5efdc56..846c9c14169a 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
@@ -34,10 +34,12 @@ properties:
       - ti,j721e-c66-dsp
       - ti,j721e-c71-dsp
       - ti,j721s2-c71-dsp
+      - ti,am62a-c7xv-dsp
     description:
       Use "ti,j721e-c66-dsp" for C66x DSPs on K3 J721E SoCs
       Use "ti,j721e-c71-dsp" for C71x DSPs on K3 J721E SoCs
       Use "ti,j721s2-c71-dsp" for C71x DSPs on K3 J721S2 SoCs
+      Use "ti,am62a-c7xv-dsp" for AM62A Deep learning DSPs on K3 AM62A SoCs
 
   resets:
     description: |
@@ -111,6 +113,7 @@ else:
         enum:
           - ti,j721e-c71-dsp
           - ti,j721s2-c71-dsp
+	  - ti,am62a-c7xv-dsp
   then:
     properties:
       reg:
-- 
2.17.1

[PATCH 2/2] remoteproc: k3-c7x: Add support for C7xv DSP on AM62A SoC

[Hari Nagalla]

Add support to the K3 DSP remoteproc driver to configure the C7xv
subsystem core on AM62A SoCs. The C7xv susbsytem is based on C71 DSP
with anlytics engine for deep leraning purposes. The remoteproc
handling for device management is similar to the C66/C71 DSPs on K3
J7 family SoCs, even though there are additional hardware accelerators
and IP updates to C7xv subsystem.

Signed-off-by: Hari Nagalla <hnagalla@ti.com>
Signed-off-by: Jai Luthra <j-luthra@ti.com>
---
 drivers/remoteproc/ti_k3_dsp_remoteproc.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
index eb9c64f7b9b4..ec626a37fef6 100644
--- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
@@ -870,6 +870,10 @@ static const struct k3_dsp_mem_data c71_mems[] = {
 	{ .name = "l1dram", .dev_addr = 0xe00000 },
 };
 
+static const struct k3_dsp_mem_data c7xv_mems[] = {
+	{ .name = "l2sram", .dev_addr = 0x800000 },
+};
+
 static const struct k3_dsp_dev_data c66_data = {
 	.mems = c66_mems,
 	.num_mems = ARRAY_SIZE(c66_mems),
@@ -884,10 +888,18 @@ static const struct k3_dsp_dev_data c71_data = {
 	.uses_lreset = false,
 };
 
+static const struct k3_dsp_dev_data c7xv_data = {
+	.mems = c7xv_mems,
+	.num_mems = ARRAY_SIZE(c7xv_mems),
+	.boot_align_addr = SZ_2M,
+	.uses_lreset = false,
+};
+
 static const struct of_device_id k3_dsp_of_match[] = {
 	{ .compatible = "ti,j721e-c66-dsp", .data = &c66_data, },
 	{ .compatible = "ti,j721e-c71-dsp", .data = &c71_data, },
 	{ .compatible = "ti,j721s2-c71-dsp", .data = &c71_data, },
+	{ .compatible = "ti,am62a-c7xv-dsp", .data = &c7xv_data, },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, k3_dsp_of_match);
-- 
2.17.1

Re: [PATCH 1/2] dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs

[Krzysztof Kozlowski]

On 28/12/2022 13:36, Hari Nagalla wrote:
> The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep
> learning purposes. The DSP part is similar to the C71x DSP found on
> K3 J7 SoCs, but additional hardware accelerators and IP are added to
> the subsystem for deep learning.
> 
> Compatible info is updated to match AM62A SoCs.
> 
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
>  .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index cedbc5efdc56..846c9c14169a 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -34,10 +34,12 @@ properties:
>        - ti,j721e-c66-dsp
>        - ti,j721e-c71-dsp
>        - ti,j721s2-c71-dsp
> +      - ti,am62a-c7xv-dsp

Add it in some order, e.g. alphabetical.

>      description:
>        Use "ti,j721e-c66-dsp" for C66x DSPs on K3 J721E SoCs
>        Use "ti,j721e-c71-dsp" for C71x DSPs on K3 J721E SoCs
>        Use "ti,j721s2-c71-dsp" for C71x DSPs on K3 J721S2 SoCs
> +      Use "ti,am62a-c7xv-dsp" for AM62A Deep learning DSPs on K3 AM62A SoCs
>  
>    resets:
>      description: |
> @@ -111,6 +113,7 @@ else:
>          enum:
>            - ti,j721e-c71-dsp
>            - ti,j721s2-c71-dsp
> +	  - ti,am62a-c7xv-dsp

Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).

Wrong indentation.

Best regards,
Krzysztof

Re: [PATCH 2/2] remoteproc: k3-c7x: Add support for C7xv DSP on AM62A SoC

[Raghavendra, Vignesh]

Hi Hari,

On 12/28/2022 6:06 PM, Hari Nagalla wrote:
> Add support to the K3 DSP remoteproc driver to configure the C7xv
> subsystem core on AM62A SoCs. The C7xv susbsytem is based on C71 DSP
> with anlytics engine for deep leraning purposes. The remoteproc
> handling for device management is similar to the C66/C71 DSPs on K3
> J7 family SoCs, even though there are additional hardware accelerators
> and IP updates to C7xv subsystem.
> 
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> ---

Signed-off-by of submitter should be at the last.

I see original author of the patch is Jai here. So you need to amend the
patch such that original author is set to Jai. His Signed-off-by should
be the first and then yours.

>  drivers/remoteproc/ti_k3_dsp_remoteproc.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> index eb9c64f7b9b4..ec626a37fef6 100644
> --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> @@ -870,6 +870,10 @@ static const struct k3_dsp_mem_data c71_mems[] = {
>  	{ .name = "l1dram", .dev_addr = 0xe00000 },
>  };
>  
> +static const struct k3_dsp_mem_data c7xv_mems[] = {
> +	{ .name = "l2sram", .dev_addr = 0x800000 },
> +};
> +
>  static const struct k3_dsp_dev_data c66_data = {
>  	.mems = c66_mems,
>  	.num_mems = ARRAY_SIZE(c66_mems),
> @@ -884,10 +888,18 @@ static const struct k3_dsp_dev_data c71_data = {
>  	.uses_lreset = false,
>  };
>  
> +static const struct k3_dsp_dev_data c7xv_data = {
> +	.mems = c7xv_mems,
> +	.num_mems = ARRAY_SIZE(c7xv_mems),
> +	.boot_align_addr = SZ_2M,
> +	.uses_lreset = false,
> +};
> +
>  static const struct of_device_id k3_dsp_of_match[] = {
>  	{ .compatible = "ti,j721e-c66-dsp", .data = &c66_data, },
>  	{ .compatible = "ti,j721e-c71-dsp", .data = &c71_data, },
>  	{ .compatible = "ti,j721s2-c71-dsp", .data = &c71_data, },
> +	{ .compatible = "ti,am62a-c7xv-dsp", .data = &c7xv_data, },
>  	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, k3_dsp_of_match);

Re: [PATCH 1/2] dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs

[Rob Herring]

On Wed, 28 Dec 2022 06:36:54 -0600, Hari Nagalla wrote:
> The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep
> learning purposes. The DSP part is similar to the C71x DSP found on
> K3 J7 SoCs, but additional hardware accelerators and IP are added to
> the subsystem for deep learning.
> 
> Compatible info is updated to match AM62A SoCs.
> 
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
>  .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dts'
Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: found character '\t' that cannot start any token
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: found character '\t' that cannot start any token
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml: ignoring, error parsing file
make: *** [Makefile:1508: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221228123655.15384-2-hnagalla@ti.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 1/2] dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs

[Hari Nagalla]

On 12/28/22 06:38, Krzysztof Kozlowski wrote:
>>   
>>     resets:
>>       description: |
>> @@ -111,6 +113,7 @@ else:
>>           enum:
>>             - ti,j721e-c71-dsp
>>             - ti,j721s2-c71-dsp
>> +	  - ti,am62a-c7xv-dsp
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> 
> Wrong indentation.
Seems, i used a wrong option in our patch verify script. Used the 
correct options and fixed it. sending v2 with review comment updates. Thanks

Re: [PATCH 2/2] remoteproc: k3-c7x: Add support for C7xv DSP on AM62A SoC

[Hari Nagalla]

On 12/28/22 07:32, Raghavendra, Vignesh wrote:
>> with anlytics engine for deep leraning purposes. The remoteproc
>> handling for device management is similar to the C66/C71 DSPs on K3
>> J7 family SoCs, even though there are additional hardware accelerators
>> and IP updates to C7xv subsystem.
>>
>> Signed-off-by: Hari Nagalla<hnagalla@ti.com>
>> Signed-off-by: Jai Luthra<j-luthra@ti.com>
>> ---
> Signed-off-by of submitter should be at the last.
> 
> I see original author of the patch is Jai here. So you need to amend the
> patch such that original author is set to Jai. His Signed-off-by should
> be the first and then yours.
> 
Thanks for pointing it out. Fixed, sending v2 with the corrections.