From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
egorenar@linux.ibm.com,
Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: regression: 9a56493f6942 "uts: Use generic ns_common::count" broke makedumpfile 1.6.7
Date: Wed, 16 Dec 2020 18:20:36 +0300 [thread overview]
Message-ID: <61ae6135-dca7-db73-f048-0a35f69cb5c4@virtuozzo.com> (raw)
In-Reply-To: <c3132ac7e0536a30aefc833df16f5a24de7e4529.camel@gmx.de>
On 16.12.2020 17:49, Mike Galbraith wrote:
> On Wed, 2020-12-16 at 15:31 +0100, Mike Galbraith wrote:
>> On Wed, 2020-12-16 at 17:23 +0300, Kirill Tkhai wrote:
>>>
>>> Does this regression only cause that one error message "check_release: Can't get the kernel version"
>>> is printed instead of another: "The kernel version is not supported."?
>>
>> The thing does indeed mutter about the kernel version, with or without
>> 9a56493f6942 reverted, but it work despite the muttering with
>> 9a56493f6942 reverted.
>
> makedumpfile 1.6.7 source only claims to work up to linux-5.4.8, but
> actually does work all the way up until 9a56493f6942.
>
> If the answer here is that v1,6,7 has reached EOL, that's fine, I'll
> just carry a revert until I can cobble together an updated package.
I think, since there is no a makedumpfile version working, this is a regression,
and it should be workarounded it in kernel.
We may consider a patch like the below till updated makedumpfile is not published:
diff --git a/include/linux/utsname.h b/include/linux/utsname.h
index 2b1737c9b244..d6bcad448f52 100644
--- a/include/linux/utsname.h
+++ b/include/linux/utsname.h
@@ -8,6 +8,7 @@
#include <linux/ns_common.h>
#include <linux/err.h>
#include <uapi/linux/utsname.h>
+#include <linux/kref.h>
enum uts_proc {
UTS_PROC_OSTYPE,
@@ -21,6 +22,7 @@ struct user_namespace;
extern struct user_namespace init_user_ns;
struct uts_namespace {
+ struct kref unused;
struct new_utsname name;
struct user_namespace *user_ns;
struct ucounts *ucounts;
next prev parent reply other threads:[~2020-12-16 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 11:02 Mike Galbraith
2020-12-16 12:35 ` Kirill Tkhai
2020-12-16 13:32 ` Mike Galbraith
2020-12-16 14:23 ` Kirill Tkhai
2020-12-16 14:25 ` Christian Brauner
2020-12-16 14:31 ` Mike Galbraith
2020-12-16 14:49 ` Mike Galbraith
2020-12-16 15:20 ` Kirill Tkhai [this message]
2020-12-16 15:37 ` Christian Brauner
2020-12-17 2:59 ` Mike Galbraith
2021-01-11 11:53 ` Alexander Egorenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61ae6135-dca7-db73-f048-0a35f69cb5c4@virtuozzo.com \
--to=ktkhai@virtuozzo.com \
--cc=christian.brauner@ubuntu.com \
--cc=efault@gmx.de \
--cc=egorenar@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®