mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Kirill Tkhai <ktkhai@virtuozzo.com>,
	LKML <linux-kernel@vger.kernel.org>,
	egorenar@linux.ibm.com,
	Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: regression: 9a56493f6942 "uts: Use generic ns_common::count" broke makedumpfile 1.6.7
Date: Wed, 16 Dec 2020 14:32:18 +0100	[thread overview]
Message-ID: <ad3bfa510282d3122069dafe98666aa2d6b5b0ff.camel@gmx.de> (raw)
In-Reply-To: <6933cde2-7d43-7d7e-066c-1c4a13c752dd@virtuozzo.com>

On Wed, 2020-12-16 at 15:35 +0300, Kirill Tkhai wrote:
> Hi, Alexander,
>
> On 16.12.2020 14:02, Mike Galbraith wrote:
> > Greetings,
> >
> > With this commit, bisected and confirmed, kdump stops working here,
> > makedumpfile saying "check_release: Can't get the kernel version".
>
> hasn't your commit 55d9e11398a4 "kdump: append uts_namespace.name offset to VMCOREINFO"
> fixed this issue?

FWIW, I applied the below, but it didn't help.

---
 kernel/crash_core.c |    1 +
 1 file changed, 1 insertion(+)

--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_
 	VMCOREINFO_PAGESIZE(PAGE_SIZE);

 	VMCOREINFO_SYMBOL(init_uts_ns);
+	VMCOREINFO_OFFSET(uts_namespace, name);
 	VMCOREINFO_SYMBOL(node_online_map);
 #ifdef CONFIG_MMU
 	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);


  reply	other threads:[~2020-12-16 13:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 11:02 Mike Galbraith
2020-12-16 12:35 ` Kirill Tkhai
2020-12-16 13:32   ` Mike Galbraith [this message]
2020-12-16 14:23     ` Kirill Tkhai
2020-12-16 14:25       ` Christian Brauner
2020-12-16 14:31       ` Mike Galbraith
2020-12-16 14:49         ` Mike Galbraith
2020-12-16 15:20           ` Kirill Tkhai
2020-12-16 15:37             ` Christian Brauner
2020-12-17  2:59             ` Mike Galbraith
2021-01-11 11:53   ` Alexander Egorenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad3bfa510282d3122069dafe98666aa2d6b5b0ff.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=egorenar@linux.ibm.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®