mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Kirill Tkhai <ktkhai@virtuozzo.com>,
	LKML <linux-kernel@vger.kernel.org>,
	egorenar@linux.ibm.com,
	Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: regression: 9a56493f6942 "uts: Use generic ns_common::count" broke makedumpfile 1.6.7
Date: Thu, 17 Dec 2020 03:59:59 +0100	[thread overview]
Message-ID: <75c22ad01a500ecd906f0088ecd5a68161a91593.camel@gmx.de> (raw)
In-Reply-To: <61ae6135-dca7-db73-f048-0a35f69cb5c4@virtuozzo.com>

On Wed, 2020-12-16 at 18:20 +0300, Kirill Tkhai wrote:
>
> We may consider a patch like the below till updated makedumpfile is not published:

It's nice to be considerate to the tool folks, but that can leave a
wake of cruft (thinks printk ringbuffer.. ew), so it's probably best to
just let it break.  The why and wherefore is documented in this thread,
that's enough for anybody who needs a quick fix to get on with frobbing
their dang buggy bleeding edge kernel ;-)

> diff --git a/include/linux/utsname.h b/include/linux/utsname.h
> index 2b1737c9b244..d6bcad448f52 100644
> --- a/include/linux/utsname.h
> +++ b/include/linux/utsname.h
> @@ -8,6 +8,7 @@
>  #include <linux/ns_common.h>
>  #include <linux/err.h>
>  #include <uapi/linux/utsname.h>
> +#include <linux/kref.h>
>
>  enum uts_proc {
>  	UTS_PROC_OSTYPE,
> @@ -21,6 +22,7 @@ struct user_namespace;
>  extern struct user_namespace init_user_ns;
>
>  struct uts_namespace {
> +	struct kref unused;
>  	struct new_utsname name;
>  	struct user_namespace *user_ns;
>  	struct ucounts *ucounts;


  parent reply	other threads:[~2020-12-17  3:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 11:02 Mike Galbraith
2020-12-16 12:35 ` Kirill Tkhai
2020-12-16 13:32   ` Mike Galbraith
2020-12-16 14:23     ` Kirill Tkhai
2020-12-16 14:25       ` Christian Brauner
2020-12-16 14:31       ` Mike Galbraith
2020-12-16 14:49         ` Mike Galbraith
2020-12-16 15:20           ` Kirill Tkhai
2020-12-16 15:37             ` Christian Brauner
2020-12-17  2:59             ` Mike Galbraith [this message]
2021-01-11 11:53   ` Alexander Egorenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75c22ad01a500ecd906f0088ecd5a68161a91593.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=egorenar@linux.ibm.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®